From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: Re: [PATCH v2 2/2] tools/configure: Check if pixman is present on the system when building QEMU Date: Fri, 16 Jan 2015 11:43:13 +0000 Message-ID: <21688.63825.799785.771492@mariner.uk.xensource.com> References: <1421355978-14208-1-git-send-email-julien.grall@linaro.org> <1421355978-14208-3-git-send-email-julien.grall@linaro.org> <1421402753.19839.35.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YC5JV-00021U-55 for xen-devel@lists.xenproject.org; Fri, 16 Jan 2015 11:43:41 +0000 In-Reply-To: <1421402753.19839.35.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, Julien Grall , wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org Ian Campbell writes ("Re: [PATCH v2 2/2] tools/configure: Check if pixman is present on the system when building QEMU"): > On Thu, 2015-01-15 at 21:06 +0000, Julien Grall wrote: > > -dnl Glib 2.0 is only required when QEMU is built > > +dnl Glib 2.0 and pixman are only required when QEMU is built > > Rather than an ever increasing list here I propose to say "The following > are only...", and perhaps insert an "upstream" before QEMU, unless these > are needed for trad too (in which case the condition isn't quite right). > I think glib and pixman are only for upstream though. > > I can do that on commit though if you like. Either way is fine by me. Ian.