From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86D60C433F5 for ; Tue, 17 May 2022 08:12:59 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 139C884207; Tue, 17 May 2022 10:12:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=foss.st.com header.i=@foss.st.com header.b="KfAgP1QP"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B9E9480085; Tue, 17 May 2022 10:12:54 +0200 (CEST) Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id F2E5A80544 for ; Tue, 17 May 2022 10:12:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=prvs=1136db00ec=patrick.delaunay@foss.st.com Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24H6qehO024847; Tue, 17 May 2022 10:12:50 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=vQPupJ33EJRMFmslt/AvlsFggZu5KwZgmUKw11AztiY=; b=KfAgP1QPZd45EyyWMDfAPDCR9fdpum19vYcLBd+ZD1ZsFHu+aicYszbu5IVPIbWm4DuE cBNd1I2rzuFnaUf0MguPkEX7rqLm0RCOQSwvBu7JoLlYt14FQ1Vev2XvfpW2Ej0Lkjjx TS4+N4a0uNUYZDqUHXb0CjfTIBxOJG71hgOC78/2CXrYyelYA13lrDSy9e6AgiS0C66l +FUxaY8EyahXLs73Q4yhWhf0oLLDgVcjGj8F8ip7rb6SVUDAPoeXBn2Ds4A6sPH010z8 Xnex1u2Tj/gWGi/CeLFfKXxbjS2kOu9TYagSlt/z7GGjHnYOlRnJjqvHtVlygGMRA3Z+ jQ== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3g21j8rpn6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 May 2022 10:12:50 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id AFD1D100034; Tue, 17 May 2022 10:12:49 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node2.st.com [10.75.127.5]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 9CA0F2138F7; Tue, 17 May 2022 10:12:49 +0200 (CEST) Received: from [10.48.0.213] (10.75.127.51) by SFHDAG2NODE2.st.com (10.75.127.5) with Microsoft SMTP Server (TLS) id 15.0.1497.26; Tue, 17 May 2022 10:12:48 +0200 Message-ID: <21688d64-ffeb-d0b7-b6e5-2efeb3f33ec1@foss.st.com> Date: Tue, 17 May 2022 10:12:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 0/4] stm32mp: add minimal RCC support for STM32MP13 Content-Language: en-US To: Sean Anderson , CC: Gabriel FERNANDEZ , Lukasz Majewski , Patrice Chotard , Tom Rini , U-Boot STM32 References: <20220510075114.1238086-1-patrick.delaunay@foss.st.com> <41b170c1-99ba-18ac-4a94-01c90f67b97c@gmail.com> From: Patrick DELAUNAY In-Reply-To: <41b170c1-99ba-18ac-4a94-01c90f67b97c@gmail.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.75.127.51] X-ClientProxiedBy: SFHDAG2NODE3.st.com (10.75.127.6) To SFHDAG2NODE2.st.com (10.75.127.5) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-17_01,2022-05-16_02,2022-02-23_01 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi, On 5/11/22 18:44, Sean Anderson wrote: > Hi Patrick, > > On 5/10/22 3:51 AM, Patrick Delaunay wrote: >> >> Add a minimal support for STM32MP13 RCC, the reset and clock controller >> - update of the RCC MISC driver to bind the correct clock and reset >> driver >> - reset driver, same than STM32MP15x = drivers/reset/stm32-reset.c >> - clock driver, add a empty driver for STM32MP13x = >>    drivers/clk/stm32/clk-stm32mp13.c >> - Add RCC node in SOC device tree with u-boot,dm-pre-reloc property >> >> This serie is only a preliminary step for STM32MP13 clock and reset >> support >> in U-Boot, based on Linux kernel binding introduced by [1] and it >> prepares >> the next device tree alignment with Linux kernel. >> >> The functional STMP13 clock driver based on CCF and on SCMI clocks >> provided by OP-TEE and the clock and reset references in SOC device tree >> will be pushed when the associated patches in [1] will be accepted. >> >> [1] Introduction of STM32MP13 RCC driver (Reset Clock Controller) >> https://lore.kernel.org/linux-arm-kernel/20220316131000.9874-1-gabriel.fernandez@foss.st.com/ > > I'm not really sure what the purpose of this series is. Can you > elaborate a bit on why we need a dummy clock driver? Why don't > you just add the binding to the device tree without the associated > driver? After this serie, the RCC reset part is functional on STM32MP13 (probe and ops) even if the associated binding is not present in device tree. tested with: ------------------------- arch/arm/dts/stm32mp131.dtsi ------------------------- index fcb0af09b5..d9c6185bcf 100644 @@ -197,6 +197,7 @@              interrupt-names = "cmd_irq";              clocks = <&clk_pll4_p>;              clock-names = "apb_pclk"; +            resets = <&rcc 14224>;              cap-sd-highspeed;              cap-mmc-highspeed;              max-frequency = <130000000>; A dummy STM32MP13 clock driver is requested to allow RCC MISC and RCC RESET binding and probe without issue. This reset support was requested by SDMCC driver and SD-Card boot, before the patch: http://patchwork.ozlabs.org/project/uboot/patch/20220506160540.13.I39b69e8dc7b43b8e265e77388fb53f7c1fa2a007@changeid/ As we solve the SDMCC dependency issue (reset become optionnal), so this serie is no more mandatory. This serie is a just a cleanup / preliminary step, but I can drop this dummy RCC driver if it is disturbing. > > --Sean Patrick