From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH OSSTEST v2 06/18] TestSupport: always use xl
	for generic operations.
Date: Tue, 20 Jan 2015 18:26:36 +0000
Message-ID: <21694.40412.281057.184425@mariner.uk.xensource.com>
References: <1417536141.29004.6.camel@citrix.com>
	<1417536299-1810-6-git-send-email-ian.campbell@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1417536299-1810-6-git-send-email-ian.campbell@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Jim Fehlig <jfehlig@suse.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

Ian Campbell writes ("[PATCH OSSTEST v2 06/18] TestSupport: always use xl for generic operations."):
> For several operations in TestSupport.pm the actual toolstack isn't really
> relevant, since we want info straight from Xen. For simplicity just use xl (or
> xm) in these cases, to avoid needing to implement the following specially for
> each toolstack:
...
> +sub common_toolstack () {
> +    my $tsname= $r{toolstack} || 'xend';
> +    my $ts = 'xl';
> +    $ts = 'xm' if $tsname eq 'xend';
> +    return $ts;
> +}

Shouldn't this look this up in the host ?  I can imagine scenarios
where we have multiple toolstacks at different times or on different
hosts (eg, to test upgrades or sidegrades).

So I think common_toolstack at the very least should take a $ho.

Ian.