Re: [PATCH OSSTEST v2 09/18] Toolstack: Refactor consolecmd handling

[Ian Jackson <Ian.Jackson@eu.citrix.com>]

Ian Campbell writes ("[PATCH OSSTEST v2 09/18] Toolstack: Refactor consolecmd handling"):
...
> diff --git a/Osstest/Toolstack/xend.pm b/Osstest/Toolstack/xend.pm
> index c921c20..896d949 100644
> --- a/Osstest/Toolstack/xend.pm
> +++ b/Osstest/Toolstack/xend.pm
> @@ -36,5 +36,6 @@ sub new {
>  # Defer to xl driver for most things
>  sub destroy { return &Osstest::Toolstack::xl::destroy; }
>  sub create { return &Osstest::Toolstack::xl::create; }
> +sub consolecmd { return &Osstest::Toolstack::xl::consolecmd; }

I hesitate to suggest this, but perhaps Exporter(3pm)'s inheritance
feature (@ISA, I think) might do this more automatically ?

> diff --git a/ts-logs-capture b/ts-logs-capture
> index 841ad5a..dbca13a 100755
> --- a/ts-logs-capture
> +++ b/ts-logs-capture
> @@ -195,7 +195,7 @@ sub fetch_logs_guest ($) {
>          logm("cannot find domid: $@");
>          return;
>      }
> -    my $consolecmd= toolstack($ho)->{Command}." console $gho->{Name}";
> +    my $consolecmd= toolstack($ho)->consolecmd($gho);
>      try_cmd_output_save("sleep 1 | $consolecmd | cat",
>                          "guest-$gho->{Name}-console");

Does `virsh console' work the same way as xl console, particularly wrt
this weird thing with the sleep 1 etc. ?

Ian.