From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B62AC433FE for ; Tue, 22 Mar 2022 08:40:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231458AbiCVIlf (ORCPT ); Tue, 22 Mar 2022 04:41:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231260AbiCVIlb (ORCPT ); Tue, 22 Mar 2022 04:41:31 -0400 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F11725D8; Tue, 22 Mar 2022 01:40:04 -0700 (PDT) Received: by mail-wr1-f50.google.com with SMTP id p9so23824857wra.12; Tue, 22 Mar 2022 01:40:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from :subject:content-language:to:cc:references:in-reply-to :content-transfer-encoding; bh=/Tfn3grWM8EBZ0IFyy5BUNygjofN0WZXFLyZhdj5fD8=; b=UlDPQna4CCdnJGBrEqI6B8NF4N/ps+D1GLXFLuXXlmtvEs5zpF2MdoIvIpAoofLeJU ZOKbOec2wgadltr6Qxs9Bw0nrxcduvkxlHaH1Vvv52+VNzvVbYmXtIxQWA6oaOk7RGFr sERxThNv90Ev5yaTWNhyfNU2oDhqyhV3PKWuiq/sHOtD52XQf4rL+pYRRlAOgQVgZ6DU eOVp/S1BrSS662yJTlpIzrhmQOaQE7AH5ztC8xUv2ncfWcK6yrwQLz5LKFAPc0Vo38X6 oYVpeD6I9Ar4f7bCAmKKBf1b3lNq62eawlTJnM8MLdL9vKab0kz54DS0su+Cbjur5pq5 mpvw== X-Gm-Message-State: AOAM530r1O45zpM53iKwyh+LSkPDwKvpfbvxBeQQVIpUXZfmykDCVIn2 YJYHELMAlVFb7HDhmB1tY9iGFEc7K7U= X-Google-Smtp-Source: ABdhPJxkORCp7gIYkTNw3KV3bdX3kmbwKYImn33rbcbzHbL5oapUbtQ9rTY8znVVhU8GFn8NowZFyg== X-Received: by 2002:a5d:4609:0:b0:203:e792:3add with SMTP id t9-20020a5d4609000000b00203e7923addmr21101655wrq.657.1647938402451; Tue, 22 Mar 2022 01:40:02 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.googlemail.com with ESMTPSA id i10-20020a0560001aca00b00203daf3759asm16563813wry.68.2022.03.22.01.40.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Mar 2022 01:40:01 -0700 (PDT) Message-ID: <216b98d5-a254-4527-c569-9f3397811e70@kernel.org> Date: Tue, 22 Mar 2022 09:40:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 From: Krzysztof Kozlowski Subject: Re: [PATCH v2 3/3] ARM: dts: aspeed: add reset properties into MDIO nodes Content-Language: en-US To: Dylan Hung , "robh+dt@kernel.org" , "joel@jms.id.au" , "andrew@aj.id.au" , "andrew@lunn.ch" , "hkallweit1@gmail.com" , "linux@armlinux.org.uk" , "davem@davemloft.net" , "kuba@kernel.org" , "pabeni@redhat.com" , "p.zabel@pengutronix.de" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" Cc: BMC-SW , "stable@vger.kernel.org" References: <20220321095648.4760-1-dylan_hung@aspeedtech.com> <20220321095648.4760-4-dylan_hung@aspeedtech.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/03/2022 03:32, Dylan Hung wrote: >> -----Original Message----- >> From: Krzysztof Kozlowski [mailto:krzk@kernel.org] >> Sent: 2022年3月21日 11:53 PM >> To: Dylan Hung ; robh+dt@kernel.org; >> joel@jms.id.au; andrew@aj.id.au; andrew@lunn.ch; hkallweit1@gmail.com; >> linux@armlinux.org.uk; davem@davemloft.net; kuba@kernel.org; >> pabeni@redhat.com; p.zabel@pengutronix.de; devicetree@vger.kernel.org; >> linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org; >> linux-kernel@vger.kernel.org; netdev@vger.kernel.org >> Cc: BMC-SW ; stable@vger.kernel.org >> Subject: Re: [PATCH v2 3/3] ARM: dts: aspeed: add reset properties into MDIO >> nodes >> >> On 21/03/2022 10:56, Dylan Hung wrote: >>> Add reset control properties into MDIO nodes. The 4 MDIO controllers in >>> AST2600 SOC share one reset control bit SCU50[3]. >>> >>> Signed-off-by: Dylan Hung >>> Cc: stable@vger.kernel.org >> >> Please describe the bug being fixed. See stable-kernel-rules. > > Thank you for your comment. > The reset deassertion of the MDIO device was usually done by the bootloader (u-boot). > However, one of our clients uses proprietary bootloader and doesn't deassert the MDIO > reset so failed to access the HW in kernel driver. The reset deassertion is missing in the > kernel driver since it was created, should I add a BugFix for the first commit of this driver? > Or would it be better if I remove " Cc: stable@vger.kernel.org"? This rather looks like a missing feature, not a bug. Anyway any description must be in commit message. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8782C4332F for ; Tue, 22 Mar 2022 08:41:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sGhe/9c5ceUgA8tvZFZSuLSu81Q3m+DpX/Ctr4ly+Yg=; b=kITpI8+xMGwgeW XzJSfgIb0Hs4hPpSqIX2XTm2ZkyE5/QAxN7PQhjii9xml45FM0JpO5zzwxetThxMCZYCMXQhDKJbD +quIfbjeDv9y+M6q4wkCaUSHLg21UxDqeOJpMgpXb08u51loZIt6NR6I7GwNWJl3c+7IciOXn2JTI xpakUvEOrTIqnmzqd+6+HMmaDx4dgLOIpOeQY6LyVx6kr9asfJfQFoULEZ5XMUek3+xOQXyYUyJFb 4/6EvLQE61WXR1nh1fz8G8J/88GinjkmXhKZxaib8orRR86zY5doMdUVmcm9rHu0l/tZOV1F1alI5 /b18Mrc/pTPtDBbq9ofA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWa3j-00ARr4-WE; Tue, 22 Mar 2022 08:40:08 +0000 Received: from mail-wr1-f54.google.com ([209.85.221.54]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWa3g-00ARqW-P8 for linux-arm-kernel@lists.infradead.org; Tue, 22 Mar 2022 08:40:06 +0000 Received: by mail-wr1-f54.google.com with SMTP id v22so9946947wra.2 for ; Tue, 22 Mar 2022 01:40:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from :subject:content-language:to:cc:references:in-reply-to :content-transfer-encoding; bh=/Tfn3grWM8EBZ0IFyy5BUNygjofN0WZXFLyZhdj5fD8=; b=gc6gaj/9RQJU4kUiTqUU1ybXP5uhFR4Q4rWzyzCRHAF0f21WFraxPMCxc67nAaOfvD F5MRs1jesosQcr0ynAfcj64+hQxhY7MCJyVhCAU0Oti0CIS8y8mTkVgYbGeEZ0e9uemG 006eNoTe6T3xbV07rFWUa0ni+VN/j7RwReUpzeGHLl8NQlhJxC3mISsDyH0ko/36g8un psoJPde58lkPew2hf1JpePAOCXOMjSq5e5Ur4aJMMPPB05GNS8y8CxQhJI45q7AOIVAv UDZAlqVBoqi6f35DLdsVh4umAP/tmki1THHyTr8K5vse8osl57APT9axxuxBSJ3QwwzB WDWQ== X-Gm-Message-State: AOAM530K1tRJ4dp8ytYans/r+wGZwGE7RJUwwjSdPg/86rZhALuwoCQe EXONo6C+WQUBIes7oKJoJX8= X-Google-Smtp-Source: ABdhPJxkORCp7gIYkTNw3KV3bdX3kmbwKYImn33rbcbzHbL5oapUbtQ9rTY8znVVhU8GFn8NowZFyg== X-Received: by 2002:a5d:4609:0:b0:203:e792:3add with SMTP id t9-20020a5d4609000000b00203e7923addmr21101655wrq.657.1647938402451; Tue, 22 Mar 2022 01:40:02 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.googlemail.com with ESMTPSA id i10-20020a0560001aca00b00203daf3759asm16563813wry.68.2022.03.22.01.40.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Mar 2022 01:40:01 -0700 (PDT) Message-ID: <216b98d5-a254-4527-c569-9f3397811e70@kernel.org> Date: Tue, 22 Mar 2022 09:40:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 From: Krzysztof Kozlowski Subject: Re: [PATCH v2 3/3] ARM: dts: aspeed: add reset properties into MDIO nodes Content-Language: en-US To: Dylan Hung , "robh+dt@kernel.org" , "joel@jms.id.au" , "andrew@aj.id.au" , "andrew@lunn.ch" , "hkallweit1@gmail.com" , "linux@armlinux.org.uk" , "davem@davemloft.net" , "kuba@kernel.org" , "pabeni@redhat.com" , "p.zabel@pengutronix.de" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" Cc: BMC-SW , "stable@vger.kernel.org" References: <20220321095648.4760-1-dylan_hung@aspeedtech.com> <20220321095648.4760-4-dylan_hung@aspeedtech.com> In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220322_014004_844235_2DF4E9D0 X-CRM114-Status: GOOD ( 17.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjIvMDMvMjAyMiAwMzozMiwgRHlsYW4gSHVuZyB3cm90ZToKPj4gLS0tLS1PcmlnaW5hbCBN ZXNzYWdlLS0tLS0KPj4gRnJvbTogS3J6eXN6dG9mIEtvemxvd3NraSBbbWFpbHRvOmtyemtAa2Vy bmVsLm9yZ10KPj4gU2VudDogMjAyMuW5tDPmnIgyMeaXpSAxMTo1MyBQTQo+PiBUbzogRHlsYW4g SHVuZyA8ZHlsYW5faHVuZ0Bhc3BlZWR0ZWNoLmNvbT47IHJvYmgrZHRAa2VybmVsLm9yZzsKPj4g am9lbEBqbXMuaWQuYXU7IGFuZHJld0Bhai5pZC5hdTsgYW5kcmV3QGx1bm4uY2g7IGhrYWxsd2Vp dDFAZ21haWwuY29tOwo+PiBsaW51eEBhcm1saW51eC5vcmcudWs7IGRhdmVtQGRhdmVtbG9mdC5u ZXQ7IGt1YmFAa2VybmVsLm9yZzsKPj4gcGFiZW5pQHJlZGhhdC5jb207IHAuemFiZWxAcGVuZ3V0 cm9uaXguZGU7IGRldmljZXRyZWVAdmdlci5rZXJuZWwub3JnOwo+PiBsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmc7IGxpbnV4LWFzcGVlZEBsaXN0cy5vemxhYnMub3JnOwo+PiBs aW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnOyBuZXRkZXZAdmdlci5rZXJuZWwub3JnCj4+IENj OiBCTUMtU1cgPEJNQy1TV0Bhc3BlZWR0ZWNoLmNvbT47IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmcK Pj4gU3ViamVjdDogUmU6IFtQQVRDSCB2MiAzLzNdIEFSTTogZHRzOiBhc3BlZWQ6IGFkZCByZXNl dCBwcm9wZXJ0aWVzIGludG8gTURJTwo+PiBub2Rlcwo+Pgo+PiBPbiAyMS8wMy8yMDIyIDEwOjU2 LCBEeWxhbiBIdW5nIHdyb3RlOgo+Pj4gQWRkIHJlc2V0IGNvbnRyb2wgcHJvcGVydGllcyBpbnRv IE1ESU8gbm9kZXMuICBUaGUgNCBNRElPIGNvbnRyb2xsZXJzIGluCj4+PiBBU1QyNjAwIFNPQyBz aGFyZSBvbmUgcmVzZXQgY29udHJvbCBiaXQgU0NVNTBbM10uCj4+Pgo+Pj4gU2lnbmVkLW9mZi1i eTogRHlsYW4gSHVuZyA8ZHlsYW5faHVuZ0Bhc3BlZWR0ZWNoLmNvbT4KPj4+IENjOiBzdGFibGVA dmdlci5rZXJuZWwub3JnCj4+Cj4+IFBsZWFzZSBkZXNjcmliZSB0aGUgYnVnIGJlaW5nIGZpeGVk LiBTZWUgc3RhYmxlLWtlcm5lbC1ydWxlcy4KPiAKPiBUaGFuayB5b3UgZm9yIHlvdXIgY29tbWVu dC4KPiBUaGUgcmVzZXQgZGVhc3NlcnRpb24gb2YgdGhlIE1ESU8gZGV2aWNlIHdhcyB1c3VhbGx5 IGRvbmUgYnkgdGhlIGJvb3Rsb2FkZXIgKHUtYm9vdCkuCj4gSG93ZXZlciwgb25lIG9mIG91ciBj bGllbnRzIHVzZXMgcHJvcHJpZXRhcnkgYm9vdGxvYWRlciBhbmQgZG9lc24ndCBkZWFzc2VydCB0 aGUgTURJTwo+IHJlc2V0IHNvIGZhaWxlZCB0byBhY2Nlc3MgdGhlIEhXIGluIGtlcm5lbCBkcml2 ZXIuICBUaGUgcmVzZXQgZGVhc3NlcnRpb24gaXMgbWlzc2luZyBpbiB0aGUKPiBrZXJuZWwgZHJp dmVyIHNpbmNlIGl0IHdhcyBjcmVhdGVkLCBzaG91bGQgSSBhZGQgYSBCdWdGaXggZm9yIHRoZSBm aXJzdCBjb21taXQgb2YgdGhpcyBkcml2ZXI/Cj4gT3Igd291bGQgaXQgYmUgYmV0dGVyIGlmIEkg cmVtb3ZlICIgQ2M6IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmciPwoKVGhpcyByYXRoZXIgbG9va3Mg bGlrZSBhIG1pc3NpbmcgZmVhdHVyZSwgbm90IGEgYnVnLiBBbnl3YXkgYW55CmRlc2NyaXB0aW9u IG11c3QgYmUgaW4gY29tbWl0IG1lc3NhZ2UuCgoKQmVzdCByZWdhcmRzLApLcnp5c3p0b2YKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1r ZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJu ZWwK