All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Jim Fehlig <jfehlig@suse.com>, Wei Liu <wei.liu2@citrix.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH RFC] libxl: set disk defaults in remove/destroy functions
Date: Mon, 2 Feb 2015 13:41:58 +0000	[thread overview]
Message-ID: <21711.32422.174681.429543@mariner.uk.xensource.com> (raw)
In-Reply-To: <1422884160.19293.23.camel@citrix.com>

Ian Campbell writes ("Re: [Xen-devel] [PATCH RFC] libxl: set disk defaults in remove/destroy functions"):
> Perhaps better would be to add a new parameter to0 DEFINE_DEVICE_REMOVE
> like extra_setdefault_args which is pasted in the appropriate place?

I don't think this is right because...

> I suppose on remove its not so much a case of choosing a suitable
> backend as reflecting the actual current reality for that device. Which
> suggests that libxl__device_from_disk ought to be figuring out the
> actual backend somehow rather than being told it.

... yes.  To remove a device you need to tear down the actual backend,
not whatever the default might be.  libxl_domain_destroy must be able
to do this, surely ?  (I haven't checked the code...)

Ian.

  reply	other threads:[~2015-02-02 13:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-26 23:14 [PATCH RFC] libxl: set disk defaults in remove/destroy functions Jim Fehlig
2015-02-02 13:27 ` Ian Campbell
2015-02-02 13:36   ` Ian Campbell
2015-02-02 13:41     ` Ian Jackson [this message]
2015-02-02 16:32   ` Wei Liu
2015-02-02 16:38     ` Ian Jackson
2015-02-02 18:00       ` Wei Liu
2015-02-02 18:06         ` Ian Jackson
2015-02-02 18:13           ` Wei Liu
2015-02-03 11:27             ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21711.32422.174681.429543@mariner.uk.xensource.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=jfehlig@suse.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.