From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH RFC] libxl: set disk defaults in
 remove/destroy functions
Date: Mon, 2 Feb 2015 13:41:58 +0000
Message-ID: <21711.32422.174681.429543@mariner.uk.xensource.com>
References: <54C6CA4A.4040505@suse.com> <1422883633.19293.19.camel@citrix.com>
	<1422884160.19293.23.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1422884160.19293.23.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Jim Fehlig <jfehlig@suse.com>, Wei Liu <wei.liu2@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

Ian Campbell writes ("Re: [Xen-devel] [PATCH RFC] libxl: set disk defaults in remove/destroy functions"):
> Perhaps better would be to add a new parameter to0 DEFINE_DEVICE_REMOVE
> like extra_setdefault_args which is pasted in the appropriate place?

I don't think this is right because...

> I suppose on remove its not so much a case of choosing a suitable
> backend as reflecting the actual current reality for that device. Which
> suggests that libxl__device_from_disk ought to be figuring out the
> actual backend somehow rather than being told it.

... yes.  To remove a device you need to tear down the actual backend,
not whatever the default might be.  libxl_domain_destroy must be able
to do this, surely ?  (I haven't checked the code...)

Ian.