From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH RFC] libxl: set disk defaults in
 remove/destroy functions
Date: Mon, 2 Feb 2015 16:38:00 +0000
Message-ID: <21711.42984.152730.493299@mariner.uk.xensource.com>
References: <54C6CA4A.4040505@suse.com> <1422883633.19293.19.camel@citrix.com>
	<20150202163225.GB25824@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150202163225.GB25824@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: Jim Fehlig <jfehlig@suse.com>, Ian Campbell <Ian.Campbell@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

Wei Liu writes ("Re: [Xen-devel] [PATCH RFC] libxl: set disk defaults in remove/destroy functions"):
> FWIW xl block-detach calls libxl_vdev_to_device_disk to convert a vdev
> to disk. That function reads xenstore to get the actual backend of that
> specific vdev. Don't know how useful it is to libvirt though.
> 
> Maybe we should look up disk's backend in libxl_device_disk_remove? Not
> sure what's the best approach.

libxl_device_disk_remove should definitely not require the caller to
do what xl currently does.

Ian.