All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Robert Ho <robert.hu@intel.com>
Cc: longtaox.pang@intel.com, jfehlig@suse.com, wei.liu2@citrix.com,
	ian.campbell@citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH OSSTEST 03/12] Designate vif device model to e1000
Date: Wed, 11 Feb 2015 14:49:41 +0000	[thread overview]
Message-ID: <21723.27653.225855.599800@mariner.uk.xensource.com> (raw)
In-Reply-To: <1423648341-203755-4-git-send-email-robert.hu@intel.com>

Robert Ho writes ("[PATCH OSSTEST 03/12] Designate vif device model to e1000"):
> Designate vif model to 'e1000', otherwise, with default
>  device model, the L1 eth0 interface disappear, hence xenbridge cannot work.
>  Maybe this limitation can be removed later after some fix it. For now, we
>  have to accomodate to it.

I don't understand this, I'm afraid.  Can you please explain the bug
in more detail in the commit message ?

It is definitely not acceptable to change the default network card for
all guests in prepareguest_part_xencfg.  It would be OK to provide a
guest-specific runvar to specify the guest network card, and it might
be OK to set that in the nested-specific test job creation.

Thanks,
Ian.

  reply	other threads:[~2015-02-11 14:49 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-11  9:52 [PATCH OSSTEST 00/12] Add nested xen on xen test case Robert Ho
2015-02-11  9:52 ` [PATCH OSSTEST 01/12] Add support of parsing grub which has 'submenu' primitive Robert Ho
2015-02-11 14:44   ` Ian Jackson
2015-02-12  2:01     ` Hu, Robert
2015-02-12 10:13       ` Wei Liu
2015-02-12 18:32         ` Ian Jackson
2015-02-13  7:07           ` Hu, Robert
2015-02-13  6:25         ` Hu, Robert
2015-02-12  4:23     ` Ian Campbell
2015-02-11  9:52 ` [PATCH OSSTEST 02/12] Increase boot timer to accomodate to nest test Robert Ho
2015-02-11 14:47   ` Ian Jackson
2015-02-13  8:13     ` Hu, Robert
2015-02-13 11:41       ` Ian Jackson
2015-02-11  9:52 ` [PATCH OSSTEST 03/12] Designate vif device model to e1000 Robert Ho
2015-02-11 14:49   ` Ian Jackson [this message]
2015-02-13  8:32     ` Hu, Robert
2015-02-11  9:52 ` [PATCH OSSTEST 04/12] Just some indentation adustments Robert Ho
2015-02-11 14:50   ` Ian Jackson
2015-02-11  9:52 ` [PATCH OSSTEST 05/12] Add and expose some testsupport APIs Robert Ho
2015-02-11 14:54   ` Ian Jackson
2015-02-13  8:23     ` Hu, Robert
2015-03-04  6:21     ` Pang, LongtaoX
2015-02-11  9:52 ` [PATCH OSSTEST 06/12] Manipulate $ho IP assignment for nest L2 situation Robert Ho
2015-02-11 14:58   ` Ian Jackson
2015-02-13  8:37     ` Hu, Robert
2015-02-11  9:52 ` [PATCH OSSTEST 07/12] For hvm guest configuration, config console to 'hvc0' Robert Ho
2015-02-11 17:03   ` Ian Jackson
2015-02-13  7:31     ` Hu, Robert
2015-02-11  9:52 ` [PATCH OSSTEST 08/12] Add test job for nest test case Robert Ho
2015-02-11 17:02   ` Ian Jackson
2015-02-11  9:52 ` [PATCH OSSTEST 09/12] Add build hvm job for nested test use Robert Ho
2015-02-11 17:04   ` Ian Jackson
2015-02-11  9:52 ` [PATCH OSSTEST 10/12] Compose the main body of test-nested test job Robert Ho
2015-02-11 17:07   ` Ian Jackson
2015-02-13  7:14     ` Hu, Robert
2015-02-11  9:52 ` [PATCH OSSTEST 11/12] Changes on test step of debain hvm guest install Robert Ho
2015-02-12 18:16   ` Ian Jackson
2015-02-13  6:47     ` Hu, Robert
2015-02-13 12:02       ` Ian Jackson
2015-02-15  9:43         ` Hu, Robert
2015-02-16 10:16           ` Wei Liu
2015-02-17  0:45             ` Hu, Robert
2015-02-17 10:37               ` Wei Liu
2015-02-17 10:46                 ` Wei Liu
2015-03-04  9:02                   ` Pang, LongtaoX
2015-02-17 11:24             ` Ian Jackson
2015-02-11  9:52 ` [PATCH OSSTEST 12/12] Changes to test step of xen install Robert Ho
2015-02-11 17:17   ` Ian Jackson
2015-02-12 18:20   ` Ian Jackson
2015-02-13  7:03     ` Hu, Robert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21723.27653.225855.599800@mariner.uk.xensource.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=jfehlig@suse.com \
    --cc=longtaox.pang@intel.com \
    --cc=robert.hu@intel.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.