From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: Re: [PATCH OSSTEST 06/12] Manipulate $ho IP assignment for nest L2 situation Date: Wed, 11 Feb 2015 14:58:34 +0000 Message-ID: <21723.28186.974013.918037@mariner.uk.xensource.com> References: <1423648341-203755-1-git-send-email-robert.hu@intel.com> <1423648341-203755-7-git-send-email-robert.hu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1423648341-203755-7-git-send-email-robert.hu@intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Robert Ho Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, jfehlig@suse.com, longtaox.pang@intel.com List-Id: xen-devel@lists.xenproject.org Robert Ho writes ("[PATCH OSSTEST 06/12] Manipulate $ho IP assignment for nest L2 situation"): > In L2 installation context, its host (L1) IP address is not queried > from DNS, but from previous step of L1 installation, in which, L1 IP > is stored in run var. > - $ho->{IpStatic} = get_host_property($ho,'ip-addr'); > + if ($name eq 'nested') { This is definitely the wrong test. It would be easier to read this series if you introduced the framework first, and then applied all the specific differences afterwards. Instead of keying off $name I think you probably need to make a variant of selecthost that takes an existing guest ($gho) and converts it into a useable host ($ho). It would probably be necessary to split out the bulk of the existing selecthost into a core function. I think you also want a general way to specify how the L1's host properties are set. Ian.