From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH OSSTEST 07/12] For hvm guest configuration,
	config console to 'hvc0'
Date: Wed, 11 Feb 2015 17:03:36 +0000
Message-ID: <21723.35688.961755.745709@mariner.uk.xensource.com>
References: <1423648341-203755-1-git-send-email-robert.hu@intel.com>
	<1423648341-203755-8-git-send-email-robert.hu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1423648341-203755-8-git-send-email-robert.hu@intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Robert Ho <robert.hu@intel.com>
Cc: longtaox.pang@intel.com, jfehlig@suse.com, wei.liu2@citrix.com, ian.campbell@citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

Robert Ho writes ("[PATCH OSSTEST 07/12] For hvm guest configuration, config console to 'hvc0'"):
> ---
>  Osstest/TestSupport.pm | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
> index c23bbc7..864805e 100644
> --- a/Osstest/TestSupport.pm
> +++ b/Osstest/TestSupport.pm
> @@ -1753,7 +1753,11 @@ sub target_kernkind_check ($) {
>      if ($kernkind eq 'pvops') {
>          store_runvar($pfx."rootdev", 'xvda') if $isguest;
>          store_runvar($pfx."console", 'hvc0');
> -    } elsif ($kernkind !~ m/2618/) {
> +    }
> +    elsif ($kernkind eq 'hvm'){
> +        store_runvar($pfx."console", 'hvc0');       #nested hvm guest shall not append console=xvc0; I guess this applies to all hvm guests.
> +    }
> +    elsif ($kernkind !~ m/2618/) {

I don't understand why this is necessary.  Surely all the kernels here
are pvops so the kernkind should be 'pvops' in all cases and the
console will be set to hvc0 anyway ?

Ian.