From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH v5 19/24] libxl: define LIBXL_HAVE_VNUMA
Date: Fri, 13 Feb 2015 15:26:49 +0000
Message-ID: <21726.6073.865574.897031@mariner.uk.xensource.com>
References: <1423770294-9779-1-git-send-email-wei.liu2@citrix.com>
	<1423770294-9779-20-git-send-email-wei.liu2@citrix.com>
	<21726.1642.499389.940904@mariner.uk.xensource.com>
	<20150213152149.GH13644@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150213152149.GH13644@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.campbell@citrix.com, andrew.cooper3@citrix.com, dario.faggioli@citrix.com, xen-devel@lists.xen.org, JBeulich@suse.com, ufimtseva@gmail.com
List-Id: xen-devel@lists.xenproject.org

Wei Liu writes ("Re: [PATCH v5 19/24] libxl: define LIBXL_HAVE_VNUMA"):
> There is no new API yet. Just new structure to specify vNUMA
> configuration.
> 
> How about this:
> 
> /* LIBXL_HAVE_VNUMA
>  *
>  * If this is defined, libxl's IDL has libxl_vnode_info and there is a
>  * array call vnuma_nodes inside libxl_domain_build_info to specify
>  * vNUMA configuration.
>  */

Yes, something like that.  It would be better if the precise wording
were more similar to that for the other HAVE macros.  How about:

   * If this is defined the type libxl_vnode_info exists, and a
   * field 'vnuma_nodes' is present in libxl_domain_build_info.

or similar ?

Ian.