All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Konstantin Ananyev <konstantin.ananyev@intel.com>
Cc: dev@dpdk.org, olivier.matz@6wind.com
Subject: Re: [dpdk-dev] [PATCH] examples/ip_fragmentation: fix fail to send un-fragmented packets
Date: Tue, 16 Jul 2019 13:26:46 +0200	[thread overview]
Message-ID: <2172925.cb74tNeGR5@xps> (raw)
In-Reply-To: <20190710141659.23964-1-konstantin.ananyev@intel.com>

10/07/2019 16:16, Konstantin Ananyev:
> With latest changes l3fwd_simple_forward() blindly set
> (PKT_TX_IPV4 | PKT_TX_IP_CKSUM) ol_flags for all IPv4 packets.
> Though for un-fragmented packets we also do have to set l3_len
> to make HW IP cksum offload to work properly.
> That causes HWi/PMD to drop or generate invalid packets.
> Though for un-fragmented packets we don't need to regenerate
> IPv4 cksum, as L3 header is not modified.
> Fix by setting ol_flags only when required.
> Another small fix - don't set IPv4/IPV6 ether type for unknown
> packet types.
> 
> Fixes: 16863bbb4a41 ("examples/ip_fragmentation: enable IP checksum offload")

Shouldn't it be 2 separate fixes?




  reply	other threads:[~2019-07-16 11:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-10 14:16 [dpdk-dev] [PATCH] examples/ip_fragmentation: fix fail to send un-fragmented packets Konstantin Ananyev
2019-07-16 11:26 ` Thomas Monjalon [this message]
2019-07-18 10:11 ` [dpdk-dev] [PATCH v2 0/2] Few fixes for ip_fragmentation Konstantin Ananyev
2019-07-18 10:11   ` [dpdk-dev] [PATCH v2 1/2] examples/ip_fragmentation: fix fail to send un-fragmented packets Konstantin Ananyev
2019-07-18 10:11   ` [dpdk-dev] [PATCH v2 2/2] examples/ip_fragmentation: fix set IPv4 for unknown packet types Konstantin Ananyev
2019-07-18 21:10   ` [dpdk-dev] [PATCH v2 0/2] Few fixes for ip_fragmentation Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2172925.cb74tNeGR5@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=olivier.matz@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.