From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH OSSTEST 11/12] Changes on test step of
 debain hvm guest install
Date: Tue, 17 Feb 2015 11:24:33 +0000
Message-ID: <21731.9457.483914.74179@mariner.uk.xensource.com>
References: <1423648341-203755-1-git-send-email-robert.hu@intel.com>
	<1423648341-203755-12-git-send-email-robert.hu@intel.com>
	<21724.60955.207370.14337@mariner.uk.xensource.com>
	<9E79D1C9A97CFD4097BCE431828FDD31B15D9E@SHSMSX103.ccr.corp.intel.com>
	<21725.59370.336561.485823@mariner.uk.xensource.com>
	<9E79D1C9A97CFD4097BCE431828FDD31B18B38@SHSMSX103.ccr.corp.intel.com>
	<20150216101636.GA12471@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150216101636.GA12471@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: "Pang, LongtaoX" <longtaox.pang@intel.com>, "Hu,
	Robert" <robert.hu@intel.com>, "jfehlig@suse.com" <jfehlig@suse.com>, "ian.campbell@citrix.com" <ian.campbell@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

Wei Liu writes ("Re: [PATCH OSSTEST 11/12] Changes on test step of debain hvm guest install"):
> On Sun, Feb 15, 2015 at 09:43:33AM +0000, Hu, Robert wrote:
> > For example, we don't understand the above why some (the first 2) 
> > passing params to ts-* with '+' and the latter 2 doesn't?
> 
> sg-run-job is written in tcl. I don't claim to be an expert on this
> language. I spent ~1.5 hour to grasp the basic and was able to decrypt
> this script. The manual and tutorial on tcl official website are quite
> helpful.
> 
> All those parameters are passed to the ts-* script. The "+" sign is a
> toggle to control if it should appear in the final report. Have a look
> at spawn-ts, or more preciously, around L123 (it may vary depending on
> your OSSTest tree changeset).

More precisely the `+' toggles whether the parameter becomes part of
the `testid', which is the unique identifier (within a job) for a
particular test step.

> If you look at the actual output of you script, you will see all
> parameters are passed to the script.

All except the `+', of course.

I'm sorry that the arguments to run-ts, spawn-ts, et al, are not
properly documented.  Thanks to Wei for explaining.

Ian.