From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: Re: [PATCH v3 21/24] tools/(lib)xl: Add partial device tree support for ARM Date: Mon, 23 Feb 2015 19:12:41 +0000 Message-ID: <21739.31657.290415.931682@mariner.uk.xensource.com> References: <1421159133-31526-1-git-send-email-julien.grall@linaro.org> <1421159133-31526-22-git-send-email-julien.grall@linaro.org> <21739.5877.96434.483449@mariner.uk.xensource.com> <54EB74E3.2020806@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YPyY4-00031m-19 for xen-devel@lists.xenproject.org; Mon, 23 Feb 2015 19:20:08 +0000 In-Reply-To: <54EB74E3.2020806@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: xen-devel@lists.xenproject.org, tim@xen.org, ian.campbell@citrix.com, stefano.stabellini@citrix.com, Wei Liu List-Id: xen-devel@lists.xenproject.org Julien Grall writes ("Re: [PATCH v3 21/24] tools/(lib)xl: Add partial device tree support for ARM"): > On 23/02/15 12:03, Ian Jackson wrote: > > Please wrap your commit messages to 70, not 80. > > I though commit message has to be wrapped to 80. I will change it. Thanks. `git log' adds 4 spaces, and email quoting adds varying numbers of `> ', so the original has to be significantly less than 80 to stop quoted emails and git log from being too wide (by which I mean more than 79). > > This is rather odd. The config option is `device_tree' but apparently > > it is only relevant for passthrough and nothing else can be set with > > it. > > I had to chose a name for the node and "/passthrough" was the best one > and it won't collapse with the device tree generated by the toolstack. > > Although, you can put pretty much everything in the "/passthrough" node. Perhaps the config option should be renamed so that it's less general. Maybe in future people will want a more general dtb-editing facility and then this would be in the way. > It's not my plan to have an XSA-55 like :). :-). > As discussed IRL, we can mark this option "unsafe". So any device tree > pass to libxl should be trusted. Yes. > I will add an item in the description. Thanks, Ian.