From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v11 1/4] flow_classify: add flow classify
	library
Date: Wed, 25 Oct 2017 14:13:24 +0200
Message-ID: <2175097.6NP1zJMmBs@xps>
References: <1508771778-617-1-git-send-email-bernard.iremonger@intel.com>
 <2366771.cLq7VtfpKK@xps>
 <8CEF83825BEC744B83065625E567D7C24E057846@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "Yigit, Ferruh" <ferruh.yigit@intel.com>, "Ananyev,
 Konstantin" <konstantin.ananyev@intel.com>, "Dumitrescu,
 Cristian" <cristian.dumitrescu@intel.com>,
 "adrien.mazarguil@6wind.com" <adrien.mazarguil@6wind.com>, "Singh,
 Jasvinder" <jasvinder.singh@intel.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 82DBB1B22E
 for <dev@dpdk.org>; Wed, 25 Oct 2017 14:13:26 +0200 (CEST)
In-Reply-To: <8CEF83825BEC744B83065625E567D7C24E057846@IRSMSX108.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

25/10/2017 13:10, Iremonger, Bernard:
> Hi Thomas,
> 
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > 24/10/2017 19:28, Bernard Iremonger:
> > >  #
> > > +# Compile librte_classify
> > > +#
> > > +CONFIG_RTE_LIBRTE_FLOW_CLASSIFY=y
> > > +CONFIG_RTE_LIBRTE_CLASSIFY_DEBUG=n
> > 
> > The debug option is still there but seems not used.
> > I guess I can remove it?
> 
> The debug option is used  in rte_flow_classify.c at line 158.
> It needs  to be restored.
> Will I send a patch or can you restore it?

No, the intent is to stop adding some debug options in the config.

It is used in this lib to dump some data.
I think it should be triggered dynamically with the log level.