From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH 03/29] libxl: suspend: switch_logdirty_done
 takes rc
Date: Tue, 31 Mar 2015 19:02:12 +0100
Message-ID: <21786.57636.813750.216480@mariner.uk.xensource.com>
References: <1423599016-32639-1-git-send-email-ian.jackson@eu.citrix.com>
	<1423599016-32639-4-git-send-email-ian.jackson@eu.citrix.com>
	<1427194381.21742.336.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1427194381.21742.336.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: xen-devel@lists.xensource.com, Euan Harris <euan.harris@citrix.com>
List-Id: xen-devel@lists.xenproject.org

Ian Campbell writes ("Re: [Xen-devel] [PATCH 03/29] libxl: suspend: switch_logdirty_done takes rc"):
> On Tue, 2015-02-10 at 20:09 +0000, Ian Jackson wrote:
> > +    int broke;
> > +    if (rc) {
> > +        broke = -1;
> > +    } else {
> > +        broke = 0;
> > +    }
> 
> int broke = rc ? -1 : 0;
> 
> ?
> 
> But it looks like perhaps you are preparing to add other code in one or
> the other case, or maybe you just prefer this for some reason. Either
> way:

Later we change one of the branches to set dss->rc too.

> Acked-by: Ian Campbell <ian.campbell@citrix.com>

Thanks,
Ian.