From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Joseph, Anoob" <Anoob.Joseph@caviumnetworks.com>
Subject: Re: [PATCH v2 09/33] crypto/octeontx: adds symmetric
 capabilities
Date: Mon, 17 Sep 2018 18:05:00 +0530
Message-ID: <21787cc6-1151-53e9-a86b-aa008b421fb1@caviumnetworks.com>
References: <1528476325-15585-1-git-send-email-anoob.joseph@caviumnetworks.com>
 <1536033560-21541-1-git-send-email-ajoseph@caviumnetworks.com>
 <1536033560-21541-10-git-send-email-ajoseph@caviumnetworks.com>
 <0b2cecb1-f055-61d6-3c10-802d0d647b96@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Cc: Murthy NSSR <nidadavolu.murthy@caviumnetworks.com>,
 Jerin Jacob <jerin.jacob@caviumnetworks.com>,
 Narayana Prasad <narayanaprasad.athreya@caviumnetworks.com>, dev@dpdk.org,
 Ankur Dwivedi <ankur.dwivedi@caviumnetworks.com>,
 Nithin Dabilpuram <nithin.dabilpuram@caviumnetworks.com>,
 Ragothaman Jayaraman <rjayaraman@caviumnetworks.com>,
 Srisivasubramanian S <ssrinivasan@caviumnetworks.com>,
 Tejasree Kondoj <kondoj.tejasree@caviumnetworks.com>
To: Akhil Goyal <akhil.goyal@nxp.com>,
 Anoob Joseph <ajoseph@caviumnetworks.com>,
 Pablo de Lara <pablo.de.lara.guarch@intel.com>,
 Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam01on0069.outbound.protection.outlook.com [104.47.32.69])
 by dpdk.org (Postfix) with ESMTP id DD2FE7CE2
 for <dev@dpdk.org>; Mon, 17 Sep 2018 14:36:45 +0200 (CEST)
In-Reply-To: <0b2cecb1-f055-61d6-3c10-802d0d647b96@nxp.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Akhil,

On 17-09-2018 17:31, Akhil Goyal wrote:
> External Email
>
>> diff --git a/drivers/crypto/octeontx/otx_cryptodev_ops.c 
>> b/drivers/crypto/octeontx/otx_cryptodev_ops.c
>> index d25f9c1..cc0030e 100644
>> --- a/drivers/crypto/octeontx/otx_cryptodev_ops.c
>> +++ b/drivers/crypto/octeontx/otx_cryptodev_ops.c
>> @@ -10,9 +10,15 @@
>>   #include "cpt_pmd_logs.h"
>>
>>   #include "otx_cryptodev.h"
>> +#include "otx_cryptodev_capabilities.h"
>>   #include "otx_cryptodev_hw_access.h"
>>   #include "otx_cryptodev_ops.h"
>>
>> +static const struct rte_cryptodev_capabilities otx_capabilities[] = {
>> +     OTX_SYM_CAPABILITIES,
>> +     RTE_CRYPTODEV_END_OF_CAPABILITIES_LIST()
>> +};
>> +
>
> better to have otx_capabilities structure defined in the 
> otx_cryptodev_capabilities.h
>
> I don't see any value addition of creating a macro in one file using 
> in a separate structure in another file
>
> which doesn't have anything new in that structure. It would also give 
> checkpatch error.
>
> You can directly have a capability structure without the #define.
This was the convention followed in qat driver.

https://git.dpdk.org/dpdk/tree/drivers/crypto/qat/qat_sym_capabilities.h

I guess it was to avoid variable definition in header. May be Pablo too 
can comment on this. I'll make the change accordingly.

Thanks,
Anoob