From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: Re: [PATCH v5 p2 15/19] tools/(lib)xl: Add partial device tree support for ARM Date: Thu, 9 Apr 2015 17:13:05 +0100 Message-ID: <21798.42257.11914.504504@mariner.uk.xensource.com> References: <1428592185-18581-1-git-send-email-julien.grall@citrix.com> <1428592185-18581-16-git-send-email-julien.grall@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YgFM9-0004Qz-0n for xen-devel@lists.xenproject.org; Thu, 09 Apr 2015 16:31:05 +0000 In-Reply-To: <1428592185-18581-16-git-send-email-julien.grall@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: Wei Liu , ian.campbell@citrix.com, Julien Grall , tim@xen.org, stefano.stabellini@citrix.com, xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org Julien Grall writes ("[PATCH v5 p2 15/19] tools/(lib)xl: Add partial device tree support for ARM"): > Let the user to pass additional nodes to the guest device tree. For > this purpose, everything in the node /passthrough from the partial > device tree will be copied into the guest device tree. Thanks for explaining to me in person what I was missing about the semantics of DTs. As I said, you may wish to explain some of this in the commit message or some of the in-tree documents, perhaps with references. I will leave that up to you. In any case, Acked-by: Ian Jackson Although: > + # Given the complexity of verifying the validity of a device tree, > + # libxl doesn't do any security check on it. It's the responsability Spelling mistake - should be "responsibility". Thanks, Ian.