From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: Re: [PATCH v5 p2 16/19] tools/libxl: arm: Use an higher value for the GIC phandle Date: Thu, 9 Apr 2015 17:17:03 +0100 Message-ID: <21798.42495.633318.607315@mariner.uk.xensource.com> References: <1428592185-18581-1-git-send-email-julien.grall@citrix.com> <1428592185-18581-17-git-send-email-julien.grall@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YgFAv-00040M-D9 for xen-devel@lists.xenproject.org; Thu, 09 Apr 2015 16:19:29 +0000 In-Reply-To: <1428592185-18581-17-git-send-email-julien.grall@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: Wei Liu , ian.campbell@citrix.com, Julien Grall , tim@xen.org, stefano.stabellini@citrix.com, xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org Julien Grall writes ("[PATCH v5 p2 16/19] tools/libxl: arm: Use an higher value for the GIC phandle"): > The partial device tree may contains phandle. The Device Tree Compiler > tends to allocate the phandle from 1. I have to say I have no idea what a phandle is... > Reserve the ID 65000 for the GIC phandle. I think we can safely assume > that the partial device tree will never contain a such ID. Do we control the DT compiler ? What if it should change its phandle allocation algorithm ? > +/* > + * The device tree compiler (DTC) is allocating the phandle from 1 to > + * onwards. Reserve a high value for the GIC phandle. > + */ FYI this should read "The device tree compiler (DTC) allocates phandle values frrom 1 onwards". Thanks, Ian.