From: David Howells <dhowells@redhat.com>
To: Hillf Danton <hdanton@sina.com>
Cc: dhowells@redhat.com,
syzbot <syzbot+3f1fd6b8cbf8702d134e@syzkaller.appspotmail.com>,
davem@davemloft.net, kuba@kernel.org,
linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: inconsistent lock state in rxrpc_put_client_conn
Date: Thu, 06 Feb 2020 13:09:36 +0000 [thread overview]
Message-ID: <2183052.1580994576@warthog.procyon.org.uk> (raw)
In-Reply-To: <20200204084005.11320-1-hdanton@sina.com>
Hillf Danton <hdanton@sina.com> wrote:
> Take lock with irq quiesced.
I think that's overkill. It only needs _bh annotations, not _irqsave/restore
- but even that is probably not the best way.
The best way is to offload the stuff done by rxrpc_rcu_destroy_call() to a
workqueue if called in softirq mode. I'm not sure whether rcu callbacks are
done in softirq mode - if they are, then it can just call rxrpc_queue_work().
David
next parent reply other threads:[~2020-02-06 13:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200207031553.18696-1-hdanton@sina.com>
[not found] ` <20200204084005.11320-1-hdanton@sina.com>
2020-02-06 13:09 ` David Howells [this message]
2020-02-07 7:23 ` inconsistent lock state in rxrpc_put_client_conn David Howells
2020-02-04 0:38 syzbot
2020-02-04 5:41 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2183052.1580994576@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=davem@davemloft.net \
--cc=hdanton@sina.com \
--cc=kuba@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzbot+3f1fd6b8cbf8702d134e@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.