From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH v2 1/6] drm/i915: Always wait for flip_done, v2. Date: Fri, 8 Sep 2017 11:08:22 +0200 Message-ID: <21839dae-0731-5460-0597-32f8cc9dad80@linux.intel.com> References: <20170904104838.23822-1-maarten.lankhorst@linux.intel.com> <20170904104838.23822-2-maarten.lankhorst@linux.intel.com> <20170907094936.uoc7ufq7yaj4dw3d@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170907094936.uoc7ufq7yaj4dw3d@phenom.ffwll.local> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T3AgMDctMDktMTcgb20gMTE6NDkgc2NocmVlZiBEYW5pZWwgVmV0dGVyOgo+IE9uIE1vbiwgU2Vw IDA0LCAyMDE3IGF0IDEyOjQ4OjMzUE0gKzAyMDAsIE1hYXJ0ZW4gTGFua2hvcnN0IHdyb3RlOgo+ PiBUaGUgbmV4dCBjb21taXQgcmVtb3ZlcyB0aGUgd2FpdCBmb3IgZmxpcF9kb25lIGluIGluCj4+ IGRybV9hdG9taWNfaGVscGVyX2NvbW1pdF9jbGVhbnVwX2RvbmUsIGJ1dCB3ZSBuZWVkIGl0IGZv ciB0aGUgdGVzdHMKPj4gdG8gcGFzcy4gSW5zdGVhZCBvZiB1c2luZyBjb21wbGljYXRlZCB2Ymxh bmsgdHJhY2tpbmcgd2hpY2ggZW5kcwo+PiB1cCBiZWluZyBpZ25vcmVkIGFueXdheSwgY2FsbCB0 aGUgY29ycmVjdCBhdG9taWMgaGVscGVyLiA6KQo+Pgo+PiBDaGFuZ2VzIHNpbmNlIHYxOgo+PiAt IEFsd2F5cyBjYWxsIGRybV9hdG9taWNfaGVscGVyX3dhaXRfZm9yX2ZsaXBfZG9uZSwKPj4gICBl dmVuIGZvciBsZWdhY3kgY3Vyc29yIHVwZGF0ZXMuIChkYW52ZXQpCj4+Cj4+IFNpZ25lZC1vZmYt Ynk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+ Cj4+IC0tLQo+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCAgICAgIHwgIDMgKy0K Pj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDg0ICsrKy0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+PiAgMiBmaWxlcyBjaGFuZ2VkLCA4IGluc2VydGlv bnMoKyksIDc5IGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPj4gaW5k ZXggMzhiZDA4ZjI1MzliLi43OTUzM2JhNmYzODcgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZHJ2LmgKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9k cnYuaAo+PiBAQCAtNzI1LDggKzcyNSw3IEBAIHN0cnVjdCBkcm1faTkxNV9kaXNwbGF5X2Z1bmNz IHsKPj4gIAkJCSAgICBzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqb2xkX3N0YXRlKTsKPj4gIAl2 b2lkICgqY3J0Y19kaXNhYmxlKShzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqb2xkX2NydGNfc3Rh dGUsCj4+ICAJCQkgICAgIHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpvbGRfc3RhdGUpOwo+PiAt CXZvaWQgKCp1cGRhdGVfY3J0Y3MpKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSwKPj4g LQkJCSAgICAgdW5zaWduZWQgaW50ICpjcnRjX3ZibGFua19tYXNrKTsKPj4gKwl2b2lkICgqdXBk YXRlX2NydGNzKShzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUpOwo+PiAgCXZvaWQgKCph dWRpb19jb2RlY19lbmFibGUpKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4+ICAJ CQkJICAgc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4+ICAJCQkJICAgY29uc3Qgc3Ry dWN0IGRybV9kaXNwbGF5X21vZGUgKmFkanVzdGVkX21vZGUpOwo+PiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZGlzcGxheS5jCj4+IGluZGV4IDIxNmNkOWUwZTA4Zi4uYTZjZjFjMjBjNzEyIDEwMDY0 NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4+IEBAIC0xMjEzNiw3MyArMTIx MzYsMTAgQEAgdTMyIGludGVsX2NydGNfZ2V0X3ZibGFua19jb3VudGVyKHN0cnVjdCBpbnRlbF9j cnRjICpjcnRjKQo+PiAgCXJldHVybiBkZXYtPmRyaXZlci0+Z2V0X3ZibGFua19jb3VudGVyKGRl diwgY3J0Yy0+cGlwZSk7Cj4+ICB9Cj4+ICAKPj4gLXN0YXRpYyB2b2lkIGludGVsX2F0b21pY193 YWl0X2Zvcl92YmxhbmtzKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4+IC0JCQkJCSAgc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+PiAtCQkJCQkgIHVuc2lnbmVkIGNydGNfbWFz aykKPj4gLXsKPj4gLQl1bnNpZ25lZCBsYXN0X3ZibGFua19jb3VudFtJOTE1X01BWF9QSVBFU107 Cj4+IC0JZW51bSBwaXBlIHBpcGU7Cj4+IC0JaW50IHJldDsKPj4gLQo+PiAtCWlmICghY3J0Y19t YXNrKQo+PiAtCQlyZXR1cm47Cj4+IC0KPj4gLQlmb3JfZWFjaF9waXBlKGRldl9wcml2LCBwaXBl KSB7Cj4+IC0JCXN0cnVjdCBpbnRlbF9jcnRjICpjcnRjID0gaW50ZWxfZ2V0X2NydGNfZm9yX3Bp cGUoZGV2X3ByaXYsCj4+IC0JCQkJCQkJCSAgcGlwZSk7Cj4+IC0KPj4gLQkJaWYgKCEoKDEgPDwg cGlwZSkgJiBjcnRjX21hc2spKQo+PiAtCQkJY29udGludWU7Cj4+IC0KPj4gLQkJcmV0ID0gZHJt X2NydGNfdmJsYW5rX2dldCgmY3J0Yy0+YmFzZSk7Cj4+IC0JCWlmIChXQVJOX09OKHJldCAhPSAw KSkgewo+PiAtCQkJY3J0Y19tYXNrICY9IH4oMSA8PCBwaXBlKTsKPj4gLQkJCWNvbnRpbnVlOwo+ PiAtCQl9Cj4+IC0KPj4gLQkJbGFzdF92YmxhbmtfY291bnRbcGlwZV0gPSBkcm1fY3J0Y192Ymxh bmtfY291bnQoJmNydGMtPmJhc2UpOwo+PiAtCX0KPj4gLQo+PiAtCWZvcl9lYWNoX3BpcGUoZGV2 X3ByaXYsIHBpcGUpIHsKPj4gLQkJc3RydWN0IGludGVsX2NydGMgKmNydGMgPSBpbnRlbF9nZXRf Y3J0Y19mb3JfcGlwZShkZXZfcHJpdiwKPj4gLQkJCQkJCQkJICBwaXBlKTsKPj4gLQkJbG9uZyBs cmV0Owo+PiAtCj4+IC0JCWlmICghKCgxIDw8IHBpcGUpICYgY3J0Y19tYXNrKSkKPj4gLQkJCWNv bnRpbnVlOwo+PiAtCj4+IC0JCWxyZXQgPSB3YWl0X2V2ZW50X3RpbWVvdXQoZGV2LT52Ymxhbmtb cGlwZV0ucXVldWUsCj4+IC0JCQkJbGFzdF92YmxhbmtfY291bnRbcGlwZV0gIT0KPj4gLQkJCQkJ ZHJtX2NydGNfdmJsYW5rX2NvdW50KCZjcnRjLT5iYXNlKSwKPj4gLQkJCQltc2Vjc190b19qaWZm aWVzKDUwKSk7Cj4+IC0KPj4gLQkJV0FSTighbHJldCwgInBpcGUgJWMgdmJsYW5rIHdhaXQgdGlt ZWQgb3V0XG4iLCBwaXBlX25hbWUocGlwZSkpOwo+PiAtCj4+IC0JCWRybV9jcnRjX3ZibGFua19w dXQoJmNydGMtPmJhc2UpOwo+PiAtCX0KPj4gLX0KPj4gLQo+PiAtc3RhdGljIGJvb2wgbmVlZHNf dmJsYW5rX3dhaXQoc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpCj4+IC17Cj4+ IC0JLyogZmIgdXBkYXRlZCwgbmVlZCB0byB1bnBpbiBvbGQgZmIgKi8KPj4gLQlpZiAoY3J0Y19z dGF0ZS0+ZmJfY2hhbmdlZCkKPj4gLQkJcmV0dXJuIHRydWU7Cj4+IC0KPj4gLQkvKiB3bSBjaGFu Z2VzLCBuZWVkIHZibGFuayBiZWZvcmUgZmluYWwgd20ncyAqLwo+PiAtCWlmIChjcnRjX3N0YXRl LT51cGRhdGVfd21fcG9zdCkKPj4gLQkJcmV0dXJuIHRydWU7Cj4+IC0KPj4gLQlpZiAoY3J0Y19z dGF0ZS0+d20ubmVlZF9wb3N0dmJsX3VwZGF0ZSkKPj4gLQkJcmV0dXJuIHRydWU7Cj4+IC0KPj4g LQlyZXR1cm4gZmFsc2U7Cj4+IC19Cj4+IC0KPj4gIHN0YXRpYyB2b2lkIGludGVsX3VwZGF0ZV9j cnRjKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPj4gIAkJCSAgICAgIHN0cnVjdCBkcm1fYXRvbWlj X3N0YXRlICpzdGF0ZSwKPj4gIAkJCSAgICAgIHN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqb2xkX2Ny dGNfc3RhdGUsCj4+IC0JCQkgICAgICBzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKm5ld19jcnRjX3N0 YXRlLAo+PiAtCQkJICAgICAgdW5zaWduZWQgaW50ICpjcnRjX3ZibGFua19tYXNrKQo+PiArCQkJ ICAgICAgc3RydWN0IGRybV9jcnRjX3N0YXRlICpuZXdfY3J0Y19zdGF0ZSkKPj4gIHsKPj4gIAlz dHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gY3J0Yy0+ZGV2Owo+PiAgCXN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPj4gQEAgLTEyMjI1LDEzICsxMjE2Miw5 IEBAIHN0YXRpYyB2b2lkIGludGVsX3VwZGF0ZV9jcnRjKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywK Pj4gIAl9Cj4+ICAKPj4gIAlkcm1fYXRvbWljX2hlbHBlcl9jb21taXRfcGxhbmVzX29uX2NydGMo b2xkX2NydGNfc3RhdGUpOwo+PiAtCj4+IC0JaWYgKG5lZWRzX3ZibGFua193YWl0KHBpcGVfY29u ZmlnKSkKPj4gLQkJKmNydGNfdmJsYW5rX21hc2sgfD0gZHJtX2NydGNfbWFzayhjcnRjKTsKPj4g IH0KPj4gIAo+PiAtc3RhdGljIHZvaWQgaW50ZWxfdXBkYXRlX2NydGNzKHN0cnVjdCBkcm1fYXRv bWljX3N0YXRlICpzdGF0ZSwKPj4gLQkJCSAgICAgICB1bnNpZ25lZCBpbnQgKmNydGNfdmJsYW5r X21hc2spCj4+ICtzdGF0aWMgdm9pZCBpbnRlbF91cGRhdGVfY3J0Y3Moc3RydWN0IGRybV9hdG9t aWNfc3RhdGUgKnN0YXRlKQo+PiAgewo+PiAgCXN0cnVjdCBkcm1fY3J0YyAqY3J0YzsKPj4gIAlz dHJ1Y3QgZHJtX2NydGNfc3RhdGUgKm9sZF9jcnRjX3N0YXRlLCAqbmV3X2NydGNfc3RhdGU7Cj4+ IEBAIC0xMjI0MiwxMiArMTIxNzUsMTEgQEAgc3RhdGljIHZvaWQgaW50ZWxfdXBkYXRlX2NydGNz KHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSwKPj4gIAkJCWNvbnRpbnVlOwo+PiAgCj4+ ICAJCWludGVsX3VwZGF0ZV9jcnRjKGNydGMsIHN0YXRlLCBvbGRfY3J0Y19zdGF0ZSwKPj4gLQkJ CQkgIG5ld19jcnRjX3N0YXRlLCBjcnRjX3ZibGFua19tYXNrKTsKPj4gKwkJCQkgIG5ld19jcnRj X3N0YXRlKTsKPj4gIAl9Cj4+ICB9Cj4+ICAKPj4gLXN0YXRpYyB2b2lkIHNrbF91cGRhdGVfY3J0 Y3Moc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlLAo+PiAtCQkJICAgICB1bnNpZ25lZCBp bnQgKmNydGNfdmJsYW5rX21hc2spCj4+ICtzdGF0aWMgdm9pZCBza2xfdXBkYXRlX2NydGNzKHN0 cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPj4gIHsKPj4gIAlzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KHN0YXRlLT5kZXYpOwo+PiAgCXN0cnVjdCBpbnRl bF9hdG9taWNfc3RhdGUgKmludGVsX3N0YXRlID0gdG9faW50ZWxfYXRvbWljX3N0YXRlKHN0YXRl KTsKPj4gQEAgLTEyMzA2LDcgKzEyMjM4LDcgQEAgc3RhdGljIHZvaWQgc2tsX3VwZGF0ZV9jcnRj cyhzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUsCj4+ICAJCQkJdmJsX3dhaXQgPSB0cnVl Owo+PiAgCj4+ICAJCQlpbnRlbF91cGRhdGVfY3J0YyhjcnRjLCBzdGF0ZSwgb2xkX2NydGNfc3Rh dGUsCj4+IC0JCQkJCSAgbmV3X2NydGNfc3RhdGUsIGNydGNfdmJsYW5rX21hc2spOwo+PiArCQkJ CQkgIG5ld19jcnRjX3N0YXRlKTsKPj4gIAo+PiAgCQkJaWYgKHZibF93YWl0KQo+PiAgCQkJCWlu dGVsX3dhaXRfZm9yX3ZibGFuayhkZXZfcHJpdiwgcGlwZSk7Cj4+IEBAIC0xMjM2OCw3ICsxMjMw MCw2IEBAIHN0YXRpYyB2b2lkIGludGVsX2F0b21pY19jb21taXRfdGFpbChzdHJ1Y3QgZHJtX2F0 b21pY19zdGF0ZSAqc3RhdGUpCj4+ICAJc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmludGVsX2Nz dGF0ZTsKPj4gIAlib29sIGh3X2NoZWNrID0gaW50ZWxfc3RhdGUtPm1vZGVzZXQ7Cj4+ICAJdTY0 IHB1dF9kb21haW5zW0k5MTVfTUFYX1BJUEVTXSA9IHt9Owo+PiAtCXVuc2lnbmVkIGNydGNfdmJs YW5rX21hc2sgPSAwOwo+PiAgCWludCBpOwo+PiAgCj4+ICAJaW50ZWxfYXRvbWljX2NvbW1pdF9m ZW5jZV93YWl0KGludGVsX3N0YXRlKTsKPj4gQEAgLTEyNDU4LDcgKzEyMzg5LDcgQEAgc3RhdGlj IHZvaWQgaW50ZWxfYXRvbWljX2NvbW1pdF90YWlsKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpz dGF0ZSkKPj4gIAl9Cj4+ICAKPj4gIAkvKiBOb3cgZW5hYmxlIHRoZSBjbG9ja3MsIHBsYW5lLCBw aXBlLCBhbmQgY29ubmVjdG9ycyB0aGF0IHdlIHNldCB1cC4gKi8KPj4gLQlkZXZfcHJpdi0+ZGlz cGxheS51cGRhdGVfY3J0Y3Moc3RhdGUsICZjcnRjX3ZibGFua19tYXNrKTsKPj4gKwlkZXZfcHJp di0+ZGlzcGxheS51cGRhdGVfY3J0Y3Moc3RhdGUpOwo+PiAgCj4+ICAJLyogRklYTUU6IFdlIHNo b3VsZCBjYWxsIGRybV9hdG9taWNfaGVscGVyX2NvbW1pdF9od19kb25lKCkgaGVyZQo+PiAgCSAq IGFscmVhZHksIGJ1dCBzdGlsbCBuZWVkIHRoZSBzdGF0ZSBmb3IgdGhlIGRlbGF5ZWQgb3B0aW1p emF0aW9uLiBUbwo+PiBAQCAtMTI0NjksOCArMTI0MDAsNyBAQCBzdGF0aWMgdm9pZCBpbnRlbF9h dG9taWNfY29tbWl0X3RhaWwoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlKQo+PiAgCSAq IC0gc3dpdGNoIG92ZXIgdG8gdGhlIHZibGFuayB3YWl0IGhlbHBlciBpbiB0aGUgY29yZSBhZnRl ciB0aGF0IHNpbmNlCj4+ICAJICogICB3ZSBkb24ndCBuZWVkIG91dCBzcGVjaWFsIGhhbmRsaW5n IGFueSBtb3JlLgo+PiAgCSAqLwo+PiAtCWlmICghc3RhdGUtPmxlZ2FjeV9jdXJzb3JfdXBkYXRl KQo+PiAtCQlpbnRlbF9hdG9taWNfd2FpdF9mb3JfdmJsYW5rcyhkZXYsIGRldl9wcml2LCBjcnRj X3ZibGFua19tYXNrKTsKPj4gKwlkcm1fYXRvbWljX2hlbHBlcl93YWl0X2Zvcl9mbGlwX2RvbmUo ZGV2LCBzdGF0ZSk7Cj4gU3VwZXJmbG91cyBpZiBkcm9wcGVkLCBJJ20gaGFwcHkuClB1c2hlZCB0 aGUgc2VyaWVzLCB0aGFua3MgZm9yIHJldmlldy4gOikKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==