From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH OSSTEST v2 06/19] ts-host-install: Support
	UEFI PXE boot using grub.efi
Date: Thu, 18 Jun 2015 18:51:14 +0100
Message-ID: <21891.1298.274824.408307@mariner.uk.xensource.com>
References: <1434644687.28264.53.camel@citrix.com>
	<1434644710-28881-6-git-send-email-ian.campbell@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1434644710-28881-6-git-send-email-ian.campbell@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

Ian Campbell writes ("[PATCH OSSTEST v2 06/19] ts-host-install: Support UEFI PXE boot using grub.efi"):
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>

> +sub setup_grub_efi_bootcfg ($$) {
> +    my ($ho, $bootfile) = @_;
> +    my $f = "grub.cfg-$ho->{Ether}";
> +    my $grub= $ho->{Tftp}{Path}.'/'.$ho->{Tftp}{GrubBase}.'/'.$c{Tftp\
GrubVersion}.
> +	"/pxegrub-$r{arch}.efi";

You've wrapped this but in the wrong place!

The README has a long line in it too.  DiBase is already too long but
that is no excuse.

Ian.