From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH OSSTEST v3 14/22] Debian: Do not add Debian
	to UEFI boot order on install
Date: Wed, 24 Jun 2015 17:11:44 +0100
Message-ID: <21898.54976.504278.479364@mariner.uk.xensource.com>
References: <1435159944.28264.295.camel@citrix.com>
	<1435159961-22292-14-git-send-email-ian.campbell@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1435159961-22292-14-git-send-email-ian.campbell@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

Ian Campbell writes ("[PATCH OSSTEST v3 14/22] Debian: Do not add Debian to UEFI boot order on install"):
> By default Debian inserts itself before any existing entries,
> including the PXE one, meaning we otherwise cannot remotely regroove
> the box.

Right.

> +    if (get_host_property($ho, "firmware") eq "uefi" &&
> +	$ho->{Suite} =~ m/jessie/) {

I think you mean

  +    if (get_host_property($ho, "firmware") eq "uefi")
  +	die unless $ho->{Suite} =~ m/jessie/;

or this will expose us to broken boxes beyond jessie.


The rest looks plausible (although a bit unpleasant).

Ian.