All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Sharma, Shashank" <shashank.sharma@amd.com>
To: "Somalapuram, Amaranath" <asomalap@amd.com>,
	Somalapuram Amaranath <Amaranath.Somalapuram@amd.com>,
	amd-gfx@lists.freedesktop.org
Cc: alexander.deucher@amd.com, christian.koenig@amd.com
Subject: Re: [PATCH v1 2/2] drm/amdgpu: adding device coredump support
Date: Tue, 24 May 2022 19:27:42 +0200	[thread overview]
Message-ID: <218d95f3-b38d-21ff-64fb-3f3df666babe@amd.com> (raw)
In-Reply-To: <ed9a32cf-1cf4-2fdd-1e8d-5904c4d24837@amd.com>

(snip)
> #ifdef CONFIG_DEV_COREDUMP
>                                  tmp_adev->reset_context_vram_lost = 
> vram_lost;
> tmp_adev->reset_context_task_info.pid = 0;
>                                  if (reset_context->job && 
> reset_context->job->vm)
> tmp_adev->reset_context_task_info =
> reset_context->job->vm->task_info;
> amdgpu_reset_capture_coredumpm(tmp_adev);
> #endif
> tmp_adev->reset_context_task_info refers to 
> reset_context->job->vm->task_info,
> i am not setting PID and process name separately, instead i am having 
> the reference to the reset_context->job->vm->task_info on valid VM.
> 

I think you are not getting my point. struct amdgpu_task_info has 3 more 
parameters: process_name, task_name and tgid.

When VRAM is not lost: we are getting the whole new amdgpu_task_info 
structure, and all parameters are valid.

When VRAM is lost: we should reset all parameters of amdgpu_task_info 
structure, not just pid. Else other params may contain garbage.

So what I mean is:
instead of
tmp_adev->reset_context_task_info.pid = 0;

do something like:
memset(&tmp_adev->reset_context_task_info.pid, 0, 
sizeof(reset_context_task_info));

- Shashank

  reply	other threads:[~2022-05-24 17:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-20 13:49 [PATCH v1 1/2] drm/amdgpu: save the reset dump register value for devcoredump Somalapuram Amaranath
2022-05-20 13:49 ` [PATCH v1 2/2] drm/amdgpu: adding device coredump support Somalapuram Amaranath
2022-05-20 14:22   ` Sharma, Shashank
2022-05-24  6:42     ` Somalapuram, Amaranath
2022-05-24  9:53       ` Sharma, Shashank
2022-05-24 12:10         ` Somalapuram, Amaranath
2022-05-24 12:50           ` Sharma, Shashank
2022-05-24 13:18             ` Somalapuram, Amaranath
2022-05-24 15:04               ` Sharma, Shashank
2022-05-24 15:18                 ` Somalapuram, Amaranath
2022-05-24 17:27                   ` Sharma, Shashank [this message]
2022-05-20 14:06 ` [PATCH v1 1/2] drm/amdgpu: save the reset dump register value for devcoredump Sharma, Shashank
2022-05-24  6:12   ` Somalapuram, Amaranath
2022-05-24  9:55     ` Sharma, Shashank
2022-05-24 11:57       ` Somalapuram, Amaranath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=218d95f3-b38d-21ff-64fb-3f3df666babe@amd.com \
    --to=shashank.sharma@amd.com \
    --cc=Amaranath.Somalapuram@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=asomalap@amd.com \
    --cc=christian.koenig@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.