From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 1/8] drivers/common/dpaa2: Run time assembler for Descriptor formation Date: Wed, 07 Dec 2016 14:13:31 +0100 Message-ID: <2191747.cEMNQWRsu6@xps13> References: <20161205125540.6419-1-akhil.goyal@nxp.com> <13107823.ZnI407z9cY@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, declan.doherty@intel.com, pablo.de.lara.guarch@intel.com, Hemant Agrawal , Horia =?utf-8?B?R2VhbnTEgw==?= To: Akhil Goyal Return-path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 9C385388F for ; Wed, 7 Dec 2016 14:13:34 +0100 (CET) Received: by mail-wm0-f47.google.com with SMTP id t79so166101111wmt.0 for ; Wed, 07 Dec 2016 05:13:34 -0800 (PST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-12-07 11:44, Akhil Goyal: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > 2016-12-07 06:24, Akhil Goyal: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2016-12-05 18:25, Akhil Goyal: > > > FLib is a library which helps in making the descriptors which is > > > understood by NXP's SEC hardware. > > > This patch provides header files for command words which can be used > > > for descritptor formation. > > > > It seems this code is old. Does it exist as a standalone library somewhere? > [Akhil] Let me correct here. This is not a library. This is a set of header files. Use the name you want but please be consistent. You said above: "FLib is a library" and now "This is not a library" Funny :) > Yes this is an old code. This is generally shipped with NXP SDK. > > > Where was it hosted before duplicating it in DPDK? > [Akhil] This is part of NXP SDK and also available at git.freescale.com. So it is not a DPDK code. It should be a standalone library (or set of headers) and packaged as well. > > Why do you want to have a common directory drivers/common/dpaa2/flib instead of a sub-directory in the crypto driver? > [Akhil] I agree with your suggestion. This can be maintained within drivers/crypto as a common header files set for different NXP Architecture crypto drivers. Yes it can be in drivers/crypto/ or not in DPDK at all.