All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wei.liu2@citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH for-4.6 2/3] libxl/psr: use Xen error codes when checking hypercall return values
Date: Tue, 21 Jul 2015 12:15:44 +0100	[thread overview]
Message-ID: <21934.10720.172223.582437@mariner.uk.xensource.com> (raw)
In-Reply-To: <1437404102-7807-3-git-send-email-roger.pau@citrix.com>

Roger Pau Monne writes ("[PATCH for-4.6 2/3] libxl/psr: use Xen error codes when checking hypercall return values"):
> We cannot use the systems errno values when checking return values from Xen,
> because some OSes don't have the same set of errno definitions. Instead
> use the definitions present in Xen public errno.h header.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

> I have not checked if there are other places in libxl that need similar
> treatment, I just came around this because FreeBSD doesn't have EBADSLT
> defined.

Right.  There is probably more of this, but that's not a blocker for
this patch.

Maybe it would be worth mentioning this issue in CODING_STYLE.

Ian.

  reply	other threads:[~2015-07-21 11:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-20 14:54 [PATCH for-4.6 0/3] FreeBSD fixes Roger Pau Monne
2015-07-20 14:55 ` [PATCH for-4.6 1/3] libxl: include sys/endian.h for FreeBSD Roger Pau Monne
2015-07-21  9:36   ` Wei Liu
2015-07-21 14:49     ` Ian Campbell
2015-07-20 14:55 ` [PATCH for-4.6 2/3] libxl/psr: use Xen error codes when checking hypercall return values Roger Pau Monne
2015-07-21 11:15   ` Ian Jackson [this message]
2015-07-21 11:36     ` Ian Jackson
2015-07-21 11:43       ` Andrew Cooper
2015-07-21 12:40         ` Ian Jackson
2015-07-21 12:47           ` Ian Campbell
2015-07-21 13:14             ` Jan Beulich
2015-07-21 13:30               ` Ian Campbell
2015-07-20 14:55 ` [PATCH for-4.6 3/3] hotplug/FreeBSD: fix xendriverdomain rc.d script Roger Pau Monne
2015-07-21 11:03   ` Wei Liu
2015-07-21 14:49     ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21934.10720.172223.582437@mariner.uk.xensource.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=roger.pau@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.