From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: Re: [OSSTEST PATCH 02/13] Planner: docs: Minor fixes Date: Thu, 3 Sep 2015 13:04:07 +0100 Message-ID: <21992.14135.455618.540486@mariner.uk.xensource.com> References: <1441208719-31336-1-git-send-email-ian.jackson@eu.citrix.com> <1441208719-31336-3-git-send-email-ian.jackson@eu.citrix.com> <1441277246.26292.338.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZXTSv-0003GL-Eu for xen-devel@lists.xenproject.org; Thu, 03 Sep 2015 12:18:05 +0000 In-Reply-To: <1441277246.26292.338.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, Ian Jackson List-Id: xen-devel@lists.xenproject.org Ian Campbell writes ("Re: [OSSTEST PATCH 02/13] Planner: docs: Minor fixes"): > On Wed, 2015-09-02 at 16:45 +0100, Ian Jackson wrote: > > sub alloc_resources { > > - my ($resourcecall) = pop @_; > > + my ($resourcecall) = pop @_; # $resourcecall->($plan); > > Took me a while to work out this means $resourcecall is a function which > should be called as shown, but now I've got that: ... > Maybe consider adding "Called as" to the front of the comment though? (Ack > either way) Perl syntax like $resourcecall->($plan) always means that $resourcecall is a subref which is being invoked. And the variable is called `call'. So I think extra commentary would be redundant. > Acked-by: Ian Campbell Thanks, Ian.