From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Mon, 04 Jan 2016 14:38:19 +0000 Subject: Re: [PATCH RESEND 2/3] drm: adv7511: mark ADV7511_REG_EDID_READ_CTRL volatile Message-Id: <2199297.HWp4hEOABu@avalon> List-Id: References: <1451874827-2531-1-git-send-email-wsa@the-dreams.de> <1451874827-2531-2-git-send-email-wsa@the-dreams.de> In-Reply-To: <1451874827-2531-2-git-send-email-wsa@the-dreams.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Wolfram Sang Cc: linux-sh@vger.kernel.org, Daniel Vetter , Magnus Damm , dri-devel@lists.freedesktop.org, Simon Horman , Geert Uytterhoeven , Kuninori Morimoto Hi Wolfram, Thank you for the patch. On Monday 04 January 2016 03:33:46 Wolfram Sang wrote: > From: Wolfram Sang > > This register includes a counter which is decremented by the chip on I2C > failures. Also, it is reset when powering down. > > Signed-off-by: Wolfram Sang Reviewed-by: Laurent Pinchart A small note though, even though the patch is correct, it will be of limited use as the EDID_READ_CTRL register is never accessed by the driver. > --- > drivers/gpu/drm/i2c/adv7511.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/i2c/adv7511.c b/drivers/gpu/drm/i2c/adv7511.c > index 85e994796d96a4..50a861b12346c4 100644 > --- a/drivers/gpu/drm/i2c/adv7511.c > +++ b/drivers/gpu/drm/i2c/adv7511.c > @@ -136,6 +136,7 @@ static bool adv7511_register_volatile(struct device > *dev, unsigned int reg) case ADV7511_REG_BKSV(3): > case ADV7511_REG_BKSV(4): > case ADV7511_REG_DDC_STATUS: > + case ADV7511_REG_EDID_READ_CTRL: > case ADV7511_REG_BSTATUS(0): > case ADV7511_REG_BSTATUS(1): > case ADV7511_REG_CHIP_ID_HIGH: -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH RESEND 2/3] drm: adv7511: mark ADV7511_REG_EDID_READ_CTRL volatile Date: Mon, 04 Jan 2016 16:38:19 +0200 Message-ID: <2199297.HWp4hEOABu@avalon> References: <1451874827-2531-1-git-send-email-wsa@the-dreams.de> <1451874827-2531-2-git-send-email-wsa@the-dreams.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8988C6E43E for ; Mon, 4 Jan 2016 06:39:07 -0800 (PST) In-Reply-To: <1451874827-2531-2-git-send-email-wsa@the-dreams.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Wolfram Sang Cc: linux-sh@vger.kernel.org, Daniel Vetter , Magnus Damm , dri-devel@lists.freedesktop.org, Simon Horman , Geert Uytterhoeven , Kuninori Morimoto List-Id: dri-devel@lists.freedesktop.org SGkgV29sZnJhbSwKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLgoKT24gTW9uZGF5IDA0IEphbnVh cnkgMjAxNiAwMzozMzo0NiBXb2xmcmFtIFNhbmcgd3JvdGU6Cj4gRnJvbTogV29sZnJhbSBTYW5n IDx3c2ErcmVuZXNhc0BzYW5nLWVuZ2luZWVyaW5nLmNvbT4KPiAKPiBUaGlzIHJlZ2lzdGVyIGlu Y2x1ZGVzIGEgY291bnRlciB3aGljaCBpcyBkZWNyZW1lbnRlZCBieSB0aGUgY2hpcCBvbiBJMkMK PiBmYWlsdXJlcy4gQWxzbywgaXQgaXMgcmVzZXQgd2hlbiBwb3dlcmluZyBkb3duLgo+IAo+IFNp Z25lZC1vZmYtYnk6IFdvbGZyYW0gU2FuZyA8d3NhK3JlbmVzYXNAc2FuZy1lbmdpbmVlcmluZy5j b20+CgpSZXZpZXdlZC1ieTogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVh c29uYm9hcmQuY29tPgoKQSBzbWFsbCBub3RlIHRob3VnaCwgZXZlbiB0aG91Z2ggdGhlIHBhdGNo IGlzIGNvcnJlY3QsIGl0IHdpbGwgYmUgb2YgbGltaXRlZCAKdXNlIGFzIHRoZSBFRElEX1JFQURf Q1RSTCByZWdpc3RlciBpcyBuZXZlciBhY2Nlc3NlZCBieSB0aGUgZHJpdmVyLgoKPiAtLS0KPiAg ZHJpdmVycy9ncHUvZHJtL2kyYy9hZHY3NTExLmMgfCAxICsKPiAgMSBmaWxlIGNoYW5nZWQsIDEg aW5zZXJ0aW9uKCspCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pMmMvYWR2NzUx MS5jIGIvZHJpdmVycy9ncHUvZHJtL2kyYy9hZHY3NTExLmMKPiBpbmRleCA4NWU5OTQ3OTZkOTZh NC4uNTBhODYxYjEyMzQ2YzQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2kyYy9hZHY3 NTExLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTJjL2Fkdjc1MTEuYwo+IEBAIC0xMzYsNiAr MTM2LDcgQEAgc3RhdGljIGJvb2wgYWR2NzUxMV9yZWdpc3Rlcl92b2xhdGlsZShzdHJ1Y3QgZGV2 aWNlCj4gKmRldiwgdW5zaWduZWQgaW50IHJlZykgY2FzZSBBRFY3NTExX1JFR19CS1NWKDMpOgo+ ICAJY2FzZSBBRFY3NTExX1JFR19CS1NWKDQpOgo+ICAJY2FzZSBBRFY3NTExX1JFR19ERENfU1RB VFVTOgo+ICsJY2FzZSBBRFY3NTExX1JFR19FRElEX1JFQURfQ1RSTDoKPiAgCWNhc2UgQURWNzUx MV9SRUdfQlNUQVRVUygwKToKPiAgCWNhc2UgQURWNzUxMV9SRUdfQlNUQVRVUygxKToKPiAgCWNh c2UgQURWNzUxMV9SRUdfQ0hJUF9JRF9ISUdIOgoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNo YXJ0CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=