From: Nadav Amit <namit@vmware.com>
To: Oleksandr Natalenko <oleksandr@redhat.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Xavier Deguillard <xdeguillard@vmware.com>,
pv-drivers <pv-drivers@vmware.com>,
LKML <linux-kernel@vger.kernel.org>,
Gil Kupfer <gilkup@gmail.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"ldu@redhat.com" <ldu@redhat.com>
Subject: Re: [PATCH v2] vmw_balloon: fixing double free when batching mode is off
Date: Thu, 22 Mar 2018 20:02:38 +0000 [thread overview]
Message-ID: <219A03D6-7375-4577-90BA-45DCF2A29289@vmware.com> (raw)
In-Reply-To: <CAHcwAbSijSmeU3WnznAC+ZaF9iCmYkizqiJNuvLcrYm-YCWxRg@mail.gmail.com>
Oleksandr Natalenko <oleksandr@redhat.com> wrote:
> Hi.
>
> On Mon, Mar 19, 2018 at 7:52 PM, Nadav Amit <namit@vmware.com> wrote:
>>> Oleksandr, if you can confirm that it fixes the bug you encountered, it
>>> would be great.
>>>
>>> Greg, Arnd, on your free time, please let me know if there is any issue
>>> with the patch, and whether you can incorporate it, preferably in 4.16,
>>> since it is a bug-fix that was encountered by Red-Hat customers.
>>
>> Ping?
>
> No news from me (yet). We depends on the customer here since we are
> unable to reproduce the issue in-house. If you have a recipe on how to
> trigger it reliably, please let us know, and this will speed up the
> verification process.
Actually, rechecking the bug description, I might have rushed. The bug that
I encountered is related to the vunmap() but it is only caused when batching
is off, while the bug you reported has batching on.
It seems that your sources support batching but do not include b91f108a3d54
(“VMware balloon: Treat init like reset”), which I think would have solved
the problem. I don’t see a mainline kernel that supports batching and does
not have this patch, so it would be helpful to see the exact module that you
use.
Regards,
Nadav
next prev parent reply other threads:[~2018-03-22 20:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 19:19 [PATCH] vmw_balloon: fixing double free when batching mode is off Nadav Amit
2018-03-12 19:28 ` [PATCH v2] " Nadav Amit
2018-03-14 4:02 ` Nadav Amit
2018-03-14 7:41 ` Oleksandr Natalenko
2018-03-19 18:52 ` Nadav Amit
2018-03-20 7:21 ` Oleksandr Natalenko
2018-03-22 20:02 ` Nadav Amit [this message]
2018-03-23 8:42 ` Oleksandr Natalenko
2018-04-16 11:36 ` Oleksandr Natalenko
2018-04-18 17:54 ` Nadav Amit
2018-04-19 6:38 ` Greg Kroah-Hartman
2018-04-19 18:17 ` [PATCH v3] " Nadav Amit
2018-04-30 17:30 ` Nadav Amit
2018-05-04 11:26 ` Oleksandr Natalenko
2018-05-30 1:21 ` Nadav Amit
2018-05-31 20:56 ` Nadav Amit
2018-06-01 7:59 ` Greg Kroah-Hartman
2018-06-01 15:00 ` Nadav Amit
2018-06-01 7:47 ` [PATCH v3 RESEND] " Nadav Amit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=219A03D6-7375-4577-90BA-45DCF2A29289@vmware.com \
--to=namit@vmware.com \
--cc=arnd@arndb.de \
--cc=gilkup@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ldu@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr@redhat.com \
--cc=pv-drivers@vmware.com \
--cc=stable@vger.kernel.org \
--cc=xdeguillard@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.