From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8547C433E0 for ; Tue, 23 Feb 2021 15:14:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 731F364E22 for ; Tue, 23 Feb 2021 15:14:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233093AbhBWPOM (ORCPT ); Tue, 23 Feb 2021 10:14:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233109AbhBWPNE (ORCPT ); Tue, 23 Feb 2021 10:13:04 -0500 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1C70C061574 for ; Tue, 23 Feb 2021 07:12:22 -0800 (PST) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1lEZMJ-007QiJ-Hv; Tue, 23 Feb 2021 16:12:19 +0100 Message-ID: <21aa1d80eccede559bebf7201f03a74e67272b4f.camel@sipsolutions.net> Subject: Re: [PATCH v2] gdb: lx-symbols: store the abspath() From: Johannes Berg To: Jan Kiszka , linux-kernel@vger.kernel.org, Andrew Morton Cc: Kieran Bingham Date: Tue, 23 Feb 2021 16:12:17 +0100 In-Reply-To: <60d43738-1d89-30b0-54bd-8303daeadc57@siemens.com> References: <20201217091747.bf4332cf2b35.I10ebbdb7e9b80ab1a5cddebf53d073be8232d656@changeid> <60d43738-1d89-30b0-54bd-8303daeadc57@siemens.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2020-12-17 at 09:31 +0100, Jan Kiszka wrote: > On 17.12.20 09:17, Johannes Berg wrote: > > From: Johannes Berg > > > > If we store the relative path, the user might later cd to a > > different directory, and that would break the automatic symbol > > resolving that happens when a module is loaded into the target > > kernel. Fix this by storing the abspath() of each path given, > > just like we already do for the cwd (os.getcwd() is absolute.) > Reviewed-by: Jan Kiszka So ... I'm still carrying this patch. Anyone want to send it to Linus? Andrew, maybe you? Thanks, johannes