From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, berrange@redhat.com, ehabkost@redhat.com,
michael.roth@amd.com, hreitz@redhat.com, pbonzini@redhat.com
Subject: Re: [PATCH] qapi: Improve input_type_enum()'s error message
Date: Mon, 11 Oct 2021 15:20:37 +0200 [thread overview]
Message-ID: <21b18531-4de2-cb85-f48f-4c51e91be0f1@redhat.com> (raw)
In-Reply-To: <20211011131558.3273255-1-armbru@redhat.com>
On 10/11/21 15:15, Markus Armbruster wrote:
> The error message claims the parameter is invalid:
>
> $ qemu-system-x86_64 -object qom-type=nonexistent
> qemu-system-x86_64: -object qom-type=nonexistent: Invalid parameter 'nonexistent'
>
> What's wrong is actually the *value* 'nonexistent'. Improve the
> message to
>
> qemu-system-x86_64: -object qom-type=nonexistent: Parameter 'qom-type' does not accept value 'nonexistent'
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> qapi/qapi-visit-core.c | 3 ++-
> tests/unit/check-qom-proplist.c | 2 +-
> tests/qemu-iotests/049.out | 6 +++---
> tests/qemu-iotests/206.out | 2 +-
> tests/qemu-iotests/237.out | 6 +++---
> tests/qemu-iotests/245 | 2 +-
> 6 files changed, 11 insertions(+), 10 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2021-10-11 13:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 13:15 [PATCH] qapi: Improve input_type_enum()'s error message Markus Armbruster
2021-10-11 13:20 ` Philippe Mathieu-Daudé [this message]
2021-10-12 11:07 ` Kevin Wolf
2021-10-12 12:06 ` Markus Armbruster
2021-10-26 19:18 ` John Snow
2021-10-27 6:00 ` Markus Armbruster
2021-10-27 15:17 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21b18531-4de2-cb85-f48f-4c51e91be0f1@redhat.com \
--to=philmd@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.