All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
	Rob Herring <robh+dt@kernel.org>,
	linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: rtc: pcf2127: update bindings
Date: Wed, 27 Jan 2021 14:49:22 +0100	[thread overview]
Message-ID: <21d5858b-85b6-8d03-ca82-d314c2a2f2dc@prevas.dk> (raw)
In-Reply-To: <20210127131821.GH1196852@piout.net>

On 27/01/2021 14.18, Alexandre Belloni wrote:
> On 27/01/2021 14:07:59+0100, Rasmus Villemoes wrote:
>> On 26/01/2021 23.48, Alexandre Belloni wrote:
>>> On 21/12/2020 22:17:54+0100, Rasmus Villemoes wrote:
>>>> On 19/12/2020 02.34, Alexandre Belloni wrote:
>>>>> pcf2127, pcf2129 and pca2129 support start-year and reset-source.
>>>>>
>>>>
>>>> No, the 2129 variant doesn't even have a reset output pin. Not sure if
>>>> there's any way to reflect that, and it probably doesn't matter, since
>>>> nobody's going to add the reset-source property to a 2129 node. But the
>>>> commit message is a bit misleading.
>>>>
>>>
>>> Actually no, the INT pin can be used as a reset, the pcf/pca2129
>>> can be used as a watchdog and so it may need the reset-source property.
>>
>> Unless I'm missing something, that would require some rather creative
>> extra circuitry: The interrupt pin is kept low until the appropriate bit
>> in the rtc is cleared, so if that is routed directly to a reset pin on
>> the SOC, the SOC would be kept in reset indefinitely.
>>
> 
> You mean inverting the level of INT? I don't think this is creative or
> complicated...

No, that is not what I meant nor what I wrote.

> And anyway, INT# is active low, like RST# so if the SoC has an RST#
> input, this should just work.

AFAIK (and that may certainly be wrong), most SOCs require a _pulse_ on
their reset input; asserting and keeping the reset pin low would just
keep the cpu in reset, never allowing it to leave that state and then
talk to the RTC to clear the bit that would clear the interrupt.

That's also how the 2127 RST# behaves: it generates a pulse (of width
244us or 15ms). The INT# and RST# pins cannot be used interchangeably.

Rasmus

      reply	other threads:[~2021-01-27 13:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-19  1:34 [PATCH] dt-bindings: rtc: pcf2127: update bindings Alexandre Belloni
2020-12-21 21:17 ` Rasmus Villemoes
2020-12-21 21:39   ` Alexandre Belloni
2021-01-26 22:48   ` Alexandre Belloni
2021-01-27 13:07     ` Rasmus Villemoes
2021-01-27 13:18       ` Alexandre Belloni
2021-01-27 13:49         ` Rasmus Villemoes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21d5858b-85b6-8d03-ca82-d314c2a2f2dc@prevas.dk \
    --to=rasmus.villemoes@prevas.dk \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.