From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCHv6 22/33] net/dpaa2: add support for l3 and l4 checksum offload Date: Mon, 23 Jan 2017 17:35:59 +0000 Message-ID: <21d59f80-2d4f-65a6-657b-cbcf0d2c1a08@intel.com> References: <1484832240-2048-1-git-send-email-hemant.agrawal@nxp.com> <1485172803-17288-1-git-send-email-hemant.agrawal@nxp.com> <1485172803-17288-23-git-send-email-hemant.agrawal@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Cc: thomas.monjalon@6wind.com, bruce.richardson@intel.com, shreyansh.jain@nxp.com, john.mcnamara@intel.com, jerin.jacob@caviumnetworks.com To: Hemant Agrawal , dev@dpdk.org Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id AF8A14CE4 for ; Mon, 23 Jan 2017 18:36:03 +0100 (CET) In-Reply-To: <1485172803-17288-23-git-send-email-hemant.agrawal@nxp.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/23/2017 11:59 AM, Hemant Agrawal wrote: > Signed-off-by: Hemant Agrawal > --- <...> > --- a/drivers/net/dpaa2/Makefile > +++ b/drivers/net/dpaa2/Makefile > @@ -66,6 +66,6 @@ DEPDIRS-$(CONFIG_RTE_LIBRTE_DPAA2_PMD) += lib/librte_eal lib/librte_ether > DEPDIRS-$(CONFIG_RTE_LIBRTE_DPAA2_PMD) += lib/librte_mempool lib/librte_mbuf > DEPDIRS-$(CONFIG_RTE_LIBRTE_DPAA2_PMD) += lib/librte_common_dpaa2_qbman > DEPDIRS-$(CONFIG_RTE_LIBRTE_DPAA2_PMD) += lib/librte_bus_fslmc > -DEPDIRS-$(CONFIG_RTE_LIBRTE_DPAA2_PMD) += lib/librte_pmd_dpaa2_pool > +DEPDIRS-$(CONFIG_RTE_LIBRTE_DPAA2_PMD) += lib/librte_pool_dpaa2 I understand these are added since DEPDIRS converted to LDLIBS, but this does not looks right, since these variables mainly dependency solving and the value provided is not correct for DEPDIRS. Did you tried adding as "LDLIBS += xx", not tested, but may work. > > include $(RTE_SDK)/mk/rte.lib.mk > diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c > index 6de571a..2298246 100644 > --- a/drivers/net/dpaa2/dpaa2_ethdev.c > +++ b/drivers/net/dpaa2/dpaa2_ethdev.c > @@ -68,7 +68,17 @@ > dev_info->min_rx_bufsize = DPAA2_MIN_RX_BUF_SIZE; > dev_info->max_rx_queues = (uint16_t)priv->nb_rx_queues; > dev_info->max_tx_queues = (uint16_t)priv->nb_tx_queues; > - > + dev_info->rx_offload_capa = > + DEV_RX_OFFLOAD_IPV4_CKSUM | > + DEV_RX_OFFLOAD_UDP_CKSUM | > + DEV_RX_OFFLOAD_TCP_CKSUM | > + DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM; Is there capabilities always enabled for all devices this driver support? Or should these be read from some device registers? > + dev_info->tx_offload_capa = > + DEV_TX_OFFLOAD_IPV4_CKSUM | > + DEV_TX_OFFLOAD_UDP_CKSUM | > + DEV_TX_OFFLOAD_TCP_CKSUM | > + DEV_TX_OFFLOAD_SCTP_CKSUM | > + DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM; > dev_info->speed_capa = ETH_LINK_SPEED_1G | > ETH_LINK_SPEED_2_5G | > ETH_LINK_SPEED_10G; <...>