From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Hansen Date: Mon, 10 Sep 2018 21:09:26 +0000 Subject: Re: [RFC 09/12] mm: Restrict memory encryption to anonymous VMA's Message-Id: <21db220c-257b-f9b5-2b41-992267f0552b@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Id: References: <84154fd2-7c27-0fd2-f339-15e144a5df49@intel.com> <20180910210716.GB26766@intel.com> In-Reply-To: <20180910210716.GB26766@intel.com> To: Jarkko Sakkinen Cc: "tglx@linutronix.de" , "Schofield, Alison" , "dhowells@redhat.com" , "Shutemov, Kirill" , "keyrings@vger.kernel.org" , "jmorris@namei.org" , "Huang, Kai" , "linux-mm@kvack.org" , "linux-security-module@vger.kernel.org" , "x86@kernel.org" , "hpa@zytor.com" , "mingo@redhat.com" , "Nakajima, Jun" On 09/10/2018 02:07 PM, Jarkko Sakkinen wrote: > On Mon, Sep 10, 2018 at 11:57:49AM -0700, Dave Hansen wrote: >> On 09/10/2018 11:21 AM, Sakkinen, Jarkko wrote: >>>> +/* >>>> + * Encrypted mprotect is only supported on anonymous mappings. >>>> + * All VMA's in the requested range must be anonymous. If this >>>> + * test fails on any single VMA, the entire mprotect request fails. >>>> + */ >>> kdoc >> kdoc what? You want this comment in kdoc format? Why? > If there is a header comment for a function anyway, why wouldn't you > put it to kdoc-format? Because this is a shorter and more concise way to document the function. kdoc isn't universally the best thing to do for function comments. From mboxrd@z Thu Jan 1 00:00:00 1970 From: dave.hansen@intel.com (Dave Hansen) Date: Mon, 10 Sep 2018 14:09:26 -0700 Subject: [RFC 09/12] mm: Restrict memory encryption to anonymous VMA's In-Reply-To: <20180910210716.GB26766@intel.com> References: <84154fd2-7c27-0fd2-f339-15e144a5df49@intel.com> <20180910210716.GB26766@intel.com> Message-ID: <21db220c-257b-f9b5-2b41-992267f0552b@intel.com> To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org On 09/10/2018 02:07 PM, Jarkko Sakkinen wrote: > On Mon, Sep 10, 2018 at 11:57:49AM -0700, Dave Hansen wrote: >> On 09/10/2018 11:21 AM, Sakkinen, Jarkko wrote: >>>> +/* >>>> + * Encrypted mprotect is only supported on anonymous mappings. >>>> + * All VMA's in the requested range must be anonymous. If this >>>> + * test fails on any single VMA, the entire mprotect request fails. >>>> + */ >>> kdoc >> kdoc what? You want this comment in kdoc format? Why? > If there is a header comment for a function anyway, why wouldn't you > put it to kdoc-format? Because this is a shorter and more concise way to document the function. kdoc isn't universally the best thing to do for function comments. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by kanga.kvack.org (Postfix) with ESMTP id C82F98E0001 for ; Mon, 10 Sep 2018 17:09:27 -0400 (EDT) Received: by mail-pg1-f200.google.com with SMTP id o16-v6so11211738pgv.21 for ; Mon, 10 Sep 2018 14:09:27 -0700 (PDT) Received: from mga03.intel.com (mga03.intel.com. [134.134.136.65]) by mx.google.com with ESMTPS id r12-v6si17060891plo.105.2018.09.10.14.09.26 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 10 Sep 2018 14:09:26 -0700 (PDT) Subject: Re: [RFC 09/12] mm: Restrict memory encryption to anonymous VMA's References: <84154fd2-7c27-0fd2-f339-15e144a5df49@intel.com> <20180910210716.GB26766@intel.com> From: Dave Hansen Message-ID: <21db220c-257b-f9b5-2b41-992267f0552b@intel.com> Date: Mon, 10 Sep 2018 14:09:26 -0700 MIME-Version: 1.0 In-Reply-To: <20180910210716.GB26766@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Jarkko Sakkinen Cc: "tglx@linutronix.de" , "Schofield, Alison" , "dhowells@redhat.com" , "Shutemov, Kirill" , "keyrings@vger.kernel.org" , "jmorris@namei.org" , "Huang, Kai" , "linux-mm@kvack.org" , "linux-security-module@vger.kernel.org" , "x86@kernel.org" , "hpa@zytor.com" , "mingo@redhat.com" , "Nakajima, Jun" On 09/10/2018 02:07 PM, Jarkko Sakkinen wrote: > On Mon, Sep 10, 2018 at 11:57:49AM -0700, Dave Hansen wrote: >> On 09/10/2018 11:21 AM, Sakkinen, Jarkko wrote: >>>> +/* >>>> + * Encrypted mprotect is only supported on anonymous mappings. >>>> + * All VMA's in the requested range must be anonymous. If this >>>> + * test fails on any single VMA, the entire mprotect request fails. >>>> + */ >>> kdoc >> kdoc what? You want this comment in kdoc format? Why? > If there is a header comment for a function anyway, why wouldn't you > put it to kdoc-format? Because this is a shorter and more concise way to document the function. kdoc isn't universally the best thing to do for function comments.