From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754615AbdJLIev (ORCPT ); Thu, 12 Oct 2017 04:34:51 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:10367 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751186AbdJLIet (ORCPT ); Thu, 12 Oct 2017 04:34:49 -0400 From: Amelie DELAUNAY To: Alexandre TORGUE , Felipe Balbi , Greg Kroah-Hartman , Rob Herring , Mark Rutland , Russell King , Maxime Coquelin , John Youn CC: "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Benjamin GAIGNARD Subject: Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7 Thread-Topic: [PATCHv2 0/7] Add support for USB OTG on STM32F7 Thread-Index: AQHTIAjMWJuEqCL/B0y4n5ESIC0mBqLejyGAgAAZvICAAAO4AIAABD8AgAAWx4CAABPoAIABLEAA Date: Thu, 12 Oct 2017 08:32:49 +0000 Message-ID: <21df4d0c-075c-0c5a-c39b-b1dd94fe819d@st.com> References: <1503930018-536-1-git-send-email-amelie.delaunay@st.com> <878tgim24i.fsf@linux.intel.com> <04a49088-b615-d7b8-0387-e7bfa32ee19f@st.com> <87vajllx8t.fsf@linux.intel.com> <1c4180ef-2da6-b420-7c6e-41769608384a@st.com> <87sheplsrm.fsf@linux.intel.com> <3c36db6d-75fd-1be6-e946-b75a04e3760e@st.com> In-Reply-To: <3c36db6d-75fd-1be6-e946-b75a04e3760e@st.com> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.46] Content-Type: text/plain; charset="utf-8" Content-ID: <986FF4D5E7B95E4BB9F51888DCC58894@st.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-10-12_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v9C8YvBd020765 Hi Felipe, Alex, On 10/11/2017 04:38 PM, Alexandre Torgue wrote: > > > On 10/11/2017 03:26 PM, Felipe Balbi wrote: >> >> Hi, >> >> Alexandre Torgue writes: >>> Hi >>> >>> On 10/11/2017 01:50 PM, Felipe Balbi wrote: >>>> >>>> Hi, >>>> >>>> Alexandre Torgue writes: >>>>> Hi Felip >>>>> >>>>> On 10/11/2017 12:04 PM, Felipe Balbi wrote: >>>>>> >>>>>> Hi, >>>>>> >>>>>> Amelie Delaunay writes: >>>>>>> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is >>>>>>> USB >>>>>>> OTG FS and the other is USB OTG HS. The USB FS core only works >>>>>>> with its >>>>>>> internal phy whilst the USB HS core can work in HS with external >>>>>>> ULPI phy >>>>>>> or in FS/LS with the on-chip FS phy. >>>>>>> >>>>>>> Amelie Delaunay (7): >>>>>>>      dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core >>>>>>> binding >>>>>>>      usb: dwc2: add support for STM32F7 USB OTG HS >>>>>>>      ARM: dts: stm32: Add USB HS support for STM32F746 MCU >>>>>> >>>>>> I have applied these three patches. Should I take the rest? They >>>>>> seems >>>>>> like they could go upstream through the ARM maintainers. >>>>>> >>>>> >>>>> I will take other DT patches in my PR. >>>>> >>>>> Concerning "ARM: dts: stm32: Add USB HS support for STM32F746 MCU" >>>>> patch >>>>> I prefer also to take it. This patch adds some pinctrl groups but >>>>> stm32 >>>>> pinctrl bindings will change in my next PR (we will use a macro to >>>>> define pins instead of using defined values). So if you push the DT >>>>> patch through your pull request there will be a merge issue. >>>>> It is possible that I take also this one ? >>>> >>>> In that case, it's best if you take them all :-) Here's my Ack: >>>> >>>> Acked-by: Felipe Balbi >>>> >>>> I'll drop them from my tree now >>> >>> Ok perfect, I will take DT patches (3 to 7) and I let you take patch 1&2 >>> in your tree. >> >> Well, I have dropped them from my tree. Please two 1-7 through yours. > > Hum, ok for this patchset but IMO it is better (next time) that you take > driver pacthes in your tree and I take only DT patches in mine. > No ? > > Regards > Alex > >> I thought that patches 1 and 2, as they are "driver" patches, had to be applied on USB tree (so Felipe's one), and the others (3 to 7) had to be applied on STM32-DT tree (Alex's one). Did I miss something? Regards, Amelie From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amelie DELAUNAY Subject: Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7 Date: Thu, 12 Oct 2017 08:32:49 +0000 Message-ID: <21df4d0c-075c-0c5a-c39b-b1dd94fe819d@st.com> References: <1503930018-536-1-git-send-email-amelie.delaunay@st.com> <878tgim24i.fsf@linux.intel.com> <04a49088-b615-d7b8-0387-e7bfa32ee19f@st.com> <87vajllx8t.fsf@linux.intel.com> <1c4180ef-2da6-b420-7c6e-41769608384a@st.com> <87sheplsrm.fsf@linux.intel.com> <3c36db6d-75fd-1be6-e946-b75a04e3760e@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <3c36db6d-75fd-1be6-e946-b75a04e3760e-qxv4g6HH51o@public.gmane.org> Content-Language: en-US Content-ID: <986FF4D5E7B95E4BB9F51888DCC58894-qxv4g6HH51o@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alexandre TORGUE , Felipe Balbi , Greg Kroah-Hartman , Rob Herring , Mark Rutland , Russell King , Maxime Coquelin , John Youn Cc: "linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Benjamin GAIGNARD List-Id: devicetree@vger.kernel.org SGkgRmVsaXBlLCBBbGV4LA0KDQpPbiAxMC8xMS8yMDE3IDA0OjM4IFBNLCBBbGV4YW5kcmUgVG9y Z3VlIHdyb3RlOg0KPiANCj4gDQo+IE9uIDEwLzExLzIwMTcgMDM6MjYgUE0sIEZlbGlwZSBCYWxi aSB3cm90ZToNCj4+DQo+PiBIaSwNCj4+DQo+PiBBbGV4YW5kcmUgVG9yZ3VlIDxhbGV4YW5kcmUu dG9yZ3VlQHN0LmNvbT4gd3JpdGVzOg0KPj4+IEhpDQo+Pj4NCj4+PiBPbiAxMC8xMS8yMDE3IDAx OjUwIFBNLCBGZWxpcGUgQmFsYmkgd3JvdGU6DQo+Pj4+DQo+Pj4+IEhpLA0KPj4+Pg0KPj4+PiBB bGV4YW5kcmUgVG9yZ3VlIDxhbGV4YW5kcmUudG9yZ3VlQHN0LmNvbT4gd3JpdGVzOg0KPj4+Pj4g SGkgRmVsaXANCj4+Pj4+DQo+Pj4+PiBPbiAxMC8xMS8yMDE3IDEyOjA0IFBNLCBGZWxpcGUgQmFs Ymkgd3JvdGU6DQo+Pj4+Pj4NCj4+Pj4+PiBIaSwNCj4+Pj4+Pg0KPj4+Pj4+IEFtZWxpZSBEZWxh dW5heSA8YW1lbGllLmRlbGF1bmF5QHN0LmNvbT4gd3JpdGVzOg0KPj4+Pj4+PiBUaGUgU1RNMzJG NyBNQ1UgZmFtaWx5IGVtYmVkcyB0d28gRFdDMiBVU0IgT1RHIGNvcmVzLiBPbmUgY29yZSBpcyAN Cj4+Pj4+Pj4gVVNCDQo+Pj4+Pj4+IE9URyBGUyBhbmQgdGhlIG90aGVyIGlzIFVTQiBPVEcgSFMu IFRoZSBVU0IgRlMgY29yZSBvbmx5IHdvcmtzIA0KPj4+Pj4+PiB3aXRoIGl0cw0KPj4+Pj4+PiBp bnRlcm5hbCBwaHkgd2hpbHN0IHRoZSBVU0IgSFMgY29yZSBjYW4gd29yayBpbiBIUyB3aXRoIGV4 dGVybmFsIA0KPj4+Pj4+PiBVTFBJIHBoeQ0KPj4+Pj4+PiBvciBpbiBGUy9MUyB3aXRoIHRoZSBv bi1jaGlwIEZTIHBoeS4NCj4+Pj4+Pj4NCj4+Pj4+Pj4gQW1lbGllIERlbGF1bmF5ICg3KToNCj4+ Pj4+Pj4gwqDCoMKgwqAgZHQtYmluZGluZ3M6IHVzYjogRG9jdW1lbnQgdGhlIFNUTTMyRjcgRFdD MiBVU0IgT1RHIEhTIGNvcmUgDQo+Pj4+Pj4+IGJpbmRpbmcNCj4+Pj4+Pj4gwqDCoMKgwqAgdXNi OiBkd2MyOiBhZGQgc3VwcG9ydCBmb3IgU1RNMzJGNyBVU0IgT1RHIEhTDQo+Pj4+Pj4+IMKgwqDC oMKgIEFSTTogZHRzOiBzdG0zMjogQWRkIFVTQiBIUyBzdXBwb3J0IGZvciBTVE0zMkY3NDYgTUNV DQo+Pj4+Pj4NCj4+Pj4+PiBJIGhhdmUgYXBwbGllZCB0aGVzZSB0aHJlZSBwYXRjaGVzLiBTaG91 bGQgSSB0YWtlIHRoZSByZXN0PyBUaGV5IA0KPj4+Pj4+IHNlZW1zDQo+Pj4+Pj4gbGlrZSB0aGV5 IGNvdWxkIGdvIHVwc3RyZWFtIHRocm91Z2ggdGhlIEFSTSBtYWludGFpbmVycy4NCj4+Pj4+Pg0K Pj4+Pj4NCj4+Pj4+IEkgd2lsbCB0YWtlIG90aGVyIERUIHBhdGNoZXMgaW4gbXkgUFIuDQo+Pj4+ Pg0KPj4+Pj4gQ29uY2VybmluZyAiQVJNOiBkdHM6IHN0bTMyOiBBZGQgVVNCIEhTIHN1cHBvcnQg Zm9yIFNUTTMyRjc0NiBNQ1UiIA0KPj4+Pj4gcGF0Y2gNCj4+Pj4+IEkgcHJlZmVyIGFsc28gdG8g dGFrZSBpdC4gVGhpcyBwYXRjaCBhZGRzIHNvbWUgcGluY3RybCBncm91cHMgYnV0IA0KPj4+Pj4g c3RtMzINCj4+Pj4+IHBpbmN0cmwgYmluZGluZ3Mgd2lsbCBjaGFuZ2UgaW4gbXkgbmV4dCBQUiAo d2Ugd2lsbCB1c2UgYSBtYWNybyB0bw0KPj4+Pj4gZGVmaW5lIHBpbnMgaW5zdGVhZCBvZiB1c2lu ZyBkZWZpbmVkIHZhbHVlcykuIFNvIGlmIHlvdSBwdXNoIHRoZSBEVA0KPj4+Pj4gcGF0Y2ggdGhy b3VnaCB5b3VyIHB1bGwgcmVxdWVzdCB0aGVyZSB3aWxsIGJlIGEgbWVyZ2UgaXNzdWUuDQo+Pj4+ PiBJdCBpcyBwb3NzaWJsZSB0aGF0IEkgdGFrZSBhbHNvIHRoaXMgb25lID8NCj4+Pj4NCj4+Pj4g SW4gdGhhdCBjYXNlLCBpdCdzIGJlc3QgaWYgeW91IHRha2UgdGhlbSBhbGwgOi0pIEhlcmUncyBt eSBBY2s6DQo+Pj4+DQo+Pj4+IEFja2VkLWJ5OiBGZWxpcGUgQmFsYmkgPGZlbGlwZS5iYWxiaUBs aW51eC5pbnRlbC5jb20+DQo+Pj4+DQo+Pj4+IEknbGwgZHJvcCB0aGVtIGZyb20gbXkgdHJlZSBu b3cNCj4+Pg0KPj4+IE9rIHBlcmZlY3QsIEkgd2lsbCB0YWtlIERUIHBhdGNoZXMgKDMgdG8gNykg YW5kIEkgbGV0IHlvdSB0YWtlIHBhdGNoIDEmMg0KPj4+IGluIHlvdXIgdHJlZS4NCj4+DQo+PiBX ZWxsLCBJIGhhdmUgZHJvcHBlZCB0aGVtIGZyb20gbXkgdHJlZS4gUGxlYXNlIHR3byAxLTcgdGhy b3VnaCB5b3Vycy4NCj4gDQo+IEh1bSwgb2sgZm9yIHRoaXMgcGF0Y2hzZXQgYnV0IElNTyBpdCBp cyBiZXR0ZXIgKG5leHQgdGltZSkgdGhhdCB5b3UgdGFrZSANCj4gZHJpdmVyIHBhY3RoZXMgaW4g eW91ciB0cmVlIGFuZCBJIHRha2Ugb25seSBEVCBwYXRjaGVzIGluIG1pbmUuDQo+IE5vID8NCj4g DQo+IFJlZ2FyZHMNCj4gQWxleA0KPiANCj4+DQoNCkkgdGhvdWdodCB0aGF0IHBhdGNoZXMgMSBh bmQgMiwgYXMgdGhleSBhcmUgImRyaXZlciIgcGF0Y2hlcywgaGFkIHRvIGJlIA0KYXBwbGllZCBv biBVU0IgdHJlZSAoc28gRmVsaXBlJ3Mgb25lKSwgYW5kIHRoZSBvdGhlcnMgKDMgdG8gNykgaGFk IHRvIGJlIA0KYXBwbGllZCBvbiBTVE0zMi1EVCB0cmVlIChBbGV4J3Mgb25lKS4gRGlkIEkgbWlz cyBzb21ldGhpbmc/DQoNClJlZ2FyZHMsDQpBbWVsaWU= -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: amelie.delaunay@st.com (Amelie DELAUNAY) Date: Thu, 12 Oct 2017 08:32:49 +0000 Subject: [PATCHv2 0/7] Add support for USB OTG on STM32F7 In-Reply-To: <3c36db6d-75fd-1be6-e946-b75a04e3760e@st.com> References: <1503930018-536-1-git-send-email-amelie.delaunay@st.com> <878tgim24i.fsf@linux.intel.com> <04a49088-b615-d7b8-0387-e7bfa32ee19f@st.com> <87vajllx8t.fsf@linux.intel.com> <1c4180ef-2da6-b420-7c6e-41769608384a@st.com> <87sheplsrm.fsf@linux.intel.com> <3c36db6d-75fd-1be6-e946-b75a04e3760e@st.com> Message-ID: <21df4d0c-075c-0c5a-c39b-b1dd94fe819d@st.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Felipe, Alex, On 10/11/2017 04:38 PM, Alexandre Torgue wrote: > > > On 10/11/2017 03:26 PM, Felipe Balbi wrote: >> >> Hi, >> >> Alexandre Torgue writes: >>> Hi >>> >>> On 10/11/2017 01:50 PM, Felipe Balbi wrote: >>>> >>>> Hi, >>>> >>>> Alexandre Torgue writes: >>>>> Hi Felip >>>>> >>>>> On 10/11/2017 12:04 PM, Felipe Balbi wrote: >>>>>> >>>>>> Hi, >>>>>> >>>>>> Amelie Delaunay writes: >>>>>>> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is >>>>>>> USB >>>>>>> OTG FS and the other is USB OTG HS. The USB FS core only works >>>>>>> with its >>>>>>> internal phy whilst the USB HS core can work in HS with external >>>>>>> ULPI phy >>>>>>> or in FS/LS with the on-chip FS phy. >>>>>>> >>>>>>> Amelie Delaunay (7): >>>>>>> ???? dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core >>>>>>> binding >>>>>>> ???? usb: dwc2: add support for STM32F7 USB OTG HS >>>>>>> ???? ARM: dts: stm32: Add USB HS support for STM32F746 MCU >>>>>> >>>>>> I have applied these three patches. Should I take the rest? They >>>>>> seems >>>>>> like they could go upstream through the ARM maintainers. >>>>>> >>>>> >>>>> I will take other DT patches in my PR. >>>>> >>>>> Concerning "ARM: dts: stm32: Add USB HS support for STM32F746 MCU" >>>>> patch >>>>> I prefer also to take it. This patch adds some pinctrl groups but >>>>> stm32 >>>>> pinctrl bindings will change in my next PR (we will use a macro to >>>>> define pins instead of using defined values). So if you push the DT >>>>> patch through your pull request there will be a merge issue. >>>>> It is possible that I take also this one ? >>>> >>>> In that case, it's best if you take them all :-) Here's my Ack: >>>> >>>> Acked-by: Felipe Balbi >>>> >>>> I'll drop them from my tree now >>> >>> Ok perfect, I will take DT patches (3 to 7) and I let you take patch 1&2 >>> in your tree. >> >> Well, I have dropped them from my tree. Please two 1-7 through yours. > > Hum, ok for this patchset but IMO it is better (next time) that you take > driver pacthes in your tree and I take only DT patches in mine. > No ? > > Regards > Alex > >> I thought that patches 1 and 2, as they are "driver" patches, had to be applied on USB tree (so Felipe's one), and the others (3 to 7) had to be applied on STM32-DT tree (Alex's one). Did I miss something? Regards, Amelie