From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73652C64EC7 for ; Wed, 1 Mar 2023 07:45:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229530AbjCAHpw (ORCPT ); Wed, 1 Mar 2023 02:45:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229504AbjCAHpv (ORCPT ); Wed, 1 Mar 2023 02:45:51 -0500 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3D1E30EBD; Tue, 28 Feb 2023 23:45:50 -0800 (PST) Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3214kDML004417; Wed, 1 Mar 2023 07:45:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=aHnEMQp7evnRUr+B1+RiL92yYBTpDBHQfvhAmxs5KJo=; b=d28Sw1v/LVxPxblWN87yE2rYyFfQ68tBFCabTcl5Ikyv/nSRTT4pXyy7KvMi9bTc1iQy gcGAcd1n6Q+WVbgkFjiMp5PG15fltUgb+AHqts6pvkNVsoSBv8zX79T9lFra9FWKjuRQ KzRrG0RZ1VTwGGdOdazeZn3jyokHMp6X5hBoc9J+ix6t/HCkPVJZ+nesQm0tq1sKSHPQ ZraXSUqxml2TsUmYVyiwf8mR7cni/q7xHRjFQVQeHKhVEaihYUVKekykCGaTot8ZfhQg dsZFBQ1jKqj3yhb/fXOb3WK/FAKycAnp9CvevHf36A1WJ87lNX4BhuLJg57Hv9TkR+ky 2g== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3p1n0tj23n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 01 Mar 2023 07:45:34 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3217jX7x008244 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 1 Mar 2023 07:45:33 GMT Received: from [10.239.133.211] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 28 Feb 2023 23:45:28 -0800 Message-ID: <21ee7183-f661-f6dd-bcc2-c521003ae2ca@quicinc.com> Date: Wed, 1 Mar 2023 15:45:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [PATCH v2 5/9] coresight-tpdm: Add nodes to set trigger timestamp and type Content-Language: en-US To: Suzuki K Poulose , Mathieu Poirier , Alexander Shishkin , Konrad Dybcio , Mike Leach , Rob Herring , Krzysztof Kozlowski CC: Jinlong Mao , Leo Yan , "Greg Kroah-Hartman" , , , , , Tingwei Zhang , Yuanfang Zhang , Trilok Soni , Hao Zhang , , Tao Zhang , "Bjorn Andersson" References: <1674114105-16651-1-git-send-email-quic_taozha@quicinc.com> <1674114105-16651-6-git-send-email-quic_taozha@quicinc.com> From: Tao Zhang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: 52do2j87Ex7BqYhD7DlkbLtWk7bqIaIb X-Proofpoint-GUID: 52do2j87Ex7BqYhD7DlkbLtWk7bqIaIb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-01_04,2023-02-28_03,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 phishscore=0 malwarescore=0 adultscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 mlxscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2303010061 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Suzuki, 在 2/28/2023 7:32 PM, Suzuki K Poulose 写道: > On 19/01/2023 07:41, Tao Zhang wrote: >> The nodes are needed to set or show the trigger timestamp and >> trigger type. This change is to add these nodes to achieve these >> function. >> >> Signed-off-by: Tao Zhang >> Signed-off-by: Tao Zhang >> --- >>   drivers/hwtracing/coresight/coresight-tpdm.c | 97 >> ++++++++++++++++++++++++++++ >>   1 file changed, 97 insertions(+) >> >> diff --git a/drivers/hwtracing/coresight/coresight-tpdm.c >> b/drivers/hwtracing/coresight/coresight-tpdm.c >> index c29d667d..1dbb6c4 100644 >> --- a/drivers/hwtracing/coresight/coresight-tpdm.c >> +++ b/drivers/hwtracing/coresight/coresight-tpdm.c >> @@ -20,6 +20,22 @@ > > >> +static struct attribute *tpdm_dsb_attrs[] = { >> +    &dev_attr_dsb_trig_ts.attr, >> +    &dev_attr_dsb_trig_type.attr, >> +    NULL, >> +}; >> + >> +static struct attribute_group tpdm_dsb_attr_grp = { >> +    .attrs = tpdm_dsb_attrs, >> +    .is_visible = tpdm_dsb_is_visible, >> +}; >> + >>   static const struct attribute_group *tpdm_attr_grps[] = { >>       &tpdm_attr_grp, >> +    &tpdm_dsb_attr_grp, >>       NULL, >>   }; > > > Please also add documentation of the new sysfs handles under : > > Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm* > Sure, I will add the descriptions of new sysfs in the next of patch series. > Suzuki > Best, Tao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D93EAC64ED6 for ; Wed, 1 Mar 2023 07:46:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nxp7p2asqYsvPleMNJfw0vpoJlWSq0wzClbXamuoDfk=; b=GC8paLPD6pi7NB PC9OuVkQ/tTRuVYXIoINvAIb8yuQKzw7QvEZ5ks/aBJt7dsa+hQK3/bIveqOX0alv9f5evBq4awWE IrP8NWqiCNXc4INrrpPDICJhjd1WPfBFSs4KxufZ7FrbsuxQ6XdwxRLtuXwZXdKQKyQb4wc1kZu7m DjA3IG2mW5NRcgX966ZkLJpD0lTbEQEIWGIjJhe4LJIy6mwymQHjnAVIV4EiCof97JQWco2F+qm1x 1VRBnHnLD52HbrK5XEk0g6PvCotBTr+GEgBCHWcanGALNpFdwArdl8hqMmsraE9Sz5m/m4lMlwtPx 79QX0DNIzuW3AwdPa2QQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pXH9q-00FMUY-VL; Wed, 01 Mar 2023 07:45:51 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pXH9m-00FMTe-PL for linux-arm-kernel@lists.infradead.org; Wed, 01 Mar 2023 07:45:49 +0000 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3214kDML004417; Wed, 1 Mar 2023 07:45:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=aHnEMQp7evnRUr+B1+RiL92yYBTpDBHQfvhAmxs5KJo=; b=d28Sw1v/LVxPxblWN87yE2rYyFfQ68tBFCabTcl5Ikyv/nSRTT4pXyy7KvMi9bTc1iQy gcGAcd1n6Q+WVbgkFjiMp5PG15fltUgb+AHqts6pvkNVsoSBv8zX79T9lFra9FWKjuRQ KzRrG0RZ1VTwGGdOdazeZn3jyokHMp6X5hBoc9J+ix6t/HCkPVJZ+nesQm0tq1sKSHPQ ZraXSUqxml2TsUmYVyiwf8mR7cni/q7xHRjFQVQeHKhVEaihYUVKekykCGaTot8ZfhQg dsZFBQ1jKqj3yhb/fXOb3WK/FAKycAnp9CvevHf36A1WJ87lNX4BhuLJg57Hv9TkR+ky 2g== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3p1n0tj23n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 01 Mar 2023 07:45:34 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3217jX7x008244 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 1 Mar 2023 07:45:33 GMT Received: from [10.239.133.211] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 28 Feb 2023 23:45:28 -0800 Message-ID: <21ee7183-f661-f6dd-bcc2-c521003ae2ca@quicinc.com> Date: Wed, 1 Mar 2023 15:45:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [PATCH v2 5/9] coresight-tpdm: Add nodes to set trigger timestamp and type Content-Language: en-US To: Suzuki K Poulose , Mathieu Poirier , Alexander Shishkin , Konrad Dybcio , Mike Leach , Rob Herring , Krzysztof Kozlowski CC: Jinlong Mao , Leo Yan , "Greg Kroah-Hartman" , , , , , Tingwei Zhang , Yuanfang Zhang , Trilok Soni , Hao Zhang , , Tao Zhang , "Bjorn Andersson" References: <1674114105-16651-1-git-send-email-quic_taozha@quicinc.com> <1674114105-16651-6-git-send-email-quic_taozha@quicinc.com> From: Tao Zhang In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: 52do2j87Ex7BqYhD7DlkbLtWk7bqIaIb X-Proofpoint-GUID: 52do2j87Ex7BqYhD7DlkbLtWk7bqIaIb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-01_04,2023-02-28_03,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 phishscore=0 malwarescore=0 adultscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 mlxscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2303010061 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230228_234546_957740_8F606DC5 X-CRM114-Status: GOOD ( 17.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgU3V6dWtpLAoK5ZyoIDIvMjgvMjAyMyA3OjMyIFBNLCBTdXp1a2kgSyBQb3Vsb3NlIOWGmemB kzoKPiBPbiAxOS8wMS8yMDIzIDA3OjQxLCBUYW8gWmhhbmcgd3JvdGU6Cj4+IFRoZSBub2RlcyBh cmUgbmVlZGVkIHRvIHNldCBvciBzaG93IHRoZSB0cmlnZ2VyIHRpbWVzdGFtcCBhbmQKPj4gdHJp Z2dlciB0eXBlLiBUaGlzIGNoYW5nZSBpcyB0byBhZGQgdGhlc2Ugbm9kZXMgdG8gYWNoaWV2ZSB0 aGVzZQo+PiBmdW5jdGlvbi4KPj4KPj4gU2lnbmVkLW9mZi1ieTogVGFvIFpoYW5nIDxxdWljX3Rh b3poYUBxdWljaW5jLmNvbT4KPj4gU2lnbmVkLW9mZi1ieTogVGFvIFpoYW5nIDx0YW96aGFAcXRp LnF1YWxjb21tLmNvbT4KPj4gLS0tCj4+IMKgIGRyaXZlcnMvaHd0cmFjaW5nL2NvcmVzaWdodC9j b3Jlc2lnaHQtdHBkbS5jIHwgOTcgCj4+ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysKPj4g wqAgMSBmaWxlIGNoYW5nZWQsIDk3IGluc2VydGlvbnMoKykKPj4KPj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvaHd0cmFjaW5nL2NvcmVzaWdodC9jb3Jlc2lnaHQtdHBkbS5jIAo+PiBiL2RyaXZlcnMv aHd0cmFjaW5nL2NvcmVzaWdodC9jb3Jlc2lnaHQtdHBkbS5jCj4+IGluZGV4IGMyOWQ2NjdkLi4x ZGJiNmM0IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2h3dHJhY2luZy9jb3Jlc2lnaHQvY29yZXNp Z2h0LXRwZG0uYwo+PiArKysgYi9kcml2ZXJzL2h3dHJhY2luZy9jb3Jlc2lnaHQvY29yZXNpZ2h0 LXRwZG0uYwo+PiBAQCAtMjAsNiArMjAsMjIgQEAKPgo+Cj4+ICtzdGF0aWMgc3RydWN0IGF0dHJp YnV0ZSAqdHBkbV9kc2JfYXR0cnNbXSA9IHsKPj4gK8KgwqDCoCAmZGV2X2F0dHJfZHNiX3RyaWdf dHMuYXR0ciwKPj4gK8KgwqDCoCAmZGV2X2F0dHJfZHNiX3RyaWdfdHlwZS5hdHRyLAo+PiArwqDC oMKgIE5VTEwsCj4+ICt9Owo+PiArCj4+ICtzdGF0aWMgc3RydWN0IGF0dHJpYnV0ZV9ncm91cCB0 cGRtX2RzYl9hdHRyX2dycCA9IHsKPj4gK8KgwqDCoCAuYXR0cnMgPSB0cGRtX2RzYl9hdHRycywK Pj4gK8KgwqDCoCAuaXNfdmlzaWJsZSA9IHRwZG1fZHNiX2lzX3Zpc2libGUsCj4+ICt9Owo+PiAr Cj4+IMKgIHN0YXRpYyBjb25zdCBzdHJ1Y3QgYXR0cmlidXRlX2dyb3VwICp0cGRtX2F0dHJfZ3Jw c1tdID0gewo+PiDCoMKgwqDCoMKgICZ0cGRtX2F0dHJfZ3JwLAo+PiArwqDCoMKgICZ0cGRtX2Rz Yl9hdHRyX2dycCwKPj4gwqDCoMKgwqDCoCBOVUxMLAo+PiDCoCB9Owo+Cj4KPiBQbGVhc2UgYWxz byBhZGQgZG9jdW1lbnRhdGlvbiBvZiB0aGUgbmV3IHN5c2ZzIGhhbmRsZXMgdW5kZXIgOgo+Cj4g RG9jdW1lbnRhdGlvbi9BQkkvdGVzdGluZy9zeXNmcy1idXMtY29yZXNpZ2h0LWRldmljZXMtdHBk bSoKPgpTdXJlLCBJIHdpbGwgYWRkIHRoZSBkZXNjcmlwdGlvbnMgb2YgbmV3IHN5c2ZzIGluIHRo ZSBuZXh0IG9mIHBhdGNoIHNlcmllcy4KPiBTdXp1a2kKPgpCZXN0LAoKVGFvCgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBt YWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=