From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [OSSTest Nested v12 05/21] Honour
	$xopts{ExtraConfig} and use it to enable nestedhvm
Date: Thu, 10 Sep 2015 17:26:42 +0100
Message-ID: <22001.44866.395009.391372@mariner.uk.xensource.com>
References: <1440774490-16725-1-git-send-email-robert.hu@intel.com>
	<1440774490-16725-6-git-send-email-robert.hu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1440774490-16725-6-git-send-email-robert.hu@intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Robert Ho <robert.hu@intel.com>
Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, gordon.jin@intel.com, di.zheng@intel.com
List-Id: xen-devel@lists.xenproject.org

Robert Ho writes ("[OSSTest Nested v12 05/21] Honour $xopts{ExtraConfig} and use it to enable nestedhvm"):

Your summary line says `Honour $xopts{ExtraConfig}' but I think this
was actually done in 2011 in dc801db7 "Osstest: prepareguest: honour
xopt ExtraConfig".

I think this patch honours the enable_nestedhvm guest setting, ie the
runvar GUEST_enable_nestedhvm or enable_nestedhvm.

Having thought about this, I think it would be better if the guest var
were called `nestedhvm_enable'.  Sorry to ask for this change now, but
could you change that please (and the corresponding later parts that
set it, of course) ?

> +    my $extra_config = '';
> +    $extra_config .= "nestedhvm=1\n"
> +        if guest_var($gho,"enable_nestedhvm",'false') =~ m/true/;

This should use guest_var_boolean (which I think was probably
introduced after you wrote this code).

Thanks,
Ian.