From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: Re: [OSSTest Nested v12 09/21] Wrapper and use core_dump_setup() for nested host and normal host to setup coredump sysctl Date: Thu, 10 Sep 2015 18:23:23 +0100 Message-ID: <22001.48267.819147.220179@mariner.uk.xensource.com> References: <1440774490-16725-1-git-send-email-robert.hu@intel.com> <1440774490-16725-10-git-send-email-robert.hu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1440774490-16725-10-git-send-email-robert.hu@intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Robert Ho Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, xen-devel@lists.xen.org, gordon.jin@intel.com, "longtao.pang" , di.zheng@intel.com List-Id: xen-devel@lists.xenproject.org Robert Ho writes ("[OSSTest Nested v12 09/21] Wrapper and use core_dump_setup() for nested host and normal host to setup coredump sysctl"): > This patch does these 4 things: > 1. wrapper coredump setup code from original ts-host-install into TestSupport.pm > 2. replace ts-host-install original code with this wrapper function You mean break coredump setup code into new function `core_dump_setup' Please break this part (the refactoring - ie points 1,2) out into its own patch. You can then say `no functional change' (assuming that's true). > 3. in debian-hvm-install, create '/var/core' in hvm host post installation. > 4. in ts-nested-setup, call this function for l1 host. Is there some reason why the mkdir isn't done in core_dump_setup ? I think it is somewhat illogical that the /var/core should be (implicitly) used in ts-nested-setup but created in debian-hvm-install. Also it should do `mkdir -p' in case the directory already exists somehow. Thanks, Ian.