From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 1/3] drm/amdgpu: change pointer of mqd_ptr to void Date: Thu, 16 Feb 2017 10:16:15 +0100 Message-ID: <220014f3-9d36-95e8-58cf-f504c0a0588a@vodafone.de> References: <1487229920-4897-1-git-send-email-Xiangliang.Yu@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1487229920-4897-1-git-send-email-Xiangliang.Yu-5C7GfCeVMHo@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Xiangliang Yu , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org QW0gMTYuMDIuMjAxNyB1bSAwODoyNSBzY2hyaWViIFhpYW5nbGlhbmcgWXU6Cj4gdmlfbXFkIGlz IG9ubHkgdXNlZCBieSBWSSBmYW1pbHkgYnV0IG1xZF9wdHIgaXMgY29tbW9uIGZvciBhbGwKPiBB U0lDLCBzbyBjaGFuZ2UgdGhlIHBvaW50ZXIgdG8gdm9pZC4KPgo+IFNpZ25lZC1vZmYtYnk6IFhp YW5nbGlhbmcgWXUgPFhpYW5nbGlhbmcuWXVAYW1kLmNvbT4KCk5pY2UgY2xlYW51cCwgcGF0Y2gg aXMgUmV2aWV3ZWQtYnk6IENocmlzdGlhbiBLw7ZuaWcgCjxjaHJpc3RpYW4ua29lbmlnQGFtZC5j b20+LgoKUGF0Y2ggIzIgYW5kICMzIGFyZSBBY2tlZC1ieTogQ2hyaXN0aWFuIEvDtm5pZyA8Y2hy aXN0aWFuLmtvZW5pZ0BhbWQuY29tPi4KClJlZ2FyZHMsCkNocmlzdGlhbi4KCj4gLS0tCj4gICBk cml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfcmluZy5oIHwgIDIgKy0KPiAgIGRyaXZl cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2dmeF92OF8wLmMgICAgfCAyNiArKysrKysrKysrKysrKysr Ky0tLS0tLS0tLQo+ICAgMiBmaWxlcyBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCAxMCBkZWxl dGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRn cHVfcmluZy5oIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3JpbmcuaAo+IGlu ZGV4IDNmZDRjZTguLmExYmZjNGUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9h bWRncHUvYW1kZ3B1X3JpbmcuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2Ft ZGdwdV9yaW5nLmgKPiBAQCAtMTYyLDcgKzE2Miw3IEBAIHN0cnVjdCBhbWRncHVfcmluZyB7Cj4g ICAJdTMyCQkJcXVldWU7Cj4gICAJc3RydWN0IGFtZGdwdV9ibwkqbXFkX29iajsKPiAgIAl1aW50 NjRfdCAgICAgICAgICAgICAgICBtcWRfZ3B1X2FkZHI7Cj4gLQlzdHJ1Y3QgdmlfbXFkICAgICAg ICAgICAqbXFkX3B0cjsKPiArCXZvaWQgICAgICAgICAgICAgICAgICAgICptcWRfcHRyOwo+ICAg CXUzMgkJCWRvb3JiZWxsX2luZGV4Owo+ICAgCWJvb2wJCQl1c2VfZG9vcmJlbGw7Cj4gICAJdW5z aWduZWQJCXdwdHJfb2ZmczsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn cHUvZ2Z4X3Y4XzAuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2dmeF92OF8wLmMKPiBp bmRleCA3NzJjNDJiLi4yMjAyZjAyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1L2dmeF92OF8wLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9nZnhf djhfMC5jCj4gQEAgLTQ5NDAsOCArNDk0MCwxMCBAQCBzdGF0aWMgaW50IGdmeF92OF8wX2tpcV9y ZXN1bWUoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYpCj4gICAJZ2Z4X3Y4XzBfY3BfY29tcHV0 ZV9lbmFibGUoYWRldiwgdHJ1ZSk7Cj4gICAKPiAgIAlyaW5nID0gJmFkZXYtPmdmeC5raXEucmlu ZzsKPiAtCWlmICghYW1kZ3B1X2JvX2ttYXAocmluZy0+bXFkX29iaiwgKHZvaWQgKiopJnJpbmct Pm1xZF9wdHIpKSB7Cj4gLQkJciA9IGdmeF92OF8wX2tpcV9pbml0X3F1ZXVlKHJpbmcsIHJpbmct Pm1xZF9wdHIsIHJpbmctPm1xZF9ncHVfYWRkcik7Cj4gKwlpZiAoIWFtZGdwdV9ib19rbWFwKHJp bmctPm1xZF9vYmosICZyaW5nLT5tcWRfcHRyKSkgewo+ICsJCXIgPSBnZnhfdjhfMF9raXFfaW5p dF9xdWV1ZShyaW5nLAo+ICsJCQkJCSAgICAoc3RydWN0IHZpX21xZCAqKXJpbmctPm1xZF9wdHIs Cj4gKwkJCQkJICAgIHJpbmctPm1xZF9ncHVfYWRkcik7Cj4gICAJCWFtZGdwdV9ib19rdW5tYXAo cmluZy0+bXFkX29iaik7Cj4gICAJCXJpbmctPm1xZF9wdHIgPSBOVUxMOwo+ICAgCQlpZiAocikK PiBAQCAtNDk1Miw4ICs0OTU0LDEwIEBAIHN0YXRpYyBpbnQgZ2Z4X3Y4XzBfa2lxX3Jlc3VtZShz dHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldikKPiAgIAo+ICAgCWZvciAoaSA9IDA7IGkgPCBhZGV2 LT5nZngubnVtX2NvbXB1dGVfcmluZ3M7IGkrKykgewo+ICAgCQlyaW5nID0gJmFkZXYtPmdmeC5j b21wdXRlX3JpbmdbaV07Cj4gLQkJaWYgKCFhbWRncHVfYm9fa21hcChyaW5nLT5tcWRfb2JqLCAo dm9pZCAqKikmcmluZy0+bXFkX3B0cikpIHsKPiAtCQkJciA9IGdmeF92OF8wX2tpcV9pbml0X3F1 ZXVlKHJpbmcsIHJpbmctPm1xZF9wdHIsIHJpbmctPm1xZF9ncHVfYWRkcik7Cj4gKwkJaWYgKCFh bWRncHVfYm9fa21hcChyaW5nLT5tcWRfb2JqLCAmcmluZy0+bXFkX3B0cikpIHsKPiArCQkJciA9 IGdmeF92OF8wX2tpcV9pbml0X3F1ZXVlKHJpbmcsCj4gKwkJCQkJCSAgICAoc3RydWN0IHZpX21x ZCAqKXJpbmctPm1xZF9wdHIsCj4gKwkJCQkJCSAgICByaW5nLT5tcWRfZ3B1X2FkZHIpOwo+ICAg CQkJYW1kZ3B1X2JvX2t1bm1hcChyaW5nLT5tcWRfb2JqKTsKPiAgIAkJCXJpbmctPm1xZF9wdHIg PSBOVUxMOwo+ICAgCQkJaWYgKHIpCj4gQEAgLTczMzMsNyArNzMzNyw3IEBAIHN0YXRpYyBpbnQg Z2Z4X3Y4XzBfY29tcHV0ZV9tcWRfc29mdF9pbml0KHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2 KQo+ICAgCWlmICghcmluZy0+bXFkX29iaikgewo+ICAgCQlyID0gYW1kZ3B1X2JvX2NyZWF0ZV9r ZXJuZWwoYWRldiwgc2l6ZW9mKHN0cnVjdCB2aV9tcWQpLCBQQUdFX1NJWkUsCj4gICAJCQkJCQlB TURHUFVfR0VNX0RPTUFJTl9HVFQsICZyaW5nLT5tcWRfb2JqLAo+IC0JCQkJCQkmcmluZy0+bXFk X2dwdV9hZGRyLCAodm9pZCAqKikmcmluZy0+bXFkX3B0cik7Cj4gKwkJCQkJCSZyaW5nLT5tcWRf Z3B1X2FkZHIsICZyaW5nLT5tcWRfcHRyKTsKPiAgIAkJaWYgKHIpIHsKPiAgIAkJCWRldl93YXJu KGFkZXYtPmRldiwgImZhaWxlZCB0byBjcmVhdGUgcmluZyBtcWQgb2IgKCVkKSIsIHIpOwo+ICAg CQkJcmV0dXJuIHI7Cj4gQEAgLTczNTIsNyArNzM1Niw3IEBAIHN0YXRpYyBpbnQgZ2Z4X3Y4XzBf Y29tcHV0ZV9tcWRfc29mdF9pbml0KHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2KQo+ICAgCQlp ZiAoIXJpbmctPm1xZF9vYmopIHsKPiAgIAkJCXIgPSBhbWRncHVfYm9fY3JlYXRlX2tlcm5lbChh ZGV2LCBzaXplb2Yoc3RydWN0IHZpX21xZCksIFBBR0VfU0laRSwKPiAgIAkJCQkJCQlBTURHUFVf R0VNX0RPTUFJTl9HVFQsICZyaW5nLT5tcWRfb2JqLAo+IC0JCQkJCQkJJnJpbmctPm1xZF9ncHVf YWRkciwgKHZvaWQgKiopJnJpbmctPm1xZF9wdHIpOwo+ICsJCQkJCQkJJnJpbmctPm1xZF9ncHVf YWRkciwgJnJpbmctPm1xZF9wdHIpOwo+ICAgCQkJaWYgKHIpIHsKPiAgIAkJCQlkZXZfd2Fybihh ZGV2LT5kZXYsICJmYWlsZWQgdG8gY3JlYXRlIHJpbmcgbXFkIG9iICglZCkiLCByKTsKPiAgIAkJ CQlyZXR1cm4gcjsKPiBAQCAtNzM3NSw5ICs3Mzc5LDEzIEBAIHN0YXRpYyB2b2lkIGdmeF92OF8w X2NvbXB1dGVfbXFkX3NvZnRfZmluaShzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldikKPiAgIAo+ ICAgCWZvciAoaSA9IDA7IGkgPCBhZGV2LT5nZngubnVtX2NvbXB1dGVfcmluZ3M7IGkrKykgewo+ ICAgCQlyaW5nID0gJmFkZXYtPmdmeC5jb21wdXRlX3JpbmdbaV07Cj4gLQkJYW1kZ3B1X2JvX2Zy ZWVfa2VybmVsKCZyaW5nLT5tcWRfb2JqLCAmcmluZy0+bXFkX2dwdV9hZGRyLCAodm9pZCAqKikm cmluZy0+bXFkX3B0cik7Cj4gKwkJYW1kZ3B1X2JvX2ZyZWVfa2VybmVsKCZyaW5nLT5tcWRfb2Jq LAo+ICsJCQkJICAgICAgJnJpbmctPm1xZF9ncHVfYWRkciwKPiArCQkJCSAgICAgICZyaW5nLT5t cWRfcHRyKTsKPiAgIAl9Cj4gICAKPiAgIAlyaW5nID0gJmFkZXYtPmdmeC5raXEucmluZzsKPiAt CWFtZGdwdV9ib19mcmVlX2tlcm5lbCgmcmluZy0+bXFkX29iaiwgJnJpbmctPm1xZF9ncHVfYWRk ciwgKHZvaWQgKiopJnJpbmctPm1xZF9wdHIpOwo+IC19Cj4gXCBObyBuZXdsaW5lIGF0IGVuZCBv ZiBmaWxlCj4gKwlhbWRncHVfYm9fZnJlZV9rZXJuZWwoJnJpbmctPm1xZF9vYmosCj4gKwkJCSAg ICAgICZyaW5nLT5tcWRfZ3B1X2FkZHIsCj4gKwkJCSAgICAgICZyaW5nLT5tcWRfcHRyKTsKPiAr fQoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1n ZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo=