From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [OSSTest Nested v12 20/21] Don't lvextend if
	actually no more space to extend
Date: Wed, 16 Sep 2015 15:27:39 +0100
Message-ID: <22009.31835.658085.403421@mariner.uk.xensource.com>
References: <1440774490-16725-1-git-send-email-robert.hu@intel.com>
	<1440774490-16725-21-git-send-email-robert.hu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1440774490-16725-21-git-send-email-robert.hu@intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Robert Ho <robert.hu@intel.com>
Cc: gordon.jin@intel.com, wei.liu2@citrix.com, ian.campbell@citrix.com, di.zheng@intel.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

Robert Ho writes ("[OSSTest Nested v12 20/21] Don't lvextend if actually no more space to extend"):
> Though passes if judgement, the
> 	overall_limit_pe(\$vg_more_free_pe);
> may final judge no more free_pe to extend.
> So, check if $vg_more_free_pe is 0, if so, we don't lvextend,
> otherwise lvextend will report error on nonsense operation.

I think this should be done by moving the start of the if block to
after overall_limit_pe.  That would avoid a tested if (and various
other slight anomalies).

Thanks,
Ian.