From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932655AbdELLB6 (ORCPT ); Fri, 12 May 2017 07:01:58 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:36634 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757644AbdELLBu (ORCPT ); Fri, 12 May 2017 07:01:50 -0400 From: Laurent Pinchart To: Archit Taneja Cc: dri-devel@lists.freedesktop.org, Jose Abreu , Daniel Vetter , Alexey Brodkin , linux-kernel@vger.kernel.org, Carlos Palminha Subject: Re: [PATCH v2 6/8] drm: Introduce drm_bridge_mode_valid() Date: Fri, 12 May 2017 14:01:49 +0300 Message-ID: <2203839.UYlrXxpDjl@avalon> User-Agent: KMail/4.14.10 (Linux/4.9.16-gentoo; KDE/4.14.29; x86_64; ; ) In-Reply-To: References: <1645078.FS6fmucJTb@avalon> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v4CB2HTF008835 Hi Archit, On Friday 12 May 2017 16:20:07 Archit Taneja wrote: > On 05/12/2017 03:08 PM, Laurent Pinchart wrote: > > On Wednesday 10 May 2017 17:14:33 Daniel Vetter wrote: > >> On Wed, May 10, 2017 at 04:41:09PM +0300, Ville Syrjälä wrote: > >>> On Tue, May 09, 2017 at 06:00:13PM +0100, Jose Abreu wrote: > >>>> Introduce a new helper function which calls mode_valid() callback > >>>> for all bridges in an encoder chain. > >>>> > >>>> Signed-off-by: Jose Abreu > >>>> Cc: Carlos Palminha > >>>> Cc: Alexey Brodkin > >>>> Cc: Ville Syrjälä > >>>> Cc: Daniel Vetter > >>>> Cc: Dave Airlie > >>>> Cc: Andrzej Hajda > >>>> Cc: Archit Taneja > >>>> --- > >>>> > >>>> drivers/gpu/drm/drm_bridge.c | 33 +++++++++++++++++++++++++++++++++ > >>>> include/drm/drm_bridge.h | 2 ++ > >>>> 2 files changed, 35 insertions(+) > >>>> > >>>> diff --git a/drivers/gpu/drm/drm_bridge.c > >>>> b/drivers/gpu/drm/drm_bridge.c > >>>> index 86a7637..dc8cdfe 100644 > >>>> --- a/drivers/gpu/drm/drm_bridge.c > >>>> +++ b/drivers/gpu/drm/drm_bridge.c > >>>> @@ -206,6 +206,39 @@ bool drm_bridge_mode_fixup(struct drm_bridge > >>>> *bridge, > >>>> > >>>> EXPORT_SYMBOL(drm_bridge_mode_fixup); > >>>> > >>>> /** > >>>> > >>>> + * drm_bridge_mode_valid - validate the mode against all bridges in > >>>> the > >>>> + * encoder chain. > >>>> + * @bridge: bridge control structure > >>>> + * @mode: desired mode to be validated > >>>> + * > >>>> + * Calls &drm_bridge_funcs.mode_valid for all the bridges in the > >>>> encoder > >>>> + * chain, starting from the first bridge to the last. If at least one > >>>> bridge + * does not accept the mode the function returns the error > >>>> code. > >>>> + * > >>>> + * Note: the bridge passed should be the one closest to the encoder. > >>>> + * > >>>> + * RETURNS: > >>>> + * MODE_OK on success, drm_mode_status Enum error code on failure > >>>> + */ > >>>> +enum drm_mode_status drm_bridge_mode_valid(struct drm_bridge *bridge, > >>>> + const struct drm_display_mode > > > > *mode) > > > >>>> +{ > >>>> + enum drm_mode_status ret = MODE_OK; > >>>> + > >>>> + if (!bridge) > >>>> + return ret; > >>>> + > >>>> + if (bridge->funcs->mode_valid) > >>>> + ret = bridge->funcs->mode_valid(bridge, mode); > >>>> + > >>>> + if (ret != MODE_OK) > >>>> + return ret; > >>>> + > >>>> + return drm_bridge_mode_valid(bridge->next, mode); > >>> > >>> Looks like it should be pretty trivial to avoid the recursion. > >>> > >>> Am I correct in interpreting this that bridges have some kind of > >>> a hand rolled linked list implementation? Reusing the standard > >>> linked lists would allow you to use list_for_each() etc. > >> > >> Yeah it's a hand-rolled list, but current hw also has a bridge nesting > >> depth of 2, so it really doesn't matter. I guess once we have real long > >> chains of bridges we can fix this (and just using list_head sounds like a > >> great idea). > > > > Even if not really needed right now, it's a pretty easy cleanup, if Jose > > has time to handle it in v3 of this series let's not postpone it ;-) > > jfyi, some of the bridge functions call the ops from the last bridge in the > chain to first, so we'd need to use list_for_each_entry_prev() (or something > like that) for them. And now that I think about it, for some of the operations (especially enable/disable) I believe that the bridge should be able to decide whether to call the next/previous bridge first or to configure its hardware first. I can image bridges that need the previous bridge in the chain to provide a valid clock before they get started, as well as bridges that need to be started with the incoming video signal stopped. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2 6/8] drm: Introduce drm_bridge_mode_valid() Date: Fri, 12 May 2017 14:01:49 +0300 Message-ID: <2203839.UYlrXxpDjl@avalon> References: <1645078.FS6fmucJTb@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 341C56E6A1 for ; Fri, 12 May 2017 11:01:49 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Archit Taneja Cc: Jose Abreu , Daniel Vetter , Alexey Brodkin , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Carlos Palminha List-Id: dri-devel@lists.freedesktop.org SGkgQXJjaGl0LAoKT24gRnJpZGF5IDEyIE1heSAyMDE3IDE2OjIwOjA3IEFyY2hpdCBUYW5lamEg d3JvdGU6Cj4gT24gMDUvMTIvMjAxNyAwMzowOCBQTSwgTGF1cmVudCBQaW5jaGFydCB3cm90ZToK PiA+IE9uIFdlZG5lc2RheSAxMCBNYXkgMjAxNyAxNzoxNDozMyBEYW5pZWwgVmV0dGVyIHdyb3Rl Ogo+ID4+IE9uIFdlZCwgTWF5IDEwLCAyMDE3IGF0IDA0OjQxOjA5UE0gKzAzMDAsIFZpbGxlIFN5 cmrDpGzDpCB3cm90ZToKPiA+Pj4gT24gVHVlLCBNYXkgMDksIDIwMTcgYXQgMDY6MDA6MTNQTSAr MDEwMCwgSm9zZSBBYnJldSB3cm90ZToKPiA+Pj4+IEludHJvZHVjZSBhIG5ldyBoZWxwZXIgZnVu Y3Rpb24gd2hpY2ggY2FsbHMgbW9kZV92YWxpZCgpIGNhbGxiYWNrCj4gPj4+PiBmb3IgYWxsIGJy aWRnZXMgaW4gYW4gZW5jb2RlciBjaGFpbi4KPiA+Pj4+IAo+ID4+Pj4gU2lnbmVkLW9mZi1ieTog Sm9zZSBBYnJldSA8am9hYnJldUBzeW5vcHN5cy5jb20+Cj4gPj4+PiBDYzogQ2FybG9zIFBhbG1p bmhhIDxwYWxtaW5oYUBzeW5vcHN5cy5jb20+Cj4gPj4+PiBDYzogQWxleGV5IEJyb2RraW4gPGFi cm9ka2luQHN5bm9wc3lzLmNvbT4KPiA+Pj4+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5 cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4+Pj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52 ZXR0ZXJAZmZ3bGwuY2g+Cj4gPj4+PiBDYzogRGF2ZSBBaXJsaWUgPGFpcmxpZWRAbGludXguaWU+ Cj4gPj4+PiBDYzogQW5kcnplaiBIYWpkYSA8YS5oYWpkYUBzYW1zdW5nLmNvbT4KPiA+Pj4+IENj OiBBcmNoaXQgVGFuZWphIDxhcmNoaXR0QGNvZGVhdXJvcmEub3JnPgo+ID4+Pj4gLS0tCj4gPj4+ PiAKPiA+Pj4+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2JyaWRnZS5jIHwgMzMgKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrCj4gPj4+PiAgaW5jbHVkZS9kcm0vZHJtX2JyaWRnZS5oICAg ICB8ICAyICsrCj4gPj4+PiAgMiBmaWxlcyBjaGFuZ2VkLCAzNSBpbnNlcnRpb25zKCspCj4gPj4+ PiAKPiA+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2JyaWRnZS5jCj4gPj4+ PiBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYnJpZGdlLmMKPiA+Pj4+IGluZGV4IDg2YTc2MzcuLmRj OGNkZmUgMTAwNjQ0Cj4gPj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2JyaWRnZS5jCj4g Pj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2JyaWRnZS5jCj4gPj4+PiBAQCAtMjA2LDYg KzIwNiwzOSBAQCBib29sIGRybV9icmlkZ2VfbW9kZV9maXh1cChzdHJ1Y3QgZHJtX2JyaWRnZQo+ ID4+Pj4gKmJyaWRnZSwKPiA+Pj4+IAo+ID4+Pj4gIEVYUE9SVF9TWU1CT0woZHJtX2JyaWRnZV9t b2RlX2ZpeHVwKTsKPiA+Pj4+ICAKPiA+Pj4+ICAvKioKPiA+Pj4+IAo+ID4+Pj4gKyAqIGRybV9i cmlkZ2VfbW9kZV92YWxpZCAtIHZhbGlkYXRlIHRoZSBtb2RlIGFnYWluc3QgYWxsIGJyaWRnZXMg aW4KPiA+Pj4+IHRoZQo+ID4+Pj4gKyAqIAkJCSAgIGVuY29kZXIgY2hhaW4uCj4gPj4+PiArICog QGJyaWRnZTogYnJpZGdlIGNvbnRyb2wgc3RydWN0dXJlCj4gPj4+PiArICogQG1vZGU6IGRlc2ly ZWQgbW9kZSB0byBiZSB2YWxpZGF0ZWQKPiA+Pj4+ICsgKgo+ID4+Pj4gKyAqIENhbGxzICZkcm1f YnJpZGdlX2Z1bmNzLm1vZGVfdmFsaWQgZm9yIGFsbCB0aGUgYnJpZGdlcyBpbiB0aGUKPiA+Pj4+ IGVuY29kZXIKPiA+Pj4+ICsgKiBjaGFpbiwgc3RhcnRpbmcgZnJvbSB0aGUgZmlyc3QgYnJpZGdl IHRvIHRoZSBsYXN0LiBJZiBhdCBsZWFzdCBvbmUKPiA+Pj4+IGJyaWRnZSArICogZG9lcyBub3Qg YWNjZXB0IHRoZSBtb2RlIHRoZSBmdW5jdGlvbiByZXR1cm5zIHRoZSBlcnJvcgo+ID4+Pj4gY29k ZS4KPiA+Pj4+ICsgKgo+ID4+Pj4gKyAqIE5vdGU6IHRoZSBicmlkZ2UgcGFzc2VkIHNob3VsZCBi ZSB0aGUgb25lIGNsb3Nlc3QgdG8gdGhlIGVuY29kZXIuCj4gPj4+PiArICoKPiA+Pj4+ICsgKiBS RVRVUk5TOgo+ID4+Pj4gKyAqIE1PREVfT0sgb24gc3VjY2VzcywgZHJtX21vZGVfc3RhdHVzIEVu dW0gZXJyb3IgY29kZSBvbiBmYWlsdXJlCj4gPj4+PiArICovCj4gPj4+PiArZW51bSBkcm1fbW9k ZV9zdGF0dXMgZHJtX2JyaWRnZV9tb2RlX3ZhbGlkKHN0cnVjdCBkcm1fYnJpZGdlICpicmlkZ2Us Cj4gPj4+PiArCQkJCQkgICBjb25zdCBzdHJ1Y3QgCmRybV9kaXNwbGF5X21vZGUKPiA+IAo+ID4g Km1vZGUpCj4gPiAKPiA+Pj4+ICt7Cj4gPj4+PiArCWVudW0gZHJtX21vZGVfc3RhdHVzIHJldCA9 IE1PREVfT0s7Cj4gPj4+PiArCj4gPj4+PiArCWlmICghYnJpZGdlKQo+ID4+Pj4gKwkJcmV0dXJu IHJldDsKPiA+Pj4+ICsKPiA+Pj4+ICsJaWYgKGJyaWRnZS0+ZnVuY3MtPm1vZGVfdmFsaWQpCj4g Pj4+PiArCQlyZXQgPSBicmlkZ2UtPmZ1bmNzLT5tb2RlX3ZhbGlkKGJyaWRnZSwgbW9kZSk7Cj4g Pj4+PiArCj4gPj4+PiArCWlmIChyZXQgIT0gTU9ERV9PSykKPiA+Pj4+ICsJCXJldHVybiByZXQ7 Cj4gPj4+PiArCj4gPj4+PiArCXJldHVybiBkcm1fYnJpZGdlX21vZGVfdmFsaWQoYnJpZGdlLT5u ZXh0LCBtb2RlKTsKPiA+Pj4gCj4gPj4+IExvb2tzIGxpa2UgaXQgc2hvdWxkIGJlIHByZXR0eSB0 cml2aWFsIHRvIGF2b2lkIHRoZSByZWN1cnNpb24uCj4gPj4+IAo+ID4+PiBBbSBJIGNvcnJlY3Qg aW4gaW50ZXJwcmV0aW5nIHRoaXMgdGhhdCBicmlkZ2VzIGhhdmUgc29tZSBraW5kIG9mCj4gPj4+ IGEgaGFuZCByb2xsZWQgbGlua2VkIGxpc3QgaW1wbGVtZW50YXRpb24/IFJldXNpbmcgdGhlIHN0 YW5kYXJkCj4gPj4+IGxpbmtlZCBsaXN0cyB3b3VsZCBhbGxvdyB5b3UgdG8gdXNlIGxpc3RfZm9y X2VhY2goKSBldGMuCj4gPj4gCj4gPj4gWWVhaCBpdCdzIGEgaGFuZC1yb2xsZWQgbGlzdCwgYnV0 IGN1cnJlbnQgaHcgYWxzbyBoYXMgYSBicmlkZ2UgbmVzdGluZwo+ID4+IGRlcHRoIG9mIDIsIHNv IGl0IHJlYWxseSBkb2Vzbid0IG1hdHRlci4gSSBndWVzcyBvbmNlIHdlIGhhdmUgcmVhbCBsb25n Cj4gPj4gY2hhaW5zIG9mIGJyaWRnZXMgd2UgY2FuIGZpeCB0aGlzIChhbmQganVzdCB1c2luZyBs aXN0X2hlYWQgc291bmRzIGxpa2UgYQo+ID4+IGdyZWF0IGlkZWEpLgo+ID4gCj4gPiBFdmVuIGlm IG5vdCByZWFsbHkgbmVlZGVkIHJpZ2h0IG5vdywgaXQncyBhIHByZXR0eSBlYXN5IGNsZWFudXAs IGlmIEpvc2UKPiA+IGhhcyB0aW1lIHRvIGhhbmRsZSBpdCBpbiB2MyBvZiB0aGlzIHNlcmllcyBs ZXQncyBub3QgcG9zdHBvbmUgaXQgOy0pCj4gCj4gamZ5aSwgc29tZSBvZiB0aGUgYnJpZGdlIGZ1 bmN0aW9ucyBjYWxsIHRoZSBvcHMgZnJvbSB0aGUgbGFzdCBicmlkZ2UgaW4gdGhlCj4gY2hhaW4g dG8gZmlyc3QsIHNvIHdlJ2QgbmVlZCB0byB1c2UgbGlzdF9mb3JfZWFjaF9lbnRyeV9wcmV2KCkg KG9yIHNvbWV0aGluZwo+IGxpa2UgdGhhdCkgZm9yIHRoZW0uCgpBbmQgbm93IHRoYXQgSSB0aGlu ayBhYm91dCBpdCwgZm9yIHNvbWUgb2YgdGhlIG9wZXJhdGlvbnMgKGVzcGVjaWFsbHkgCmVuYWJs ZS9kaXNhYmxlKSBJIGJlbGlldmUgdGhhdCB0aGUgYnJpZGdlIHNob3VsZCBiZSBhYmxlIHRvIGRl Y2lkZSB3aGV0aGVyIHRvIApjYWxsIHRoZSBuZXh0L3ByZXZpb3VzIGJyaWRnZSBmaXJzdCBvciB0 byBjb25maWd1cmUgaXRzIGhhcmR3YXJlIGZpcnN0LiBJIGNhbiAKaW1hZ2UgYnJpZGdlcyB0aGF0 IG5lZWQgdGhlIHByZXZpb3VzIGJyaWRnZSBpbiB0aGUgY2hhaW4gdG8gcHJvdmlkZSBhIHZhbGlk IApjbG9jayBiZWZvcmUgdGhleSBnZXQgc3RhcnRlZCwgYXMgd2VsbCBhcyBicmlkZ2VzIHRoYXQg bmVlZCB0byBiZSBzdGFydGVkIHdpdGggCnRoZSBpbmNvbWluZyB2aWRlbyBzaWduYWwgc3RvcHBl ZC4KCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==