From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] tools: fix active interface detection in dpdk-devbind.py Date: Mon, 30 Jan 2017 17:34:06 +0100 Message-ID: <2205422.pXPzrLqdEW@xps13> References: <1483979853-16386-1-git-send-email-yonig@radcom.com> <1484068461-22978-1-git-send-email-yonig@radcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, pablo.de.lara.guarch@intel.com To: Yoni Gilad Return-path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 02C5D38EB for ; Mon, 30 Jan 2017 17:34:08 +0100 (CET) Received: by mail-wm0-f47.google.com with SMTP id b65so39901724wmf.0 for ; Mon, 30 Jan 2017 08:34:08 -0800 (PST) In-Reply-To: <1484068461-22978-1-git-send-email-yonig@radcom.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-01-10 17:14, Yoni Gilad: > When adding crypto devices, the "Active" and "Ssh_if" attributes of > existing network devices were reset. This causes the following issues: > > - Network interfaces aren't marked as "*Active*" in the --status output. > - Active network interfaces can be unbound without the --force option, > causing loss of network connection. > > The reset was caused by the call to devices[d].update in > get_crypto_details. > > This patch prevents the update on non-crypto devices. > > Fixes: cb4a1d14bf3e ("tools: bind crypto devices") > > CC: stable@dpdk.org > > Signed-off-by: Yoni Gilad > Acked-by: Pablo de Lara Applied, thanks