Re: Osstest nested patch v15 (was RE: [OSSTEST PATCH v14 PART 2 10-26/26] Nested HVM testing)

[Ian Jackson <Ian.Jackson@eu.citrix.com>]

Hu, Robert writes ("RE: Osstest nested patch v15 (was RE: [OSSTEST PATCH v14 PART 2 10-26/26] Nested HVM testing)"):
> Here is detail logs

Thanks.  Most of this is fine.

> 2015-11-12 03:21:43 Z serial: collecting logs for l1.guest.osstest
> Use of uninitialized value in concatenation (.) or string at Osstest/Serial/guest.pm line 91.
> Use of uninitialized value in concatenation (.) or string at Osstest/Serial/guest.pm line 91.

This is me being idiotic.  I have a patch below which I'm pretty sure
will fix it.  Anyway, I don't think I need it retested for this reason
because this is just a wrong log message, which we can fix in-tree if
necessary.

What I want to know is whether the l1 serial console logfile was
collected, and contains the debug output.

I think you should find this in the output of the ts-logs-capture for
the host (L0).  Something like

2015-11-12 03:21:48 Z fetching /var/log/xen/osstest-serial-l1.guest.osstest.log to MYHOSTNAME---var-log-xen-osstest-serial-l1.guest.osstest.log

If you look in the logs directory, do you have a file matching
*-serial-l1.* ?  If so, can you send it to me ?  I think (hope)! it
will have the debug keys.

Thanks,
Ian.

diff --git a/Osstest/Serial/guest.pm b/Osstest/Serial/guest.pm
index 286773d..2511556 100644
--- a/Osstest/Serial/guest.pm
+++ b/Osstest/Serial/guest.pm
@@ -86,7 +86,7 @@ sub keys_shutdown {
 }
 
 sub fetch_logs {
-    my ($mo);
+    my ($mo) = @_;
 
     logm("$mo->{Target}{Name} (nested host) serial console logs".
 	 " will be found in guest logs from $mo->{Parent}{Name} (parent)");