All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Jim Fehlig <jfehlig@suse.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [RFC] libxl: relax readonly check introduced by XSA-142 fix
Date: Thu, 12 Nov 2015 16:13:17 +0000	[thread overview]
Message-ID: <22084.47773.134463.555077@mariner.uk.xensource.com> (raw)
In-Reply-To: <5644B410.4080000@suse.com>

Jim Fehlig writes ("Re: [RFC] libxl: relax readonly check introduced by XSA-142 fix"):
> Stefano Stabellini wrote:
> > I don't think that libxl CODING_STYLE requires brackets for one statement
> > blocks. But I won't enforce it.

Thanks for all the work on this, Jim, and Stefano.  It looks good to
me.  The only thing I found to comment on was this tiny nit:

> I can remove the unneeded brackets if desired. That habit comes from
> working on projects where all if/else blocks are required to have
> brackets when any one of the blocks requires brackets.

This isn't in CODING_STYLE but it probably should be.  I would prefer
it with the brackets.  (But I'll accept the patch either way.)

Ian.

  reply	other threads:[~2015-11-12 16:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-11 17:15 [RFC] libxl: relax readonly check introduced by XSA-142 fix Jim Fehlig
2015-11-12 12:01 ` Stefano Stabellini
2015-11-12 15:45   ` Jim Fehlig
2015-11-12 16:13     ` Ian Jackson [this message]
2015-11-12 16:26     ` Ian Campbell
2015-11-12 17:53       ` Jim Fehlig
2015-11-13  9:22         ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22084.47773.134463.555077@mariner.uk.xensource.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=jfehlig@suse.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.