From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH V8 2/7] libxl_read_file_contents: add new
 entry to read sysfs file
Date: Mon, 16 Nov 2015 18:15:15 +0000
Message-ID: <22090.7475.996517.170603@mariner.uk.xensource.com>
References: <1445418510-19614-1-git-send-email-cyliu@suse.com>
	<1445418510-19614-3-git-send-email-cyliu@suse.com>
	<1447682606.27871.109.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1447682606.27871.109.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: jgross@suse.com, wei.liu2@citrix.com, george.dunlap@eu.citrix.com, Chunyan Liu <cyliu@suse.com>, xen-devel@lists.xen.org, jfehlig@suse.com
List-Id: xen-devel@lists.xenproject.org

Ian Campbell writes ("Re: [PATCH V8 2/7] libxl_read_file_contents: add new =
entry to read sysfs file"):
> @@ -359,20 +360,35 @@ int libxl_read_file_contents(libxl_ctx *ctx, const
> > char *filename,
> > =A0=A0=A0=A0=A0datalen =3D stab.st_size;
> > =A0
> > =A0=A0=A0=A0=A0if (stab.st_size && data_r) {
> > -=A0=A0=A0=A0=A0=A0=A0=A0data =3D malloc(datalen);
> > +=A0=A0=A0=A0=A0=A0=A0=A0data =3D malloc(datalen + 1);
> =

> This (and the related change) seem to be fixing an off by one bug in the
> existing code? At a minimum this should be mentioned in the commit message
> but ideally it would be split out into a precursor code, so as to allow it
> to be backported (assuming it is a bug fix and not some other consequence
> of reading from sysfs).

There is no off-by-one error in the existing code.  I think this +1
arises because Chunyan wants libxl__read_sysfs_file_contents to
produce a nul-terminated string, even though libxl_read_file_contents
doesn't.

In June I wrote:

  If you want to make an API which is useable for [code which wants a
  trailing nul], and not intended for byte blocks, that's fine, but
  you must then always nul-terminate (not only if the data was less
  than 4k) and your new function probably doesn't want to return a
  length at all.

I am coming to the thought that it might be better for this to be two
functions with entirely separate implementations.  The resulting
unified function is already full of tangled conditional logic, and our
complaint here will involve yet another conditional.

Ian.