From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19E66C433F5 for ; Wed, 2 Mar 2022 11:01:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241177AbiCBLCX (ORCPT ); Wed, 2 Mar 2022 06:02:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241175AbiCBLCV (ORCPT ); Wed, 2 Mar 2022 06:02:21 -0500 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DDEC6D85C for ; Wed, 2 Mar 2022 03:01:38 -0800 (PST) Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 4E1C13F5F9 for ; Wed, 2 Mar 2022 11:01:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1646218895; bh=Si9sQ7yLz6JK6Nen6lACTBVX2ecHMiwS0ByLXYRxjJA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ilcPuStkkOSXcrQlPpgyR3RC0LVaMRHDnDtwKcf/x0PpMKYEjsDD7cQJxuAr5SIrK 5z2zkx4PJCe7j1EX18NJg9igSjx2ka5eVTyyr7Re+IzksWWCCb2r2xkJLdkwI6owGQ uIyVgu6dRPwrnXc97TZheCvA9uXwMK3IiJOv+MRVHSfimjjVH+DW7cahaVDwRLANn3 jb++Bx+2TQ59B4cTYLISiBBMbRHZTcoohn40zcWKR34MCJlZX46zhMMjBAGpBU2ms9 yr8o4xpM2KgDEVjdywtHVBrJwI4o44GyJVUqsF3WTHb3IYEPRYdYfASM3eW+k0CrLL jcLLE9X9/vpig== Received: by mail-ej1-f69.google.com with SMTP id o22-20020a1709061d5600b006d1aa593787so830268ejh.0 for ; Wed, 02 Mar 2022 03:01:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Si9sQ7yLz6JK6Nen6lACTBVX2ecHMiwS0ByLXYRxjJA=; b=Nppse4Kd50byau++XZFEfznMUfX1W3wZX7JSZANBsiPUldKpGVgj8jPmthz0VxoN9Z Jh27fg3YKJ8mXRU6NCbyt3472PKutBjj4oYdJwwX6cCXmBAHRaeP95YLM54MShvEzrh3 wnf/6U1cLI8fDb2kcJ4hVITW59yMlRbpbXBwdL6zSXp9WaWHajmAzGWGfYxqyqslebK2 vKxMzFQ74bOI5HvhVI+HD4gxO++k8utGtdunME2tNX3SoJWvXpRp0EKW3zIECwW4vpEr GEv52d+xcs2EoIdHhmtT8bKEJWrf1N85X5J3TojucyiERYiRQ9Yf3ov4xa74kvalmvuI Qjqw== X-Gm-Message-State: AOAM530kQv0gdHa89Vml53ESsuZQEemcbj0dUpNEaYexnT0fhtS3qbzg AKE94+iZDMHwbJiOMh3ORLSbwNHLZC3Udj8nis/Md/PZb5RaQsO8lIchfArxRQUGSmCpGsZm7Ms JEjyi/I/2bopvVn5+CRmSZZnqC7jnarcaiDfUUw2nfWqLFLg= X-Received: by 2002:a05:6402:369a:b0:413:81b5:7b64 with SMTP id ej26-20020a056402369a00b0041381b57b64mr22935782edb.163.1646218881684; Wed, 02 Mar 2022 03:01:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJwaXIpVKlG8abGyix74I9rTqmFoJz7zygw3QnLROE8hwqkRWj9/wBCxZT5ACGsypW51MBpi7Q== X-Received: by 2002:a05:6402:369a:b0:413:81b5:7b64 with SMTP id ej26-20020a056402369a00b0041381b57b64mr22935729edb.163.1646218881424; Wed, 02 Mar 2022 03:01:21 -0800 (PST) Received: from [192.168.0.136] (xdsl-188-155-181-108.adslplus.ch. [188.155.181.108]) by smtp.gmail.com with ESMTPSA id et3-20020a170907294300b006d6534ef273sm5617821ejc.156.2022.03.02.03.01.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Mar 2022 03:01:20 -0800 (PST) Message-ID: <22099da9-fad0-a5fb-f45a-484635ca485f@canonical.com> Date: Wed, 2 Mar 2022 12:01:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v3 06/11] s390: cio: Use driver_set_override() instead of open-coding Content-Language: en-US To: Vineeth Vijayan , Greg Kroah-Hartman , "Rafael J. Wysocki" , Stuart Yoder , Laurentiu Tudor , Abel Vesa , Shawn Guo , Sascha Hauer , Fabio Estevam , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Bjorn Helgaas , Bjorn Andersson , Mathieu Poirier , Peter Oberparleiter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Andy Gross , Srinivas Kandagatla , Mark Brown , "Michael S. Tsirkin" , Jason Wang , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-spi@vger.kernel.org, virtualization@lists.linux-foundation.org, Linus Torvalds Cc: Rasmus Villemoes References: <20220227135214.145599-1-krzysztof.kozlowski@canonical.com> <20220227135214.145599-7-krzysztof.kozlowski@canonical.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On 01/03/2022 17:01, Vineeth Vijayan wrote: > > On 2/27/22 14:52, Krzysztof Kozlowski wrote: >> Use a helper for seting driver_override to reduce amount of duplicated >> code. Make the driver_override field const char, because it is not >> modified by the core and it matches other subsystems. > s/seting/setting/ > > Also could you please change the title to start with "s390/cio:" > instead of "s390 : cio" > Sure, thanks for review! Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 997C1C433EF for ; Wed, 2 Mar 2022 11:02:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HygQG/rJqrrvfmD/BSrvq5VeIaD0Hj+dEEyBcIyU/Rg=; b=eoWYajFHTb0PjL n22/oeRo/WbPDSLJqKad9QYh/HmgDUiGhIIZb+nu82jX+nBDA4U05OcoO54GQY8PxYE6TNpWqpezz LwizYTPWhPeMwKrRVddUeb2JvtNjMOZkHVMD2sXTGCB1CrXssdz+GOe/OwL8IDCPI7Nj3qR0Krcld LRgtNPlZqC68p3QUjpNf0vaecBpnxtMi8RrwwzB7ck2XQnJ+hUqCe2bSA/Ylmlu6ObLP2dX0nuv91 mtu4PYtt/29uhhOHsFkJ8lYRnv3wwoe9Cb4OF7QfONGOQA142hp4dV8qqab9xbk3rkUHbVRDsK4Nh SbC+/tLMdEBog5xuJsXg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nPMjY-002Mn6-Rr; Wed, 02 Mar 2022 11:01:29 +0000 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nPMjV-002MmT-Hu for linux-arm-kernel@lists.infradead.org; Wed, 02 Mar 2022 11:01:26 +0000 Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 435463F605 for ; Wed, 2 Mar 2022 11:01:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1646218883; bh=Si9sQ7yLz6JK6Nen6lACTBVX2ecHMiwS0ByLXYRxjJA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Otl600XWsN7VkMsCgZY6G3LVJR59D4DTJ9IdTj7JHfJfF2knbcQD2GVOlGdswAqty 0rJHBIdZNMj4rXg8PeEhwf6YF58puLckZ+qvM0I0YSls8Uv0epO2xr6IcTroEZTq7g PmRRGuHZHOv3rIL3Xy+jH1yqSZcMXCFiD0rOhI/Y/4FTlFhnJSLfYt2cAdCMzetEom y41TlUus1bCL7VJSOOlGqt4PqN4dTpKHGOkq7xcWxYZqEzFINJE4Lzi2pBz1L/64n2 o2sIM8YZo8HnRYKjIiiP90kKfxXHrBbjvIMxZ4MwIiZtZpY/PeeS7Hb5zo6GD8+ZhL fabjnJAUklNEA== Received: by mail-ed1-f72.google.com with SMTP id u28-20020a50d51c000000b004159ffb8f24so796404edi.4 for ; Wed, 02 Mar 2022 03:01:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Si9sQ7yLz6JK6Nen6lACTBVX2ecHMiwS0ByLXYRxjJA=; b=OkC1CBdx5S1PRgkWiHaZ648xvIyjPccp59avgy/BSbRre0PJ7wYteXtn7uBrWYSYgD MahvGA9XgddZF60VjjSPPrKxI69zLZqeVM3JtPw9m1UUStC2CHGoHucGYMJUa51ZqrCX bmEexSkZL9ywA8veO5PrWOhDLL2PCaFQviipqoI3IhdJ+Mw+mR19q7Bi8W0FomqJVb8G 3Mr5z+Pz0zBZcfUpwqE7qLHBEw/yOxdRQlLw95uWNN2X6MUzo6M1xbKGhySeVZ7eHIdW 9+gFqIZ+OI+4XyQITy7qdXeYjlbAclDO2j3xILbZcLQxg18helINpPmk0ed1SBeIBppW u+Cw== X-Gm-Message-State: AOAM531ltKgBb5qohbl9ex7ei3xhb+BFED4OyQ0rasEcoSF4KZFwGhyl n9bOR96DABpjtGY73g3hilugSnnZXCNlKepZzkCraDTp5baKzYcuhrVYWxCgYNVl7M5Zf1mChfe hd5tz1/syeN56eEgDRNmhMmEq6vvhyq+bx2RQRHLuVvsmccmGYhGg X-Received: by 2002:a05:6402:369a:b0:413:81b5:7b64 with SMTP id ej26-20020a056402369a00b0041381b57b64mr22935745edb.163.1646218881613; Wed, 02 Mar 2022 03:01:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJwaXIpVKlG8abGyix74I9rTqmFoJz7zygw3QnLROE8hwqkRWj9/wBCxZT5ACGsypW51MBpi7Q== X-Received: by 2002:a05:6402:369a:b0:413:81b5:7b64 with SMTP id ej26-20020a056402369a00b0041381b57b64mr22935729edb.163.1646218881424; Wed, 02 Mar 2022 03:01:21 -0800 (PST) Received: from [192.168.0.136] (xdsl-188-155-181-108.adslplus.ch. [188.155.181.108]) by smtp.gmail.com with ESMTPSA id et3-20020a170907294300b006d6534ef273sm5617821ejc.156.2022.03.02.03.01.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Mar 2022 03:01:20 -0800 (PST) Message-ID: <22099da9-fad0-a5fb-f45a-484635ca485f@canonical.com> Date: Wed, 2 Mar 2022 12:01:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v3 06/11] s390: cio: Use driver_set_override() instead of open-coding Content-Language: en-US To: Vineeth Vijayan , Greg Kroah-Hartman , "Rafael J. Wysocki" , Stuart Yoder , Laurentiu Tudor , Abel Vesa , Shawn Guo , Sascha Hauer , Fabio Estevam , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Bjorn Helgaas , Bjorn Andersson , Mathieu Poirier , Peter Oberparleiter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Andy Gross , Srinivas Kandagatla , Mark Brown , "Michael S. Tsirkin" , Jason Wang , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-spi@vger.kernel.org, virtualization@lists.linux-foundation.org, Linus Torvalds Cc: Rasmus Villemoes References: <20220227135214.145599-1-krzysztof.kozlowski@canonical.com> <20220227135214.145599-7-krzysztof.kozlowski@canonical.com> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220302_030125_752454_8B4ABA2A X-CRM114-Status: GOOD ( 14.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 01/03/2022 17:01, Vineeth Vijayan wrote: > > On 2/27/22 14:52, Krzysztof Kozlowski wrote: >> Use a helper for seting driver_override to reduce amount of duplicated >> code. Make the driver_override field const char, because it is not >> modified by the core and it matches other subsystems. > s/seting/setting/ > > Also could you please change the title to start with "s390/cio:" > instead of "s390 : cio" > Sure, thanks for review! Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel