From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vidya Sagar Subject: Re: [PATCH V7 02/15] PCI: Disable MSI for Tegra194 root port Date: Wed, 22 May 2019 01:04:58 +0530 Message-ID: <220fcb99-c3b5-58dc-a37a-57cbe9efa072@nvidia.com> References: <20190517123846.3708-1-vidyas@nvidia.com> <20190517123846.3708-3-vidyas@nvidia.com> <20190521102729.GB29166@ulmo> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Thierry Reding Cc: lorenzo.pieralisi@arm.com, bhelgaas@google.com, robh+dt@kernel.org, mark.rutland@arm.com, jonathanh@nvidia.com, kishon@ti.com, catalin.marinas@arm.com, will.deacon@arm.com, jingoohan1@gmail.com, gustavo.pimentel@synopsys.com, mperttunen@nvidia.com, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kthota@nvidia.com, mmaddireddy@nvidia.com, sagar.tv@gmail.com List-Id: linux-tegra@vger.kernel.org On 5/21/2019 10:17 PM, Vidya Sagar wrote: > On 5/21/2019 3:57 PM, Thierry Reding wrote: >> On Fri, May 17, 2019 at 06:08:33PM +0530, Vidya Sagar wrote: >>> Tegra194 rootports don't generate MSI interrupts for PME events and hen= ce >>> MSI needs to be disabled for them to avoid root ports service drivers >>> registering their respective ISRs with MSI interrupt. >>> >>> Signed-off-by: Vidya Sagar >>> --- >>> Changes since [v6]: >>> * This is a new patch >>> >>> =A0 drivers/pci/quirks.c | 14 ++++++++++++++ >>> =A0 1 file changed, 14 insertions(+) >>> >>> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c >>> index 0f16acc323c6..28f9a0380df5 100644 >>> --- a/drivers/pci/quirks.c >>> +++ b/drivers/pci/quirks.c >>> @@ -2592,6 +2592,20 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_NVIDIA, >>> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 PCI_DEVICE_ID_NVIDIA_NVENET_15, >>> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 nvenet_msi_disable); >>> +/* >>> + * Tegra194's PCIe root ports don't generate MSI interrupts for PME ev= ents >>> + * instead legacy interrupts are generated. Hence, to avoid service dr= ivers >>> + * registering their respective ISRs for MSIs, need to disable MSI int= errupts >>> + * for root ports. >>> + */ >>> +static void disable_tegra194_rp_msi(struct pci_dev *dev) >>> +{ >>> +=A0=A0=A0 dev->no_msi =3D 1; >>> +} >>> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_NVIDIA, 0x1ad0, disable_tegra194= _rp_msi); >>> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_NVIDIA, 0x1ad1, disable_tegra194= _rp_msi); >>> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_NVIDIA, 0x1ad2, disable_tegra194= _rp_msi); >>> + >> >> Later functions in this file seem to use a more consistent naming >> pattern, according to which the name for this would become: >> >> =A0=A0=A0=A0pci_quirk_nvidia_tegra194_disable_rp_msi >> >> Might be worth considering making this consistent. >> >> This could also be moved to the DWC driver to restrict this to where it >> is needed. In either case, this seems like a good solution, so: >> >> Reviewed-by: Thierry Reding >> > Ok. I'll move it to DWC driver along with name change for the quirk API. >=20 I see that if quirk macros and API are present in pcie-tegra194.c file and = driver is built as a module, quirk API is not getting invoked by the system, whereas it get= s invoked if driver is built into kernel. Is this behavior expected? I think it is because of q= uirk API symbol not available as part of global quirk symbol table when driver is built as = a module? for now, I'm going to keep quirk macros and API in pci/quirks.c file itself= . From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7609BC04AAF for ; Tue, 21 May 2019 19:35:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 32340217F9 for ; Tue, 21 May 2019 19:35:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="Pr4XuljV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727547AbfEUTfJ (ORCPT ); Tue, 21 May 2019 15:35:09 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:14132 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727377AbfEUTfJ (ORCPT ); Tue, 21 May 2019 15:35:09 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 21 May 2019 12:35:07 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Tue, 21 May 2019 12:35:06 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 21 May 2019 12:35:06 -0700 Received: from [10.25.72.115] (172.20.13.39) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 21 May 2019 19:35:01 +0000 Subject: Re: [PATCH V7 02/15] PCI: Disable MSI for Tegra194 root port From: Vidya Sagar To: Thierry Reding CC: , , , , , , , , , , , , , , , , , , References: <20190517123846.3708-1-vidyas@nvidia.com> <20190517123846.3708-3-vidyas@nvidia.com> <20190521102729.GB29166@ulmo> X-Nvconfidentiality: public Message-ID: <220fcb99-c3b5-58dc-a37a-57cbe9efa072@nvidia.com> Date: Wed, 22 May 2019 01:04:58 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1558467307; bh=BZ2BIbzj5D7Ss2aLhzoWXgSRs8f/dBCrJl7cBh1DHuw=; h=X-PGP-Universal:Subject:From:To:CC:References:X-Nvconfidentiality: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=Pr4XuljVobWvPLT6veT/0/GmsErJZdmsGM1t1ifHwtcsEWiKNszVBeFNivXaGp6WG /XfrDcL8vAj6aAb63WyGlpAjMEgAFVybAo9eaRma55mRch4OGR7qNNvr1BPO0ktTza FJnN6agdqSzG4cMcsZI+che0lf+S/Zw2UYeumX0MXvm2Jaz4Vz8HlY7N4WTyR1nZCP /HwUWL4t1SbuCFsfew2zu5pyeABkANCRPx1lKbHAJQt7HtYGgSH0zWsYM47FGlVlOI o7MchRfrlBKGhTM2vtQGZ9WlWg1+J5IU/83DRd6iUmv+5tibGVE+ktHnY9+yZYBacZ 6oE0nozZhIVhg== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/21/2019 10:17 PM, Vidya Sagar wrote: > On 5/21/2019 3:57 PM, Thierry Reding wrote: >> On Fri, May 17, 2019 at 06:08:33PM +0530, Vidya Sagar wrote: >>> Tegra194 rootports don't generate MSI interrupts for PME events and hen= ce >>> MSI needs to be disabled for them to avoid root ports service drivers >>> registering their respective ISRs with MSI interrupt. >>> >>> Signed-off-by: Vidya Sagar >>> --- >>> Changes since [v6]: >>> * This is a new patch >>> >>> =A0 drivers/pci/quirks.c | 14 ++++++++++++++ >>> =A0 1 file changed, 14 insertions(+) >>> >>> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c >>> index 0f16acc323c6..28f9a0380df5 100644 >>> --- a/drivers/pci/quirks.c >>> +++ b/drivers/pci/quirks.c >>> @@ -2592,6 +2592,20 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_NVIDIA, >>> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 PCI_DEVICE_ID_NVIDIA_NVENET_15, >>> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 nvenet_msi_disable); >>> +/* >>> + * Tegra194's PCIe root ports don't generate MSI interrupts for PME ev= ents >>> + * instead legacy interrupts are generated. Hence, to avoid service dr= ivers >>> + * registering their respective ISRs for MSIs, need to disable MSI int= errupts >>> + * for root ports. >>> + */ >>> +static void disable_tegra194_rp_msi(struct pci_dev *dev) >>> +{ >>> +=A0=A0=A0 dev->no_msi =3D 1; >>> +} >>> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_NVIDIA, 0x1ad0, disable_tegra194= _rp_msi); >>> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_NVIDIA, 0x1ad1, disable_tegra194= _rp_msi); >>> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_NVIDIA, 0x1ad2, disable_tegra194= _rp_msi); >>> + >> >> Later functions in this file seem to use a more consistent naming >> pattern, according to which the name for this would become: >> >> =A0=A0=A0=A0pci_quirk_nvidia_tegra194_disable_rp_msi >> >> Might be worth considering making this consistent. >> >> This could also be moved to the DWC driver to restrict this to where it >> is needed. In either case, this seems like a good solution, so: >> >> Reviewed-by: Thierry Reding >> > Ok. I'll move it to DWC driver along with name change for the quirk API. >=20 I see that if quirk macros and API are present in pcie-tegra194.c file and = driver is built as a module, quirk API is not getting invoked by the system, whereas it get= s invoked if driver is built into kernel. Is this behavior expected? I think it is because of q= uirk API symbol not available as part of global quirk symbol table when driver is built as = a module? for now, I'm going to keep quirk macros and API in pci/quirks.c file itself= . From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D1AEC04AAF for ; Tue, 21 May 2019 19:35:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5426F217D9 for ; Tue, 21 May 2019 19:35:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dhrG7AxK"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="Pr4XuljV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5426F217D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:References: To:From:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=k10dauKegIS/wWv/f/dfJz650YxHPDI5aE90WKTdzAI=; b=dhrG7AxK1sInhxi1EugwCYPtw LvaxBbFNSapfeSdrcRtpWhXNup0L7bfo+cPWUf3Jk5h4qY6axE7+RWf14oQ7H6TXV+8JKplJ2kODT tDYbtr0ctWqm0YMA+CNN3fIhidf6eKHxPVzCNnbnfcI8JqQL+b4D3sZbl5kw8OQ4mpkIL6Qk3OQrr g/qiHLaqKrcZJhCXSkLZ00XrIi5Rk4mS8DGAoKt6qRp58m5u4c/DLQpf7kK4FID3ImVWUXJdEJqBm H11RfNHCJEGS01W5zX124RmmP8X6nyf3Q8w1/BPk0xkKA2FbMd4/W+mmtB2IioOZHNN0awWBgvieW 0Pad8OVLA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hTAXX-00007p-6w; Tue, 21 May 2019 19:35:11 +0000 Received: from hqemgate16.nvidia.com ([216.228.121.65]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hTAXU-0008Pj-17 for linux-arm-kernel@lists.infradead.org; Tue, 21 May 2019 19:35:09 +0000 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 21 May 2019 12:35:07 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Tue, 21 May 2019 12:35:06 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 21 May 2019 12:35:06 -0700 Received: from [10.25.72.115] (172.20.13.39) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 21 May 2019 19:35:01 +0000 Subject: Re: [PATCH V7 02/15] PCI: Disable MSI for Tegra194 root port From: Vidya Sagar To: Thierry Reding References: <20190517123846.3708-1-vidyas@nvidia.com> <20190517123846.3708-3-vidyas@nvidia.com> <20190521102729.GB29166@ulmo> X-Nvconfidentiality: public Message-ID: <220fcb99-c3b5-58dc-a37a-57cbe9efa072@nvidia.com> Date: Wed, 22 May 2019 01:04:58 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1558467307; bh=BZ2BIbzj5D7Ss2aLhzoWXgSRs8f/dBCrJl7cBh1DHuw=; h=X-PGP-Universal:Subject:From:To:CC:References:X-Nvconfidentiality: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=Pr4XuljVobWvPLT6veT/0/GmsErJZdmsGM1t1ifHwtcsEWiKNszVBeFNivXaGp6WG /XfrDcL8vAj6aAb63WyGlpAjMEgAFVybAo9eaRma55mRch4OGR7qNNvr1BPO0ktTza FJnN6agdqSzG4cMcsZI+che0lf+S/Zw2UYeumX0MXvm2Jaz4Vz8HlY7N4WTyR1nZCP /HwUWL4t1SbuCFsfew2zu5pyeABkANCRPx1lKbHAJQt7HtYGgSH0zWsYM47FGlVlOI o7MchRfrlBKGhTM2vtQGZ9WlWg1+J5IU/83DRd6iUmv+5tibGVE+ktHnY9+yZYBacZ 6oE0nozZhIVhg== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190521_123508_092396_E4CE900D X-CRM114-Status: GOOD ( 14.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, lorenzo.pieralisi@arm.com, mperttunen@nvidia.com, mmaddireddy@nvidia.com, linux-pci@vger.kernel.org, catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, kthota@nvidia.com, kishon@ti.com, linux-tegra@vger.kernel.org, robh+dt@kernel.org, gustavo.pimentel@synopsys.com, jingoohan1@gmail.com, bhelgaas@google.com, jonathanh@nvidia.com, linux-arm-kernel@lists.infradead.org, sagar.tv@gmail.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="windows-1252"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/21/2019 10:17 PM, Vidya Sagar wrote: > On 5/21/2019 3:57 PM, Thierry Reding wrote: >> On Fri, May 17, 2019 at 06:08:33PM +0530, Vidya Sagar wrote: >>> Tegra194 rootports don't generate MSI interrupts for PME events and hen= ce >>> MSI needs to be disabled for them to avoid root ports service drivers >>> registering their respective ISRs with MSI interrupt. >>> >>> Signed-off-by: Vidya Sagar >>> --- >>> Changes since [v6]: >>> * This is a new patch >>> >>> =A0 drivers/pci/quirks.c | 14 ++++++++++++++ >>> =A0 1 file changed, 14 insertions(+) >>> >>> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c >>> index 0f16acc323c6..28f9a0380df5 100644 >>> --- a/drivers/pci/quirks.c >>> +++ b/drivers/pci/quirks.c >>> @@ -2592,6 +2592,20 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_NVIDIA, >>> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 PCI_DEVICE_ID_NVIDIA_NVENET_15, >>> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 nvenet_msi_disable); >>> +/* >>> + * Tegra194's PCIe root ports don't generate MSI interrupts for PME ev= ents >>> + * instead legacy interrupts are generated. Hence, to avoid service dr= ivers >>> + * registering their respective ISRs for MSIs, need to disable MSI int= errupts >>> + * for root ports. >>> + */ >>> +static void disable_tegra194_rp_msi(struct pci_dev *dev) >>> +{ >>> +=A0=A0=A0 dev->no_msi =3D 1; >>> +} >>> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_NVIDIA, 0x1ad0, disable_tegra194= _rp_msi); >>> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_NVIDIA, 0x1ad1, disable_tegra194= _rp_msi); >>> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_NVIDIA, 0x1ad2, disable_tegra194= _rp_msi); >>> + >> >> Later functions in this file seem to use a more consistent naming >> pattern, according to which the name for this would become: >> >> =A0=A0=A0=A0pci_quirk_nvidia_tegra194_disable_rp_msi >> >> Might be worth considering making this consistent. >> >> This could also be moved to the DWC driver to restrict this to where it >> is needed. In either case, this seems like a good solution, so: >> >> Reviewed-by: Thierry Reding >> > Ok. I'll move it to DWC driver along with name change for the quirk API. > = I see that if quirk macros and API are present in pcie-tegra194.c file and = driver is built as a module, quirk API is not getting invoked by the system, whereas it get= s invoked if driver is built into kernel. Is this behavior expected? I think it is because of q= uirk API symbol not available as part of global quirk symbol table when driver is built as = a module? for now, I'm going to keep quirk macros and API in pci/quirks.c file itself. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel