From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Foss Subject: Re: [PATCH libdrm 04/10] xf86drm: Allocate drmDevicePtr's on stack Date: Thu, 28 Jun 2018 14:52:33 +0200 Message-ID: <221120fd-4719-c2c1-99fb-83c2a1a62c02@collabora.com> References: <20180625173626.8046-1-emil.l.velikov@gmail.com> <20180625173626.8046-4-emil.l.velikov@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by gabe.freedesktop.org (Postfix) with ESMTPS id ADAD16ED28 for ; Thu, 28 Jun 2018 12:52:38 +0000 (UTC) In-Reply-To: <20180625173626.8046-4-emil.l.velikov@gmail.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Emil Velikov , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGV5IEVtaWwsCgpPbiAyMDE4LTA2LTI1IDE5OjM2LCBFbWlsIFZlbGlrb3Ygd3JvdGU6Cj4gRnJv bTogRW1pbCBWZWxpa292IDxlbWlsLnZlbGlrb3ZAY29sbGFib3JhLmNvbT4KPiAKPiBDdXJyZW50 bHkgd2UgZHluYW1pY2FsbHkgYWxsb2NhdGUgMTYgcG9pbnRlcnMgYW5kIHJlYWxsb2NhdGUgbW9y ZSBhcwo+IG5lZWRlZC4KPiAKPiBJbnN0ZWFkLCBhbGxvY2F0ZSB0aGUgbWF4aW11bSBudW1iZXIg KDI1Nikgb24gc3RhY2sgLSB0aGUgbnVtYmVyIGlzCj4gc21hbGwgZW5vdWdoIGFuZCBpcyB1bmxp a2VseSB0byBjaGFuZ2UgaW4gdGhlIGZvcmVzZWVhYmxlIGZ1dHVyZS4KPiAKPiBUaGlzIGFsbG93 cyB1cyB0byBzaW1wbGlmeSB0aGUgZXJyb3IgaGFuZGxpbmcgYW5kIGV2ZW4gc2hlZCBhIGZldyBi eXRlcwo+IG9mZiB0aGUgZmluYWwgYmluYXJ5Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IEVtaWwgVmVs aWtvdiA8ZW1pbC52ZWxpa292QGNvbGxhYm9yYS5jb20+Cj4gLS0tCj4gICB4Zjg2ZHJtLmMgfCA2 NCArKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t Cj4gICAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCA1OCBkZWxldGlvbnMoLSkKPiAK PiBkaWZmIC0tZ2l0IGEveGY4NmRybS5jIGIveGY4NmRybS5jCj4gaW5kZXggMTE0Y2Y4NTUuLmQ0 ODEwNzQwIDEwMDY0NAo+IC0tLSBhL3hmODZkcm0uYwo+ICsrKyBiL3hmODZkcm0uYwo+IEBAIC0z ODQ2LDcgKzM4NDYsNyBAQCBpbnQgZHJtR2V0RGV2aWNlMihpbnQgZmQsIHVpbnQzMl90IGZsYWdz LCBkcm1EZXZpY2VQdHIgKmRldmljZSkKPiAgIAo+ICAgICAgIHJldHVybiAwOwo+ICAgI2Vsc2UK PiAtICAgIGRybURldmljZVB0ciAqbG9jYWxfZGV2aWNlczsKPiArICAgIGRybURldmljZVB0ciBs b2NhbF9kZXZpY2VzWzI1Nl07CgpUaGlzIG51bWJlciBpcyBzZWVuIGxhdGVyIG9uIGluIHRoaXMg cGF0Y2gsIG1heWJlIGl0IHNob3VsZCBiZSBicm9rZW4gb3V0IGludG8gYQpkZWZpbmUsIHNpbmNl IGl0J3MgcmV1c2VkIGxhdGVyIG9uIHRvbyBhdCBbMV0uCgo+ICAgICAgIGRybURldmljZVB0ciBk Owo+ICAgICAgIERJUiAqc3lzZGlyOwo+ICAgICAgIHN0cnVjdCBkaXJlbnQgKmRlbnQ7Cj4gQEAg LTM4NTQsNyArMzg1NCw2IEBAIGludCBkcm1HZXREZXZpY2UyKGludCBmZCwgdWludDMyX3QgZmxh Z3MsIGRybURldmljZVB0ciAqZGV2aWNlKQo+ICAgICAgIGludCBzdWJzeXN0ZW1fdHlwZTsKPiAg ICAgICBpbnQgbWFqLCBtaW47Cj4gICAgICAgaW50IHJldCwgaSwgbm9kZV9jb3VudDsKPiAtICAg IGludCBtYXhfY291bnQgPSAxNjsKPiAgICAgICBkZXZfdCBmaW5kX3JkZXY7Cj4gICAKPiAgICAg ICBpZiAoZHJtX2RldmljZV92YWxpZGF0ZV9mbGFncyhmbGFncykpCj4gQEAgLTM4NzcsMTUgKzM4 NzYsOSBAQCBpbnQgZHJtR2V0RGV2aWNlMihpbnQgZmQsIHVpbnQzMl90IGZsYWdzLCBkcm1EZXZp Y2VQdHIgKmRldmljZSkKPiAgICAgICBpZiAoc3Vic3lzdGVtX3R5cGUgPCAwKQo+ICAgICAgICAg ICByZXR1cm4gc3Vic3lzdGVtX3R5cGU7Cj4gICAKPiAtICAgIGxvY2FsX2RldmljZXMgPSBjYWxs b2MobWF4X2NvdW50LCBzaXplb2YoZHJtRGV2aWNlUHRyKSk7Cj4gLSAgICBpZiAobG9jYWxfZGV2 aWNlcyA9PSBOVUxMKQo+IC0gICAgICAgIHJldHVybiAtRU5PTUVNOwo+IC0KPiAgICAgICBzeXNk aXIgPSBvcGVuZGlyKERSTV9ESVJfTkFNRSk7Cj4gLSAgICBpZiAoIXN5c2Rpcikgewo+IC0gICAg ICAgIHJldCA9IC1lcnJubzsKPiAtICAgICAgICBnb3RvIGZyZWVfbG9jYWxzOwo+IC0gICAgfQo+ ICsgICAgaWYgKCFzeXNkaXIpCj4gKyAgICAgICAgcmV0dXJuIC1lcnJubzsKPiAgIAo+ICAgICAg IGkgPSAwOwo+ICAgICAgIHdoaWxlICgoZGVudCA9IHJlYWRkaXIoc3lzZGlyKSkpIHsKPiBAQCAt Mzg5MywxNiArMzg4Niw2IEBAIGludCBkcm1HZXREZXZpY2UyKGludCBmZCwgdWludDMyX3QgZmxh Z3MsIGRybURldmljZVB0ciAqZGV2aWNlKQo+ICAgICAgICAgICBpZiAocmV0KQo+ICAgICAgICAg ICAgICAgY29udGludWU7Cj4gICAKPiAtICAgICAgICBpZiAoaSA+PSBtYXhfY291bnQpIHsKCklz IHRoaXMgY2hlY2sgcmVhbGx5IG5vdCBuZWVkZGVkIHdoYXQgZXhhY3RseSBpcyBpdCB0aGF0IGRl ZmluZXMgMjU2IGFzIHRoZSBtYXhpbXVtPwoKIEZyb20gd2hhdCBJIHVuZGVyc3RhbmQgcmVhZGRp cihzeXNkaXIpIGlzIHRoZSBjYWxsIHRoYXQgZGVmaW5lcyBob3cgbWFueSAKZGV2aWNlcyB3aWxs IGJlIGxvb2tlZCB0aHJvdWdoLCBhbmQgYXMgZmFyIGFzIEkgdW5kZXJzdGFuZCBpdCBjYW4gcmV0 dXJuIGFuIAphcmJpdHJhcnkgbnVtYmVyIG9mIGZpbGVzLgoKPiAtICAgICAgICAgICAgZHJtRGV2 aWNlUHRyICp0ZW1wOwo+IC0KPiAtICAgICAgICAgICAgbWF4X2NvdW50ICs9IDE2Owo+IC0gICAg ICAgICAgICB0ZW1wID0gcmVhbGxvYyhsb2NhbF9kZXZpY2VzLCBtYXhfY291bnQgKiBzaXplb2Yo ZHJtRGV2aWNlUHRyKSk7Cj4gLSAgICAgICAgICAgIGlmICghdGVtcCkKPiAtICAgICAgICAgICAg ICAgIGdvdG8gZnJlZV9kZXZpY2VzOwo+IC0gICAgICAgICAgICBsb2NhbF9kZXZpY2VzID0gdGVt cDsKPiAtICAgICAgICB9Cj4gLQo+ICAgICAgICAgICBsb2NhbF9kZXZpY2VzW2ldID0gZDsKPiAg ICAgICAgICAgaSsrOwo+ICAgICAgIH0KPiBAQCAtMzkyMSwxOCArMzkwNCw5IEBAIGludCBkcm1H ZXREZXZpY2UyKGludCBmZCwgdWludDMyX3QgZmxhZ3MsIGRybURldmljZVB0ciAqZGV2aWNlKQo+ ICAgICAgIH0KPiAgIAo+ICAgICAgIGNsb3NlZGlyKHN5c2Rpcik7Cj4gLSAgICBmcmVlKGxvY2Fs X2RldmljZXMpOwo+ICAgICAgIGlmICgqZGV2aWNlID09IE5VTEwpCj4gICAgICAgICAgIHJldHVy biAtRU5PREVWOwo+ICAgICAgIHJldHVybiAwOwo+IC0KPiAtZnJlZV9kZXZpY2VzOgo+IC0gICAg ZHJtRnJlZURldmljZXMobG9jYWxfZGV2aWNlcywgaSk7Cj4gLSAgICBjbG9zZWRpcihzeXNkaXIp Owo+IC0KPiAtZnJlZV9sb2NhbHM6Cj4gLSAgICBmcmVlKGxvY2FsX2RldmljZXMpOwo+IC0gICAg cmV0dXJuIHJldDsKPiAgICNlbmRpZgo+ICAgfQo+ICAgCj4gQEAgLTM5NjgsMjUgKzM5NDIsMTgg QEAgaW50IGRybUdldERldmljZShpbnQgZmQsIGRybURldmljZVB0ciAqZGV2aWNlKQo+ICAgICov Cj4gICBpbnQgZHJtR2V0RGV2aWNlczIodWludDMyX3QgZmxhZ3MsIGRybURldmljZVB0ciBkZXZp Y2VzW10sIGludCBtYXhfZGV2aWNlcykKPiAgIHsKPiAtICAgIGRybURldmljZVB0ciAqbG9jYWxf ZGV2aWNlczsKPiArICAgIGRybURldmljZVB0ciBsb2NhbF9kZXZpY2VzWzI1Nl07JwoKWzFdCgo+ ICAgICAgIGRybURldmljZVB0ciBkZXZpY2U7Cj4gICAgICAgRElSICpzeXNkaXI7Cj4gICAgICAg c3RydWN0IGRpcmVudCAqZGVudDsKPiAgICAgICBpbnQgcmV0LCBpLCBub2RlX2NvdW50LCBkZXZp Y2VfY291bnQ7Cj4gLSAgICBpbnQgbWF4X2NvdW50ID0gMTY7Cj4gICAKPiAgICAgICBpZiAoZHJt X2RldmljZV92YWxpZGF0ZV9mbGFncyhmbGFncykpCj4gICAgICAgICAgIHJldHVybiAtRUlOVkFM Owo+ICAgCj4gLSAgICBsb2NhbF9kZXZpY2VzID0gY2FsbG9jKG1heF9jb3VudCwgc2l6ZW9mKGRy bURldmljZVB0cikpOwo+IC0gICAgaWYgKGxvY2FsX2RldmljZXMgPT0gTlVMTCkKPiAtICAgICAg ICByZXR1cm4gLUVOT01FTTsKPiAtCj4gICAgICAgc3lzZGlyID0gb3BlbmRpcihEUk1fRElSX05B TUUpOwo+IC0gICAgaWYgKCFzeXNkaXIpIHsKPiAtICAgICAgICByZXQgPSAtZXJybm87Cj4gLSAg ICAgICAgZ290byBmcmVlX2xvY2FsczsKPiAtICAgIH0KPiArICAgIGlmICghc3lzZGlyKQo+ICsg ICAgICAgIHJldHVybiAtZXJybm87Cj4gICAKPiAgICAgICBpID0gMDsKPiAgICAgICB3aGlsZSAo KGRlbnQgPSByZWFkZGlyKHN5c2RpcikpKSB7Cj4gQEAgLTM5OTQsMTYgKzM5NjEsNiBAQCBpbnQg ZHJtR2V0RGV2aWNlczIodWludDMyX3QgZmxhZ3MsIGRybURldmljZVB0ciBkZXZpY2VzW10sIGlu dCBtYXhfZGV2aWNlcykKPiAgICAgICAgICAgaWYgKHJldCkKPiAgICAgICAgICAgICAgIGNvbnRp bnVlOwo+ICAgCj4gLSAgICAgICAgaWYgKGkgPj0gbWF4X2NvdW50KSB7CgpUaGlzIG91dCBvZiBi b3VuZHMgY2hlY2sgc2hvdWxkIGJlIGRlYWx0IHdpdGggdG9vLCBpZiB0aGUgYWJvdmUgYm91bmRz IGNoZWNrIApzaG91bGQgYmUuCgo+IC0gICAgICAgICAgICBkcm1EZXZpY2VQdHIgKnRlbXA7Cj4g LQo+IC0gICAgICAgICAgICBtYXhfY291bnQgKz0gMTY7Cj4gLSAgICAgICAgICAgIHRlbXAgPSBy ZWFsbG9jKGxvY2FsX2RldmljZXMsIG1heF9jb3VudCAqIHNpemVvZihkcm1EZXZpY2VQdHIpKTsK PiAtICAgICAgICAgICAgaWYgKCF0ZW1wKQo+IC0gICAgICAgICAgICAgICAgZ290byBmcmVlX2Rl dmljZXM7Cj4gLSAgICAgICAgICAgIGxvY2FsX2RldmljZXMgPSB0ZW1wOwo+IC0gICAgICAgIH0K PiAtCj4gICAgICAgICAgIGxvY2FsX2RldmljZXNbaV0gPSBkZXZpY2U7Cj4gICAgICAgICAgIGkr KzsKPiAgICAgICB9Cj4gQEAgLTQwMjUsMTYgKzM5ODIsNyBAQCBpbnQgZHJtR2V0RGV2aWNlczIo dWludDMyX3QgZmxhZ3MsIGRybURldmljZVB0ciBkZXZpY2VzW10sIGludCBtYXhfZGV2aWNlcykK PiAgICAgICB9Cj4gICAKPiAgICAgICBjbG9zZWRpcihzeXNkaXIpOwo+IC0gICAgZnJlZShsb2Nh bF9kZXZpY2VzKTsKPiAgICAgICByZXR1cm4gZGV2aWNlX2NvdW50Owo+IC0KPiAtZnJlZV9kZXZp Y2VzOgo+IC0gICAgZHJtRnJlZURldmljZXMobG9jYWxfZGV2aWNlcywgaSk7Cj4gLSAgICBjbG9z ZWRpcihzeXNkaXIpOwo+IC0KPiAtZnJlZV9sb2NhbHM6Cj4gLSAgICBmcmVlKGxvY2FsX2Rldmlj ZXMpOwo+IC0gICAgcmV0dXJuIHJldDsKPiAgIH0KPiAgIAo+ICAgLyoqCj4gCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=