From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH 26/28] libxl: spawns two QEMUs for HVM guests
Date: Fri, 8 Jan 2016 14:35:24 +0000
Message-ID: <22159.51500.829264.401232@mariner.uk.xensource.com>
References: <1450809903-3393-1-git-send-email-ian.jackson@eu.citrix.com>
	<1450809903-3393-27-git-send-email-ian.jackson@eu.citrix.com>
	<1452187682.21055.271.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1452187682.21055.271.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: xen-devel@lists.xensource.com, Wei Liu <wei.liu2@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

Ian Campbell writes ("Re: [PATCH 26/28] libxl: spawns two QEMUs for HVM gue=
sts"):
> On Tue, 2015-12-22 at 18:45 +0000, Ian Jackson wrote:
> > @@ -440,6 +442,15 @@ static int domcreate_setdefault_dm_user(libxl__gc
> > *gc,
> > +=A0=A0=A0=A0if (!libxl__dm_supported(gc, dm,
> > libxl__dm_support_check__emulator_id)) {
> > +=A0=A0=A0=A0=A0=A0=A0=A0/* we don't want to run the pv backends as non=
-root because
> > +=A0=A0=A0=A0=A0=A0=A0=A0=A0* device hotplug will no longer work. */
> > +=A0=A0=A0=A0=A0=A0=A0=A0LOG(WARN,
> > + "Device model does not support split PV backends, running it as root"=
);
> > +=A0=A0=A0=A0=A0=A0=A0=A0user =3D "root";
> > +=A0=A0=A0=A0=A0=A0=A0=A0goto found;
> > +=A0=A0=A0=A0}
> =

> Should this be a fatal error, unless=A0b_info->device_model_user =3D=3D "=
root"?

This is in the code which sets the default value if the configuration
didn't specify one.

Ian.